Commit graph

233 commits

Author SHA1 Message Date
misaochan
05044d4b9a Add TODO to fix IllegalStateException 2018-01-25 03:30:16 +10:00
misaochan
894cd299f6 Hopefully last cleanup 2018-01-25 02:44:20 +10:00
misaochan
eee96e1d08 Remove unused imports 2018-01-25 02:35:52 +10:00
misaochan
216a113f94 Fix whitespace 2018-01-25 02:33:42 +10:00
misaochan
283275ab55 Further code cleanup 2018-01-25 02:32:36 +10:00
misaochan
40495d91ab Remove unnecessary getters in ShareActivity 2018-01-24 22:00:24 +10:00
misaochan
83bdbccd26 Retrieve title/desc via Dagger injection in SingleUploadFragment 2018-01-24 21:58:50 +10:00
misaochan
ed395a5af5 Add comments 2018-01-02 21:41:23 +10:00
misaochan
0401eb781c Add check in SingleUploadFragment for isNearbyUploadf 2018-01-02 21:38:01 +10:00
misaochan
b719491dcf Pass nearby Title and Desc to SingleUploadFragment 2018-01-02 21:33:10 +10:00
misaochan
565e61c0d1 Tidy up and create framework for autofilling EditText 2018-01-02 21:22:09 +10:00
misaochan
ccb0c87b5f Change to getSharedPreferences to pass prefs between activities 2018-01-02 21:15:04 +10:00
misaochan
ef3eda7d10 Create boolean for isDirectUpload and pass shared prefs to ShareActivity.java 2018-01-02 21:01:00 +10:00
Dmitry Brant
da82466a17 Take out legacy event logging from app.
These are especially old bits of code, where it seems like WMF folks had set up Eventlogging schemas for some rudimentary analytics of the Commons app. These schemas are no longer queried or monitored, and can be safely removed. When the Commons app has a stronger need for more meaningful analytics, we can revisit reintroducing new and better schemas.
2017-12-05 23:01:55 -05:00
Paul Hawke
17e1ff20d7 Update based on code-review feedback. 2017-11-25 11:46:41 -06:00
Paul Hawke
02b5b9b680 Merge branch 'master' into dependency-injection 2017-11-24 22:30:08 -06:00
maskara
16ee2b87ec Fix: Crash because of no file found error while uploading 2017-11-18 01:28:12 +05:30
Paul Hawke
f134d23ecb Merge branch 'master' into dependency-injection 2017-10-21 17:20:56 -05:00
Sergey Kozelko
43af519a16 Fix Codacy issues 2017-10-18 21:57:57 +03:00
poojithakr
fc9cd0a3b7 Fixing codacy issues. Reduced reported count from 550 to 518. 2017-10-04 00:28:11 -07:00
Paul Hawke
c2b21eb575 Merge branch 'master' into dependency-injection 2017-09-29 22:39:25 -05:00
Paul Hawke
9aa021695b @Injected shared preferences where needed 2017-09-27 21:30:41 -05:00
Paul Hawke
7dd3dced35 Fixed merge conflicts 2017-09-26 22:33:59 -05:00
Paul Hawke
e33febf506 Merge branch 'master' into dependency-injection 2017-09-23 14:24:34 -05:00
Paul Hawke
a208c9f273 Further reduced coupling between classes and the need to @Inject the account utils class, fixed imports. 2017-09-10 10:37:58 -05:00
Paul Hawke
9c0cbe7ad5 Further reduce code calling back to the CommonsApplication by pulling out a SessionManager to manage our current account. 2017-09-09 14:08:40 -05:00
Paul Hawke
8cbf56fa7b Java 5 / Java 8 language suggestions plus general cleanup. 2017-09-03 17:27:20 -05:00
Paul Hawke
13e84a82b8 Removed unused imports. 2017-09-03 17:05:37 -05:00
Paul Hawke
d59a526f7f Lint error: use of restricted API 2017-09-03 17:00:16 -05:00
Paul Hawke
d0a85dbd82 Moved single-use code out of Utils over to where it's actually used. 2017-08-26 08:57:16 -05:00
Paul Hawke
388f588301 Correctly configured injection for fragments and services. 2017-08-26 08:57:16 -05:00
Paul Hawke
cfe17cafa6 Moved other singletons over to being managed by Dagger 2017-08-26 08:57:15 -05:00
Paul Hawke
647cc166ef @Inject the MediaWikiApi where needed to reduce coupling between classes. 2017-08-26 08:56:15 -05:00
Paul Hawke
ed1ae98d8e Finished removing coupling between classes around the getInstance() method. 2017-08-26 08:56:15 -05:00
Paul Hawke
8fe2816ca9 First baby steps into the world of dependency injection using Dagger. 2017-08-26 08:56:14 -05:00
neslihanturan
401de30630 Merge pull request #834 from akaita/667_fix_categories
667 fix categories
2017-08-09 11:31:23 +03:00
Mikel
0443f65c4a Reorder to clarify 2017-08-06 20:11:27 +01:00
Mikel
0c0c814604 Refactor CategorizationFragment to use RxJava2 2017-08-06 17:58:31 +01:00
neslihanturan
8ca35c7653 Merge pull request #833 from mebr1416/master
Day mode by default #825
2017-08-05 12:55:01 +03:00
mebr1416
0c303298b2 Resolve for "Day mode by default #825" 2017-08-04 18:40:22 +03:00
neslihanturan
28a0a15616 Merge pull request #818 from akaita/rx_upload_count
Use RxJava2 for getting upload count
2017-08-03 17:10:41 +03:00
Mikel
584a030def Hack to avoid usage of exhausted thread pool 2017-08-02 02:09:57 +01:00
Josephine Lim
4e1d239822 Merge branch 'master' into master 2017-07-30 18:20:42 +10:00
mebr1416
b32320b344 - Information by upload fields
- Fixed conflicts
2017-07-28 16:26:56 +03:00
mebr1416
05bdfb588e Information by upload fields 2017-07-28 12:19:37 +03:00
Mikel
79a22c1aca Add missing annotations 2017-07-26 16:24:24 +01:00
Paul Hawke
bf59afcc3b Merge branch 'master' into categorization-recycler-view 2017-07-25 21:19:21 -05:00
Paul Hawke
4796557fb7 Made a pass through the code to introduce lambdas / method references in the places the Android Studio suggested. 2017-07-22 18:04:40 -05:00
Paul Hawke
9c987efbd2 Swapped the ListView for a RecyclerView, made the fragment cleaner and fixed a whole bunch of code inspection issues. 2017-07-22 13:57:46 -05:00
Yusuke Matsubara
3b728ca568 Coding style fixes 2017-07-16 15:13:40 +09:00