Commit graph

1691 commits

Author SHA1 Message Date
misaochan
953d00d2f6 Fix whitespace 2018-05-25 23:05:29 +10:00
misaochan
5e0e01b035 Make bulk code transfers to FileProcessor and FileUtils 2018-05-25 23:03:46 +10:00
misaochan
68b5e08eb3 Tidy up getFileCoordinates() 2018-05-25 22:55:22 +10:00
misaochan
104cb5f1d7 Change references to upload.FileUtils 2018-05-25 22:50:22 +10:00
misaochan
5207d8f59a Remove unused FileUtils after unifying 2018-05-25 22:49:07 +10:00
misaochan
41673c0067 Unify FileUtils.java, misleading to have 2 of it in different packages 2018-05-25 22:48:47 +10:00
misaochan
c97b708b0f Transfer createCopyPath to FileUtils as a static method 2018-05-25 22:46:50 +10:00
misaochan
3e3956936b Simplify formatting 2018-05-25 20:26:07 +10:00
misaochan
56eed67ac4 Refactor detectUnwantedPictures() 2018-05-25 20:00:54 +10:00
misaochan
d1981494ad Refactor checkIfFileExists() 2018-05-25 19:58:55 +10:00
misaochan
5f140a6453 Remove initViewsAndListeners now that ButterKnife has been used 2018-05-25 19:49:02 +10:00
misaochan
99745db13a Remove comments 2018-05-25 19:45:19 +10:00
misaochan
02a735f2c0 Rearrange member variables 2018-05-25 19:24:58 +10:00
misaochan
e2557f5081 Fix conflicts in ShareActivity.java 2018-05-25 19:22:10 +10:00
misaochan
7cbc2a674c Merge from commons-app/master 2018-05-25 19:17:55 +10:00
Paul Hawke
a66a0e8ca0 Refactoring to extract GpsCategoryModel and ensure single-responsibility-principle is maintained in CategoryApi. 2018-05-25 01:55:03 -05:00
Paul Hawke
c7948c817b Extracted a few networking related items into a new Dagger module and finished the process of mocking the main component for tests. 2018-05-25 01:50:35 -05:00
Paul Hawke
32cb8df9ae Consolidate the networking libraries - drop volley in favor of OkHttp 2018-05-25 01:42:12 -05:00
ShridharGoel
2255bd9a56 Fix for issue #1508 (#1512)
* Made changes to the error message when user enters wrong login credentials.

* Used a single string for the error message when user enters wrong login credentials.
2018-05-24 16:27:13 +03:00
Vivek Maskara
2a0b9d8a0b Enable crosswiki notifications and minor UI fixes in displaying notif… (#1540)
* Enable crosswiki notifications and minor UI fixes in displaying notifications

* Added java docs
2018-05-24 15:54:31 +03:00
Vivek Maskara
41acb76bd8 Show nominate for deletion only for own uploads (#1541) 2018-05-24 15:34:04 +03:00
neslihanturan
32d36944fc
Revert "Wmhack2018 (#1536)" (#1539)
This reverts commit 01cb9ccd70.
2018-05-19 23:02:29 +03:00
Elliott Eggleston
01cb9ccd70 Wmhack2018 (#1536)
* Add new activity to manifest

* Create review activity layout base

* Add a new menu item to drawer for peer review

* Add a top menu with randomizer icon to review activity

* Add strings for review button

* Add activity to ActivityBuilderModule for injection

* Add a new drawer item to start review acitivty

* Create base of the Review Activity

* Add fragment pager

* Add new fragment for injection

* Create a fragment pager layout

* Wikimedia hackathon 2018 (#1533)

* First draft of fn to get random recent image

* Use log entries for requests to beta, try to connect refresh button

FIXME: runs http request on main thread, breaks

* Tweak button connection

* Add ReviewController class

* Fix fragments

* Wmhack2018 (#1534)

* tiny fixes

* Load pictures into activities

* Re-use same class for all review fragments (#1537)

And try to add pager indicator

* [WIP] category check

* [WIP] add on-click actions to ReviewActivity

* [WIP] add SendThankTask

* Make it beautiful

* Use standalone category extraction code in MediaDataExtractor

* Add categories to category review page
2018-05-19 23:00:06 +03:00
Vivek Maskara
0cfcd4e942
Merge pull request #1505 from ashishkumar468/feature/switch_to_butterknife
Feature/switch to butterknife
2018-05-19 10:29:28 +05:30
Vivek Maskara
f99363c06c Fix security exception crash while accessing network location provider (#1498)
* Fix security exception crash while accessing network location provider

* Added java docs
2018-05-18 16:52:11 +05:30
Ashish Kumar
8bdc4f6b95 Bug fix #1504 (#1506)
* Bug fix #1504

* Filtered messages with ConnectException [issue #1504]

* A generalised message for exceptions in Nearby Activity [issue #1504]
2018-05-18 16:52:11 +05:30
Ashish Kumar
cd212b7daa Feature/switch to butterknife (#1494)
* Implemented butterknife in MediaDetailFragment [issue #1491]

* Implemented butterknife in MediaDetailPagerFragment [[issue #1491]]

* post merge upstream master wip [[issue #1491]]
2018-05-18 16:52:11 +05:30
neslihanturan
8eed630ee5 Add nearby tutorial (#1467)
* Add dependency for MaterialShowcase

* Add actionview class to get a reference to material showcase

* Create a NearbyMaterialShowcaseSequence class

* Apply sequence steps

* Add first three steps of nearby showcase

* Add sequence id constants to make sure they will be displayed only once

* Add last step of sequence to explain plus fab

* Create an object to prevent customize all sequences every time

* Fix typo

* Code cleanup

* Add strings to strings.xml

* Code cleanup

* Revert irrelevant change

* Revert irrelevant change

* Remove showcaseview for recenter button

* Use single showcaseView instead of sequence

* Add single showcase view insted of sequence to be able to edit text style

* Make sure it will be displayed only once

* Cleanup

* Update strings

* Change dismiss text style
2018-05-18 16:52:11 +05:30
Tanvi Dadu
aca3f0f832 Open map of place where picture was taken (#1360)
* Intent to map added

*  Merge conflicts resolved

*  Added the functionality to hide FAB incase of null coordinate

*  Merge Conflict resolved

*  Improve pr quality

* Improve Quality

*  Added nested FAB animations

* Nested FAB implemented

*  Improve Quality

*  Added up arrow

*  Javadocs Added
2018-05-18 16:52:11 +05:30
Man Parvesh Singh Randhawa
539c03bf04 resolves #1464 : MediaDataExtractor is making inefficient (redundant) server calls (#1496) 2018-05-18 16:52:11 +05:30
Vivek Maskara
30d7b5d35c Integrate API for displaying featured images (#1456)
* Integrate API for displaying featured images

* Add pagination and refactor code so that it can be reused for category images

* Add license info to the images

* Fix author view

* Remove unused values

* Fix minor issues with featured images

* Fix null license url issue

* Remove some log lines

* Fix back navigation issue

* fix tests

* fix test inits

* Gracefully handling various error situations

* Added java docs
2018-05-18 16:52:11 +05:30
misaochan
ea5f3a6ea9 Add Javadocs 2018-05-15 20:43:21 +10:00
misaochan
b1c3e8a0ac Tidying up code 2018-05-15 20:41:15 +10:00
misaochan
e62022ab55 Tidy up onRequestPermissionsResult() 2018-05-15 20:25:42 +10:00
misaochan
c22d4ce071 Shift helper methods to more logical place 2018-05-15 20:13:59 +10:00
misaochan
478c4900df Tidy initViewsAndListeners() 2018-05-15 20:13:03 +10:00
misaochan
3bd4214246 More FAB tidying 2018-05-15 20:09:22 +10:00
misaochan
11d3517b70 Create initViewsAndListeners() method to tidy onCreate 2018-05-15 20:07:34 +10:00
misaochan
aa73165964 Create new receiveIntent() method to tidy onCreate 2018-05-15 20:03:46 +10:00
misaochan
c0c74f68d2 Clear lint warnings 2018-05-15 19:57:22 +10:00
misaochan
66245d25a5 Remove check for Storage permissions and snackbar in onCreate() 2018-05-15 19:56:47 +10:00
misaochan
cd2a3b345d Merge remote-tracking branch 'refs/remotes/commons-app/upload-overhaul' into upload-overhaul-fork 2018-05-15 19:31:57 +10:00
Vivek Maskara
d891b8f310 Fix security exception crash while accessing network location provider (#1498)
* Fix security exception crash while accessing network location provider

* Added java docs
2018-05-15 17:25:37 +10:00
Ashish Kumar
b6e4fb2d68 Bug fix #1504 (#1506)
* Bug fix #1504

* Filtered messages with ConnectException [issue #1504]

* A generalised message for exceptions in Nearby Activity [issue #1504]
2018-05-12 16:49:43 +05:30
Shridhar Goel
7adf79c07d Used a single string for the error message when user enters wrong login credentials. 2018-05-11 19:34:04 +05:30
Ashish
66b275b19d Implemented butterknife in SimilarImageFragment [issue #1491] 2018-05-10 14:16:08 +05:30
Ashish
8f76dd0b61 Implemented butterknife in ShareActivity [issue #1491] 2018-05-10 13:32:03 +05:30
Ashish
2d1f166ac7 Implemented butterknife in MultipleUploadListFragment [issue #1491] 2018-05-09 17:57:59 +05:30
misaochan
f4cef8da1b Add TODOs 2018-05-09 02:29:52 +10:00
misaochan
cf583c5a77 Add TODOs and Javadocs 2018-05-08 20:21:10 +10:00