Commit graph

475 commits

Author SHA1 Message Date
Sean Nemann
22a5178e04 Updated comments and method headers to clarify that the block status being checked within AuthenticatedActivity refers to the Wikimedia Commons block status of the user 2018-06-11 13:07:54 -04:00
maskara
d1b33933cf Fix build failure 2018-06-05 00:03:56 +05:30
Sean Nemann
fcfae643c3 Updated isUserBlocked method to check the expiration time instead of just if an expiration time exists. Updated tests accordingly 2018-06-04 11:48:07 -04:00
Sean Nemann
01a3a233a9 Added comments to isUserBlocked method and tests for the method 2018-06-04 11:48:05 -04:00
Vivek Maskara
0e86741cc4
Merge branch 'master' into wikidataEdits 2018-05-31 10:02:38 +05:30
Vivek Maskara
4815e93fc9 Make P18 edits to corresponding wikidata entity on uploading from Nearby (#1495)
* Localisation updates from https://translatewiki.net.

* Integrate API for displaying featured images (#1456)

* Integrate API for displaying featured images

* Add pagination and refactor code so that it can be reused for category images

* Add license info to the images

* Fix author view

* Remove unused values

* Fix minor issues with featured images

* Fix null license url issue

* Remove some log lines

* Fix back navigation issue

* fix tests

* fix test inits

* Gracefully handling various error situations

* Added java docs

* Update pull_request_template.md (#1476)

* Update pull_request_template.md

* Remove Javadocs mention

* Added required/optional notes

* resolves #1464 : MediaDataExtractor is making inefficient (redundant) server calls (#1496)

* Open map of place where picture was taken (#1360)

* Intent to map added

*  Merge conflicts resolved

*  Added the functionality to hide FAB incase of null coordinate

*  Merge Conflict resolved

*  Improve pr quality

* Improve Quality

*  Added nested FAB animations

* Nested FAB implemented

*  Improve Quality

*  Added up arrow

*  Javadocs Added

* Add nearby tutorial (#1467)

* Add dependency for MaterialShowcase

* Add actionview class to get a reference to material showcase

* Create a NearbyMaterialShowcaseSequence class

* Apply sequence steps

* Add first three steps of nearby showcase

* Add sequence id constants to make sure they will be displayed only once

* Add last step of sequence to explain plus fab

* Create an object to prevent customize all sequences every time

* Fix typo

* Code cleanup

* Add strings to strings.xml

* Code cleanup

* Revert irrelevant change

* Revert irrelevant change

* Remove showcaseview for recenter button

* Use single showcaseView instead of sequence

* Add single showcase view insted of sequence to be able to edit text style

* Make sure it will be displayed only once

* Cleanup

* Update strings

* Change dismiss text style

* CONTRIBUTING: fix formatting of the gist of the guidelines (#1453)

* CONTRIBUTING: fix formatting of the gist of the guidelines

First level headings for a gist seems to be overkill.

So, replace first level headings with an ordered-list which
sounds more meaningful.

* CONTRIBUTING: specify clearly that 'blame' is a feature of "Git"

The contributing file specifies about the ability to know who wrote
something without the need of @author javadoc tags but incorrectly
attributes the feature to GitHub.

Correctly attribute the feature to where it belongs, Git, and specify
the name of the feature to help users easily take advantage of it.

* Feature/switch to butterknife (#1494)

* Implemented butterknife in MediaDetailFragment [issue #1491]

* Implemented butterknife in MediaDetailPagerFragment [[issue #1491]]

* post merge upstream master wip [[issue #1491]]

* Localisation updates from https://translatewiki.net.

* Bug fix #1504 (#1506)

* Bug fix #1504

* Filtered messages with ConnectException [issue #1504]

* A generalised message for exceptions in Nearby Activity [issue #1504]

* Localisation updates from https://translatewiki.net.

* Fix security exception crash while accessing network location provider (#1498)

* Fix security exception crash while accessing network location provider

* Added java docs

* Localisation updates from https://translatewiki.net.

* Log P18 edits to wikidata corresponding wikidata entity on uploading a nearby image

* Added java docs

* Fix test build

* Refresh nearby

* Refresh nearby list on successful edit

* Java docs

* Make authenticated wikidata edits

* Updated toast message to show entity name that was edited
2018-05-31 11:00:17 +10:00
Paul Hawke
a66a0e8ca0 Refactoring to extract GpsCategoryModel and ensure single-responsibility-principle is maintained in CategoryApi. 2018-05-25 01:55:03 -05:00
Paul Hawke
c7948c817b Extracted a few networking related items into a new Dagger module and finished the process of mocking the main component for tests. 2018-05-25 01:50:35 -05:00
Vivek Maskara
30d7b5d35c Integrate API for displaying featured images (#1456)
* Integrate API for displaying featured images

* Add pagination and refactor code so that it can be reused for category images

* Add license info to the images

* Fix author view

* Remove unused values

* Fix minor issues with featured images

* Fix null license url issue

* Remove some log lines

* Fix back navigation issue

* fix tests

* fix test inits

* Gracefully handling various error situations

* Added java docs
2018-05-18 16:52:11 +05:30
Vivek Maskara
9845a6265d Integrate API for displaying featured images (#1456)
* Integrate API for displaying featured images

* Add pagination and refactor code so that it can be reused for category images

* Add license info to the images

* Fix author view

* Remove unused values

* Fix minor issues with featured images

* Fix null license url issue

* Remove some log lines

* Fix back navigation issue

* fix tests

* fix test inits

* Gracefully handling various error situations

* Added java docs
2018-05-07 11:09:23 +03:00
Paul Hawke
22772c851e Moved tests over to Kotlin. (#1428) 2018-04-08 17:59:20 +10:00
Ujjwal Agrawal
d674e81ed7 Removed nearby Test 2018-03-28 02:39:51 +05:30
maskara
92b2e91e1e Fix compilation for tests 2018-03-22 01:01:08 +05:30
neslihanturan
d7a8989871 Revert "Revert "Fix wrong anotations, but tests are still broken""
This reverts commit f7f4a72540.
2018-03-13 23:58:22 +03:00
neslihanturan
f7f4a72540 Revert "Fix wrong anotations, but tests are still broken"
This reverts commit aa61a0673f.
2018-03-13 23:55:13 +03:00
neslihanturan
aa61a0673f Fix wrong anotations, but tests are still broken 2018-03-09 14:14:41 +03:00
neslihanturan
5b88111289 Fix conflicts 2018-03-06 19:47:18 +03:00
misaochan
353be8cd67 Rename Description to Label to prevent misunderstandings 2018-03-02 23:52:32 +05:30
maskara
238cdefa89 Fix more tests 2018-02-06 01:52:53 +05:30
maskara
fb09ddcab4 Fix tests 2018-02-06 01:52:53 +05:30
maskara
9c23a8c34b Make login work across sessions 2018-02-06 01:52:53 +05:30
Vivek Maskara
f99dd34a78
Merge pull request #1101 from whym/tests
Add assertions to ensure nearby places appear in the list
2018-01-25 21:22:53 +05:30
Yusuke Matsubara
4e1275ffd4 Add assertions to ensure nearby places appear in the list 2018-01-25 20:04:48 +09:00
maskara
d12e234f96 Fix tests 2018-01-22 12:09:56 +05:30
maskara
28a6a3b71d Integrate notifications API 2018-01-22 03:46:54 +05:30
Yusuke Matsubara
7a23d41711 Fix NearbyActivityTest on timing issues 2018-01-21 00:26:21 +09:00
Yusuke Matsubara
9acf22b5b2 Fix TestCommonsApplication compilation errors
Follows up e1afa6081e (#1062)
2018-01-19 22:21:57 +09:00
Yusuke Matsubara
a8bc53d1a7
Merge pull request #1034 from misaochan/fix-description-bug
Fix issue with Nearby item descriptions
2018-01-15 18:29:24 +09:00
Yusuke Matsubara
698fad62ce Fix NearbyAdapterFactoryTest by reflecting PlaceRender's new behavior 2018-01-12 00:09:28 +09:00
Paul Hawke
874627e3f5 Injected the ModifierSequenceDao where needed. 2018-01-05 13:01:20 -06:00
Paul Hawke
9927879680 Injected the ContributionDao where needed. 2018-01-05 08:34:48 -06:00
Paul Hawke
f2ed57a127 Moved Category and CategoryDao to the 'category' package 2018-01-05 08:34:48 -06:00
Paul Hawke
1d3befcbd2 Injected the CategoryDao where needed. 2018-01-05 08:34:48 -06:00
Paul Hawke
08673c91c6 Extracted and tested the database interactions from ModifierSequence 2018-01-04 13:27:55 -06:00
Paul Hawke
1ba8e93346 Extracted and tested the database interactions from Category 2018-01-04 08:33:40 -06:00
misaochan
dd9976cfff Rename Description to Label to prevent misunderstandings 2017-12-31 02:34:36 +10:00
misaochan
548e2a7ab8 Rename Description to Label 2017-12-31 02:21:55 +10:00
Paul Hawke
7c80991049 Extracted and tested the database interactions from Contribution. 2017-12-21 13:56:36 -06:00
Paul Hawke
223df26c55 Fixed failing test 2017-12-08 15:07:42 -06:00
Vivek Maskara
52b52c4895
Merge branch 'master' into dependency-injection 2017-12-04 02:17:16 +05:30
maskara
d6b7af374d Git plugin 2017-12-02 21:25:14 +05:30
Paul Hawke
fb30a34478 Merge branch 'master' into dependency-injection 2017-11-30 21:41:38 -06:00
Paul Hawke
ce32505ca3 Created a Robolectric unit test replacement for the NearbyActivity test. 2017-11-29 21:29:09 -06:00
Paul Hawke
02b5b9b680 Merge branch 'master' into dependency-injection 2017-11-24 22:30:08 -06:00
neslihanturan
955b3f17a4
Merge pull request #942 from maskaravivek/leaks
Fix Leaks in Nearby activity
2017-11-16 10:17:06 +03:00
Yusuke Matsubara
e9b4ec62a1 Convert tests into Kotlin 2017-11-15 09:31:31 +09:00
maskara
6a6ba7d542 Fix Leak canary test 2017-11-13 23:16:27 +05:30
Yusuke Matsubara
e317c369c1 Disable LeakCanary for Robolectric tests
See 'For Robolectric users:' https://github.com/square/leakcanary
2017-11-03 11:30:10 +09:00
Andrew Marshall
c6de66e32a Optimized Imports. 2017-10-11 10:57:22 -04:00
Nicolas Raoul
9b8d8e9b7c Merge pull request #867 from pszklarska/fix_844
Fixing #844 - If a category has exact name entered, show it first
2017-10-02 16:32:46 +09:00