Josephine Lim
4b400cd8aa
Merge pull request #685 from whym/codecov
...
Add Codecov settings
2017-05-28 22:13:30 +10:00
Josephine Lim
e8ba112418
Merge pull request #676 from Deskana/cleanupredundant
...
Remove redundant field in SettingsActivity
2017-05-28 22:13:10 +10:00
Josephine Lim
c83a0e8e59
Merge pull request #682 from dbrant/textwatcher
...
Always remove TextWatchers when finished with them.
2017-05-28 22:12:02 +10:00
Yusuke Matsubara
39617790f5
Merge pull request #680 from Deskana/fromhtml
...
Fix usage of deprecated function String.fromHtml(String)
2017-05-28 19:01:30 +09:00
Deskana
e1a7007f60
Update CREDITS to credit the Android Wikipedia app
...
We reused a code sample from the Android Wikipedia app, and will likely use more. It seems fitting to credit them.
2017-05-28 09:55:08 +01:00
misaochan
f3aa259a7c
Merge remote-tracking branch 'refs/remotes/commons-app/master'
2017-05-28 00:51:05 +10:00
Josephine Lim
7a65790251
Merge pull request #679 from Deskana/simplifyif
...
Simplify if statements in Utils and ExistingFileAsync
2017-05-28 00:33:22 +10:00
Yusuke Matsubara
3b1a902636
Add Codecov settings
2017-05-27 23:19:49 +09:00
Yusuke Matsubara
a6ea218149
Merge pull request #644 from ftsalamp/master
...
Updated target sdk version to 25
2017-05-27 19:45:34 +09:00
Josephine Lim
93cf3fbdec
Merge pull request #684 from misaochan/master
...
Versioning and changelog for v2.4.1
2017-05-27 17:44:06 +10:00
misaochan
9557ed6099
Versioning for release 2.4.1
2017-05-27 17:34:19 +10:00
Josephine Lim
2b8abe3f23
Update changelog.md
2017-05-27 17:33:14 +10:00
misaochan
3274c4cc4a
Merge remote-tracking branch 'refs/remotes/commons-app/master'
2017-05-27 17:28:25 +10:00
Josephine Lim
a656b798d8
Merge pull request #678 from Deskana/stringformat
...
Remove redundant call to String.format() in CategoryModifier
2017-05-27 16:39:34 +10:00
misaochan
2bfe1e6b6f
Merge branch 'master' of https://github.com/misaochan/apps-android-commons
2017-05-27 16:35:49 +10:00
misaochan
3dbbc428da
Merge remote-tracking branch 'refs/remotes/commons-app/master'
2017-05-27 16:35:39 +10:00
Josephine Lim
fade9589bb
Merge pull request #683 from dbrant/context1
...
Don't pass/store Activity instance in key places.
2017-05-27 16:34:27 +10:00
Josephine Lim
0112a09a70
Merge pull request #673 from tobias47n9e/bugfix/nearby-crash
...
Fix crash of nearby list when the places list is null
2017-05-27 16:34:06 +10:00
Dmitry Brant
5ab060567a
Fix vector placeholder images in API <21.
2017-05-26 17:37:18 -04:00
Dmitry Brant
040789ca2e
Use callback pattern in Welcome activity/adapter.
2017-05-26 17:06:03 -04:00
Tobias Schönberg
bc61f8d2ec
Code style
2017-05-26 23:00:54 +02:00
Tobias Schönberg
5574fa8b7c
Android studio import ordering
2017-05-26 22:45:12 +02:00
Dmitry Brant
8656098dc5
Fix lint issues.
2017-05-26 16:41:38 -04:00
Dmitry Brant
de1a3144cc
Don't pass Activity into WelcomePagerAdapter.
2017-05-26 16:38:34 -04:00
Dmitry Brant
dea43c04b9
Make sure to remove backstackChangeListener when finished.
2017-05-26 16:32:00 -04:00
Dmitry Brant
bb5a6691f1
Don't pass Activity into MwVolleyApi.
2017-05-26 16:20:55 -04:00
Dmitry Brant
b07432fce2
Don't pass Activity into GPSExtractor.
2017-05-26 16:18:27 -04:00
Dmitry Brant
94e0e5e254
Always remove TextWatcher when finished with it.
2017-05-26 16:06:14 -04:00
Dmitry Brant
1809475fea
Don't require Activity to be passed into UploadController.
2017-05-26 15:34:10 -04:00
Dmitry Brant
8255bac32e
Don't store Activity instance in adapter.
2017-05-26 15:15:43 -04:00
Dinu Kumarasiri
40c1ea375a
Merge pull request #681 from dbrant/crash2
...
Fix crash when uploading multiple photos.
2017-05-26 23:35:37 +05:30
Dmitry Brant
5923e9ad4a
Fix crash in PhotoDisplayAdapter.
2017-05-26 13:35:40 -04:00
Josephine Lim
be62646fbe
Merge pull request #677 from Deskana/unusedimports
...
Remove unused imports
2017-05-27 02:10:12 +10:00
Josephine Lim
39ddcd1577
Merge pull request #675 from tobias47n9e/feature/nearby-view
...
Vertically center nearby list loading icon
2017-05-27 02:07:31 +10:00
Deskana
14326ae3d0
Fix usage of deprecated function String.fromHtml(String)
...
String.fromHtml(String) is now deprecated. This patch fixes that by adding a method to Utils that selects the appropriate function based on the user's platform.
2017-05-26 13:52:01 +01:00
Deskana
7a8e04eec1
Simplify if statements
...
This patch simplifies a few if statements by replacing them with returns, which helps improve code readability and simplicity.
2017-05-26 11:16:22 +01:00
Deskana
4b7011a725
Remove redundant call to String.format() in CategoryModifier
...
This patch removes a call to String.format that can be replaced with a
literal string which is much clearer.
2017-05-26 11:08:02 +01:00
Deskana
767878f194
Remove unused imports
...
This patch removes imports across the codebase that are unused to improve
code maintainability and cleanliness.
2017-05-26 11:02:56 +01:00
Deskana
9b26465b1d
Remove redundant field in SettingsActivity
...
There is a field that is set in SettingsActivity that is never used at all.
This patch removes that field to improve performance and code tidiness.
2017-05-26 10:55:53 +01:00
Tobias Schönberg
d545c9b0ef
Vertically center nearby list loading icon
...
The loading icon of the nearby places list is currently
at the very top of the view.
This commit vertically centers the loading icon.
2017-05-25 17:47:18 +02:00
Tobias Schönberg
db5dbbfdfd
Fix crash of nearby list when the places list is null
...
Currently the NearbyController crashes when it is called with a
places list that is null. This is caused by the NearbyMapFragment
not handling this state correctly.
This commit adds tests for an empty list and null, which reproduce
the problem. An early return in the NearbyController can make
the tests pass, but might not be the best solution for this issue.
2017-05-24 22:15:38 +02:00
Vivek Maskara
67dfa170d2
Merge pull request #666 from whym/tests
...
Espresso: match with resource names in settings screen
2017-05-24 19:31:23 +05:30
Yusuke Matsubara
28d73d2b96
Espresso: match with resource names in settings screen
...
Apparently this is more robust (especially for SDK version 25)
2017-05-21 21:38:35 +09:00
Josephine Lim
aeb66492d6
Merge pull request #664 from sandarumk/replace_upload_with_home
...
Replace upload with home
2017-05-21 12:33:04 +02:00
Josephine Lim
35bead1302
Merge pull request #663 from maskaravivek/guava
...
Adding support for Guava library
2017-05-21 12:31:29 +02:00
Dinu Kumarasiri
471403d7c3
Replace upload with home
2017-05-21 12:30:54 +02:00
maskara
43d841bdf3
Adding support for Guava library
2017-05-21 12:25:28 +02:00
Josephine Lim
e89369afc0
Merge remote-tracking branch 'refs/remotes/commons-app/master'
2017-05-21 11:49:26 +02:00
translatewiki.net
1d2ba94c56
Localisation updates from https://translatewiki.net .
2017-05-21 09:52:06 +02:00
Nicolas Raoul
1e7f7974e3
Merge pull request #660 from domdomegg/bulktranslationfixes
...
Bulk translation fixes
2017-05-21 10:59:24 +09:00
