846 commits

Author	SHA1	Message	Date
Paul Hawke	b305acd395	View injection with Butterknife	2017-09-27 21:53:00 -05:00
Paul Hawke	9aa021695b	@Injected shared preferences where needed	2017-09-27 21:30:41 -05:00
Paul Hawke	1b840502a9	Small code cleanup	2017-09-27 20:48:42 -05:00
Paul Hawke	e33febf506	Merge branch 'master' into dependency-injection	2017-09-23 14:24:34 -05:00
Paul Hawke	c3d6d0eb44	Merge branch 'master' into lint-cleanup	2017-09-23 13:27:07 -05:00
Paul Hawke	f06fcf651f	Merge pull request #878 from neslihanturan/bugFix-877 ... Closes #877	2017-09-22 22:58:03 -05:00
Vishan Seru	3b5811921c	Moved sign up process redirection urls to build.gradle as buildConfig fields specific to beta and prod flavors and added necessary usages to SignupActivity	2017-09-16 20:12:57 +05:30
Paul Hawke	2d91e81121	Merge branch 'master' into dependency-injection	2017-09-13 20:29:50 -05:00
Paul Hawke	d4fd6f8b77	Merge branch 'master' into lint-cleanup	2017-09-13 19:16:55 -05:00
neslihanturan	ffc7c80678	Merge pull request #857 from psh/beta-cluster ... Product flavors for production and the beta-cluster Wikimedia servers	2017-09-13 10:57:31 +03:00
Neslihan	4d9e63227c	Fix codacy issue	2017-09-12 23:14:58 +03:00
Neslihan	c52c0b4a7f	Fix coding style	2017-09-12 22:47:57 +03:00
Neslihan	1c50e8539b	Request write permission for older android versions, too.	2017-09-12 22:47:31 +03:00
Paul Hawke	a208c9f273	Further reduced coupling between classes and the need to @Inject the account utils class, fixed imports.	2017-09-10 10:37:58 -05:00
Paul Hawke	9c0cbe7ad5	Further reduce code calling back to the CommonsApplication by pulling out a SessionManager to manage our current account.	2017-09-09 14:08:40 -05:00
Paul Hawke	e7d0c647c2	Merge branch 'master' into dependency-injection	2017-09-09 12:39:41 -05:00
Paul Hawke	15107e622b	Codacy suggestions for improvement.	2017-09-03 22:20:52 -05:00
Paul Hawke	8cbf56fa7b	Java 5 / Java 8 language suggestions plus general cleanup.	2017-09-03 17:27:20 -05:00
Paul Hawke	13e84a82b8	Removed unused imports.	2017-09-03 17:05:37 -05:00
Paul Hawke	d59a526f7f	Lint error: use of restricted API	2017-09-03 17:00:16 -05:00
Paul Hawke	f74de55b60	Lint warning: Lambda can be replaced with method reference.	2017-09-03 16:52:52 -05:00
Paul Hawke	a615e0784e	Cleanup the logout positive button lambda.	2017-09-03 16:45:19 -05:00
Yusuke Matsubara	7c956e803c	Merge pull request #856 from Bluesir9/issue_848_logout_contributions_redirect_issue ... Added callback when removing accounts on logout	2017-09-03 20:34:31 +09:00
Vishan Seru	35fdb4350a	Fixed small bug when incrementing counter in AccountManagerCallback	2017-08-28 12:44:19 +05:30
Vishan Seru	b094d502d6	Took care of some issues pointed out by codacy in relation to the coding guidelines followed specifically to the changes made in this branch	2017-08-28 12:27:03 +05:30
Paul Hawke	ca4b99a1cc	Product flavors to allow switching between the production and the beta-cluster Wikimedia servers.	2017-08-26 15:42:44 -05:00
Paul Hawke	d0a85dbd82	Moved single-use code out of Utils over to where it's actually used.	2017-08-26 08:57:16 -05:00
Paul Hawke	388f588301	Correctly configured injection for fragments and services.	2017-08-26 08:57:16 -05:00
Paul Hawke	cfe17cafa6	Moved other singletons over to being managed by Dagger	2017-08-26 08:57:15 -05:00
Paul Hawke	647cc166ef	@Inject the MediaWikiApi where needed to reduce coupling between classes.	2017-08-26 08:56:15 -05:00
Paul Hawke	ed1ae98d8e	Finished removing coupling between classes around the getInstance() method.	2017-08-26 08:56:15 -05:00
Paul Hawke	dbcbeed822	Android injection for support classes.	2017-08-26 08:56:15 -05:00
Paul Hawke	7880a08c30	Ensure that activities and content providers are integrated into DI.	2017-08-26 08:56:15 -05:00
Paul Hawke	8fe2816ca9	First baby steps into the world of dependency injection using Dagger.	2017-08-26 08:56:14 -05:00
Vishan Seru	16487556dc	Added callback when removing accounts on logout to ensure that post logout screen transition happens only after complete logout procedure is complete.	2017-08-25 11:42:17 +05:30
Paul Hawke	97bbd51e13	Removed the popup and nav-drawer item relating to developer plans.	2017-08-24 22:19:43 -05:00
Mikel	5cb1f7281b	Fix wrong condition	2017-08-18 20:06:18 +01:00
Mikel	591b10f4c9	Add error message to exception	2017-08-18 20:04:59 +01:00
Mikel	f2e8891db9	Simplify AddAccount task	2017-08-18 17:35:24 +01:00
Mikel	6b80bec3c9	Simplify GetAuthCookie task	2017-08-18 17:34:55 +01:00
Josephine Lim	5796d14e9e	Merge pull request #839 from YDrall/backstack_issue ... remove signup activity from activity's backstack.	2017-08-14 01:28:54 +10:00
ydrall	68462eac2b	make SignupActivity to terminate on task completion	2017-08-11 15:02:15 +05:30
neslihanturan	0005b82421	Revert "Adding username to Drawer"	2017-08-10 13:56:51 +03:00
neslihanturan	401de30630	Merge pull request #834 from akaita/667_fix_categories ... 667 fix categories	2017-08-09 11:31:23 +03:00
neslihanturan	9ea805f9f5	Merge pull request #826 from Nethermane/master ... Adding username to Drawer	2017-08-09 10:43:45 +03:00
Bruce Nishimura	1622f67a4b	Made layout actually look good. Hopefully fixed codeacities complaints.	2017-08-08 18:58:45 -04:00
neslihanturan	e3455b630e	Merge pull request #796 from akaita/media_detail_enhance ... Enhance behaviour of Media detail enhance	2017-08-08 15:29:33 +03:00
Mikel	bef42de613	Remove unused imports	2017-08-08 13:08:56 +01:00
Mikel	304e998a0b	Line break to add readability	2017-08-07 20:53:00 +01:00
Mikel	7754c7c7c4	Fix vectors for drawableStart in API 17	2017-08-07 20:44:35 +01:00