Commit graph

3071 commits

Author SHA1 Message Date
neslihanturan
ab7f352bd2 Make search this area button appear at correct time 2019-06-03 15:19:08 +03:00
neslihanturan
5a8c137c87 include clear map into add markers method and reorder methods 2019-06-03 11:42:23 +03:00
neslihanturan
c2453cb889 Add current location marker with object animator and remove previous marker is exists 2019-06-03 11:38:38 +03:00
neslihanturan
008e1f6324 Remove unused methods 2019-06-01 14:54:19 +03:00
neslihanturan
a7d35ed02d Add current location marker and remove circle around it 2019-06-01 14:39:56 +03:00
neslihanturan
05fba7da03 Fix conflicts 2019-05-31 13:35:52 +03:00
neslihanturan
1b0d614886 Rename methods accordingly and add Javadocs 2019-05-31 13:16:40 +03:00
neslihanturan
3f847fd890 Make sure everything is called in required order and seach this area method basically works 2019-05-31 13:12:24 +03:00
neslihanturan
4ff63a262a Merge branch 'master' into refactorNearbyClassesMVP 2019-05-29 00:38:10 +03:00
neslihanturan
e8ae344215 Mostly implement search this area methods, not tested yet even once 2019-05-29 00:37:15 +03:00
neslihanturan
9a50f54b4a Search this area button action is added 2019-05-28 23:41:15 +03:00
neslihanturan
69597b34d5 Refactor a variable name to camel case and bind search this area view 2019-05-28 19:50:56 +03:00
translatewiki.net
12883e3d0b Localisation updates from https://translatewiki.net. 2019-05-27 16:34:33 +02:00
neslihanturan
f57d2cd264 Style ,issues 2019-05-27 14:03:10 +03:00
neslihanturan
ceab7f4c1b Remove location listener implementation from view, handle them in presenter instead. And add timber debug notes and required method calls 2019-05-27 13:37:47 +03:00
neslihanturan
97ab63e19a add some commits and clear code 2019-05-27 13:17:57 +03:00
neslihanturan
5b69daa5d6 Revert "remove unneeded codes copied from previous implementation"
This reverts commit 42539651de.
2019-05-27 11:21:14 +03:00
neslihanturan
42539651de remove unneeded codes copied from previous implementation 2019-05-27 11:18:18 +03:00
neslihanturan
4ec1346ec4 Fix conflicts with master 2019-05-27 10:53:06 +03:00
neslihanturan
d4cee8b253 Implement add nearby markers and add current marker methods 2019-05-24 20:14:30 +03:00
Dan Garry
b4b178cedb Remove variable that was set but never used in SimilarImageDialogFragment (#2957)
There was a variable that was being set in SimilarImageDialogFragment that was never subsequently used; this patch removes it, and all of the imports that become redundant.
2019-05-24 12:58:42 +03:00
Dan Garry
5f3510226a Refactor onRequestPermissionsResult to be simpler (#2965)
onRequestPermissionsResult has a switch statement with a single case, and a functionally empty default; this patch refactors it into an if statement to simplify the code. This patch also changes a C-style array declaration (String permissions[]) to the more standard Java style (String[] permissions).
2019-05-24 12:56:55 +03:00
neslihanturan
a96bbb18a5 Find out zoom level problem 2019-05-23 15:40:07 +03:00
translatewiki.net
ab783a445f Localisation updates from https://translatewiki.net. 2019-05-23 14:10:29 +02:00
neslihanturan
786212fc49 Call update map and add required markers 2019-05-23 14:16:49 +03:00
Vitaly V. Pinchuk
d782d3eacc Trim accidentally added space at the end of filename (#2967)
* Fixes #2917: App adds space at end of filename sometimes

* Fix #2917: Trims accidental space at the end of the filename
2019-05-23 14:15:32 +03:00
neslihanturan
b10804910c Rename a method with prepoer name 2019-05-23 11:17:17 +03:00
neslihanturan
7080c3a943 Make sure updateMAoAndList method is called when everything ready 2019-05-22 21:30:23 +03:00
neslihanturan
771a9ecda3 Makes sure that initialize nearby operations method is called just after all views and fragments are ready and attached 2019-05-21 17:20:11 +03:00
neslihanturan
f4321d0541 Prevent crash caused child fragment is actually null by checking if it is attached or not. 2019-05-21 14:30:42 +03:00
neslihanturan
d0556419f7 Change the old NearbyFragment by our new NearbyParentFragment for first tests 2019-05-21 14:15:02 +03:00
neslihanturan
a77c3c45d4 Add comments 2019-05-21 13:55:52 +03:00
neslihanturan
fd515deeb2 AddnetworkBroadcatsReceiver on view side, call it from presenter 2019-05-21 13:36:38 +03:00
neslihanturan
cdd62290ac Change nearby design, first create views then register listeners 2019-05-20 18:57:23 +03:00
neslihanturan
297eb67dae Connect child fragment and prent fragment with presenter 2019-05-20 17:31:18 +03:00
neslihanturan
95dd97aca0 Add missing methods for NearbyMap 2019-05-20 17:21:59 +03:00
translatewiki.net
4896e5992e Localisation updates from https://translatewiki.net. 2019-05-20 13:41:58 +02:00
neslihanturan
4bb83f77cb Merge branch 'master' into refactorNearbyClassesMVP 2019-05-20 13:45:57 +03:00
Dan Garry
200f038f2c Remove unnecessary use of String.valueOf() from GPSExtractor (#2958)
valueOf() was being used in cases where it wasn't necessary because the method is called implicitly; this patch removes these usages to make the code clearer and easier to read.
2019-05-19 14:32:08 +02:00
Dan Garry
b176515153 Remove unnecessary Integer.toString() calls (#2959)
In cases where an integer is directly concatenated onto a string, toString() is not needed because it is called implicitly; this patch removes the calls to improve code readability.
2019-05-19 14:24:53 +02:00
neslihanturan
bcd7e648b6 try to simplify previous method during refactor 2019-05-18 12:26:20 +03:00
neslihanturan
034a2e2f08 Add network connection established check on view side, check it from presenter 2019-05-17 18:50:19 +03:00
neslihanturan
f8e8d13b78 Add lock neabry method to unlisten nearby operations during updates 2019-05-17 18:38:22 +03:00
Dan Garry
877c669297 Remove redundant empty if/else statement in NotificationActivity (#2953)
* Remove redundant empty if/else statement

This patch removes an empty if/else statement that has no effect on the execution flow of the program.

* Remove redundant empty if/else statement in MainActivity

This patch removes an empty if/else statement that has no effect on the execution flow of the program, which makes the code simpler.
2019-05-17 17:35:14 +03:00
translatewiki.net
45fd7fe5fa Localisation updates from https://translatewiki.net. 2019-05-17 12:13:00 +02:00
neslihanturan
a8190bb8b1 Define a presenter variable in fragment and call updateMapAndList method from there, if permissions are okay 2019-05-16 16:51:50 +03:00
neslihanturan
1c27c3cbe3 Define refreshView method as updateMapAndList which is a better naming. Define it at presenter part. 2019-05-16 16:42:53 +03:00
neslihanturan
80708023aa Add all location permission related methods to view contract and implement in fragment. Call them from presenter by passing locationServiceManager parameter 2019-05-16 16:26:44 +03:00
neslihanturan
f8926aa2f1 Merge branch 'master' into refactorNearbyClassesMVP 2019-05-15 13:23:24 +03:00
Dmitry Brant
6fd969686c Remove additional unnecessary dependencies. (#2948) 2019-05-15 09:46:42 +03:00