Commit graph

2738 commits

Author SHA1 Message Date
Ashish Kumar
b9274c0335 Fix memory leak in CategoryDetailsActivity (#1792) 2018-12-20 14:18:30 +02:00
Josephine Lim
33995764ff
Merge pull request #2085 from neslihanturan/fixOrientationIssueOnSearchNearby
Fix orientation issue on nearby after "search this area" is implemented
2018-12-20 20:59:49 +10:00
neslihanturan
784ee8b506 Fix #1828: Add missing Javadocs and tidy up code in nearby package (#2133)
* Add Javadocs
* Remove unused variables, methods, fragments, imports, classes
2018-12-19 18:49:08 +00:00
neslihanturan
5a584545a0 Fixes #2014 After re-logging, notifications bell icon is empty (#2173)
* Fix white background on notification bell icon issue

* Fix icon size to 36
2018-12-19 18:18:38 +00:00
Vivek Maskara
f3b450e020 Merge 2.9 release with master (#2174)
* Fix memory leak due to wikidata edit listener (#2048)

* Fix bookmark crash fix (#2047)

* Fix bookmark crash fix

* Fix check for bookmark creator

* Bug fix #2042 (#2056)

* Bug fix #2042
* Added a snack with retry when api in AA fails
* Increased connection timeouts in okhttpclient builder

* added missing string resource

* Bugfix/duplicate categories (#2080)

* Increased timeout to 60 seconds

* Bug fix #1550
* filter duplicate categories

* Fix crash because of inactive fragment UI (#2046)

* Fix crash because of inactive fragment UI

* Add java docs

* Add information icon action Fiixes #2055 2.9.0: the 'i' icon in nearby doesn't do anything (#2057)

* Localisation updates from https://translatewiki.net.

* Remove unused mediawiki api dependency (#1991)

* Categories with pipe suffix (#1873)

* Bug fix issue #1826
Changes made :
-Certain category names used to show suffixed with strings prefixed with pipe '|'. Removed everything after the pipe. As per the discussion on the thread, its safe to remove everything after the pipe, including the pipe

* review suggested changes
*Code formatting
*Extracted out the index of pipe in a variable
*Added issue link in comments

* Remove libraries section from README (#1988)

* Remove libraries section from README

* Add wiki link to "libraries used" to README

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Use alert dialog instead of popup window, for nearby information

* Revert irrelevant changes, sorry
2018-12-19 18:59:49 +02:00
Josephine Lim
21edcb7cbe
Retry failed uploads - #1556 Allow users to easily re-upload failed uploads... (#2112)
* Add cancel and retry buttons on layout contribution

* Make sure your retry logic works

* Add cancel method too

* Add javadocs and remove debug logs

* Remove two unused methods

* Remove old and unused retry buttons as we do for their functions

* Check internet connection before button function, since function requires internet connection

* Remove unused variable

* Display possible solution for badtoken error

* Fix string
2018-12-20 02:56:00 +10:00
Ashish Kumar
4425c36713 Bug fix in campaigns (#2119)
* Bug fix in campaigns

* remove hardcoded reference to camapign at index 0
2018-12-19 22:06:51 +10:00
Adam Jones
46db38b8e9 Fix #2153: Fix explore category lists (#2155) 2018-12-19 01:37:24 +05:30
Adam Jones
0f69deab84 Fix #2147: Remove strings from notification and place layouts (#2150) 2018-12-19 01:33:48 +05:30
Zhao Gang
db38174eb4 Fix #2156: Add plural support for share_license_summary string (#2161) 2018-12-18 17:29:11 +00:00
sp2710
1d80cbaac9 fixing issue#2131: same description for all photos in multiple uploads (#2132)
* fixing same description in multiple uploads issue(#2131)

* Remove setNewDescription method
2018-12-18 21:14:30 +05:30
Adam Jones
525eb9ab50 Remove unused readmoretextview dependency (#2160) 2018-12-18 14:36:17 +02:00
HectorRoblesWolf
790bb3c19e Issue #1981 fixed (#1998)
* notification: replaced ReadMoreTextView by TextView

* removed com.borjabravo:readmoretextview:2.1.0 package

* Update build.gradle

Re-add implementation 'com.borjabravo:readmoretextview:2.1.0' to prevent travis fail
2018-12-18 13:59:33 +02:00
konohakesh
2d6160c843 Merge PR-1983 with master (#1983) 2018-12-18 11:42:24 +00:00
Adam Jones
fb3055e716 Add FileUtils tests for SHA1 and deletion (#2152)
* Add FileUtils tests for SHA1 and deletion

* Avoid changing access modifier for SHA1 test
2018-12-17 21:15:00 +05:30
Adam Jones
647c679c18 Add mapzen lost to build.gradle (#2148)
Reduces the number of javac warnings, and pushes us a step closer to it working with Instant Run.
2018-12-17 15:59:05 +02:00
Adam Jones
1213678040 Use fitCenter instead of centerCrop where sensible (#2149) 2018-12-17 15:53:47 +02:00
Divyanshu Shukla
83b52fc1b9 Fixed #1948 Search feature is light in dark theme (#1951)
* Fixed #1930 Achievements activity is crashing on Android 8.1

* Fixed #1930 Achievements activity is crashing on Android 8.1

* Delete gradle-wrapper.properties

* Update build.gradle

* Create gradle-wrapper.properties

* fixed #1948 Search feature is light in dark theme

* Update FileUtils.java

* Update FileUtils.java

* Update FileUtils.java

* Fixed #1948 Search feature is light in dark theme

* changed files for the build

* Made the changes asked for

* Made the changes asked for

* Update gradle.properties

* Update gradle.properties

* Made changes in RecentSearchFragment
2018-12-17 13:43:58 +02:00
Mojtaba Rahimy
f79456ec8e "Skip Tutorial" button moved to parent view so that it does not animate by swipes. (#1945)
* Update WelcomeActivity.java

Now it starts welcome screen after not finishing the pager. Moved "Skip Tutorial" button here so it does not animate by swipe.

* Update activity_welcome.xml

Putting  "Skip Tutorial" button here so that it does not animate by swipes.

* Update LoginActivity.java

Removing the set of "first run " flag from here. we set it after the buttons press or on WelcomeActivity's finish()

* Update welcome_do_upload.xml

removing "skip tut" button from here.

* Update welcome_dont_upload.xml

Removing  "Skip Tutorial" button from here so that it does not animate by swipes.

* Update welcome_image_details.xml

Removing  "Skip Tutorial" button from here so that it does not animate by swipes.

* Update welcome_wikipedia.xml

Removing  "Skip Tutorial" button from here so that it does not animate by swipes.

* Update WelcomePagerAdapter.java

the "welcomyesButton" is removed from the child views in pager, so it is optional now.

* Add JavaDoc to WelcomeActivity.onBackPressed()

* Fix #2103: Remove welcomeYesButton from landscape layout

* Refactor WelcomePagerAdapter
2018-12-17 13:20:13 +02:00
sp2710
11e5c3c01a Defined SearchActivity tab names into strings.xml file(#2136) (#2137)
* Defined SearchActivity tab names into strings.xml file(#2136)
2018-12-17 11:08:04 +00:00
neslihanturan
f497217568 Fix #2144: Typo in a string name in ImageUtil class (#2143)
* Fix typo in a string name in ImageUtil class
2018-12-17 10:26:57 +00:00
Adam Jones
f66d02cd85 Fix #2123: Remove unnecessary calls to getParentFragment() to avoid NPE (#2138) 2018-12-17 11:20:04 +02:00
translatewiki.net
174e58c49f Localisation updates from https://translatewiki.net. 2018-12-17 08:49:29 +01:00
Shrey
78ca1fe64e Update app icon (Fixes #868) (#2022)
* Add new logo

* Revert changes affected by merge

* Add adaptive icon for beta version
2018-12-17 11:13:46 +05:30
Adam Jones
8f0a619a6d Remove utils.FileUtils (#2118) 2018-12-17 11:09:04 +05:30
Adam Jones
378a298e32 Update build.gradle (#1992)
Reorder and group libraries
2018-12-17 11:07:46 +05:30
sp2710
102b2d7e56 Fix #2134: Remove formatting characters from upload_problem strings (#2135) 2018-12-17 00:40:24 +00:00
Szymon20000
e09ce41df3 Fix SearchActivity crash on orientation change on lower API levels (#2129) 2018-12-16 18:18:42 +00:00
maskara
932c75a0a3 Fix gradle play plugin 2018-12-16 21:35:29 +05:30
Vivek Maskara
f897af028a
Fix upload tests (#2130) 2018-12-16 21:04:49 +05:30
Vivek Maskara
8c083f3dd5 Changes to fix build (#2128)
* Changes to fix build

* Apply GPP plugin only on travis
2018-12-17 00:29:33 +10:00
neslihanturan
47f10cb6c8 Fix string 2018-12-16 15:47:36 +03:00
neslihanturan
718ad3a12c Fixes #945 Check image coordinates for direct Nearby uploads in locations that the user is not currently in (#2099)
* Add getGeolocation method to geolocation from file path

* Add geolocation check to receiveDirect method checks, means it will be checked durimg nearby direct uploads

* Create method body for geolocation and nearby place coordinate comparaison, this method will be filled on consequent commits

* Add a method to find location missmatch

* app/src/main/java/fr/free/nrw/commons/utils/ImageUtils.java

* Add if check to upload activity to detect pictures with wrong location, and save it to shared prefs

* Do not edit wikidata item if picture has wrong location info

* Add one more bitwise operand to possible warning reasons for wrong location case

* Add a bitwise variable for wrong locatio case

* Share nearby place location just like wikidataEntityId, so that we can compare

* Implement check image geolocation is different method by comparing nearby location and file EXIF geolocation

* Add Javadocs

* Remove logs

* Fix all taken on wrong phrases as taken at

* Fix typo on logs

* Simplify if logic

* Fix string issues
2018-12-16 22:26:44 +10:00
Ashish Kumar
6754ce121c
Merge pull request #2110 from ShridharGoel/issue2107
Fix #2107 by changing notification text colour to white in night mode
2018-12-15 13:55:13 +05:30
Vivek Maskara
5b745075e2
Minor changes to fix plugin (#2121) 2018-12-15 01:16:00 +05:30
Vivek Maskara
c40c5ed728
Update p12File key (#2120) 2018-12-15 00:08:32 +05:30
Vivek Maskara
867e447a17
Integrate gradle play publisher for automatic alpha releases (#2116) 2018-12-14 23:53:05 +05:30
Ashish Kumar
1b01c6517f Show campaigns (#2113)
* Show campaigns
* Added a ui util class SwipableCardView which passes the onSwipe event to its children
* NearbyCardView & CampaignView extend SwipableCardView
* Fetch campaigns in ContributionsFragment
* Added an option to enable disable campaign in Settings/Preferences

* synced strings with master

* removed duplicate initialsation of CampaignPresenter
2018-12-15 02:55:53 +10:00
Josephine Lim
707c52c768 Automate releases (part 1) (#2111)
* Encrypt keystore

* Modify build.gradle to add signing configs for env vars

* Fixed keystore name

* Remove encrypted file that is causing build errors

* Add encrypted keystore again

* Remove failed keystore again...

* Add keystore encrypted by Nicolas

* Modify env var names for key and iv
2018-12-14 21:07:03 +05:30
neslihanturan
ce4a0c1194 Display possible solution for badtoken error 2018-12-14 18:03:26 +03:00
albendz
1d951f5f8a Init ACRA when starting commons application (#2091)
* Init ACRA when starting commons application
* Remove redundant ACRA initialization function
2018-12-14 14:34:37 +00:00
neslihanturan
5b25229a5c Remove unused variable 2018-12-14 17:18:41 +03:00
Adam Jones
aa4ab37adb Move utils tests to utils package (#2109) 2018-12-14 10:54:46 +05:30
neslihanturan
2569bb45f7 Check internet connection before button function, since function requires internet connection 2018-12-13 20:22:20 +03:00
neslihanturan
f3818c6e23 Remove old and unused retry buttons as we do for their functions 2018-12-13 18:07:50 +03:00
neslihanturan
915a888843 Remove two unused methods 2018-12-13 18:06:03 +03:00
neslihanturan
59b8a4a70a Add javadocs and remove debug logs 2018-12-13 18:04:02 +03:00
Shridhar
0e3ca3e41f Fix #2107 by changing notification text colour to white in night mode 2018-12-13 20:26:22 +05:30
neslihanturan
e4c05d2fb3 Add cancel method too 2018-12-13 17:35:36 +03:00
neslihanturan
bfd30e9435 Make sure your retry logic works 2018-12-13 17:27:58 +03:00