Commit graph

57 commits

Author SHA1 Message Date
Vivek Maskara
4815e93fc9 Make P18 edits to corresponding wikidata entity on uploading from Nearby (#1495)
* Localisation updates from https://translatewiki.net.

* Integrate API for displaying featured images (#1456)

* Integrate API for displaying featured images

* Add pagination and refactor code so that it can be reused for category images

* Add license info to the images

* Fix author view

* Remove unused values

* Fix minor issues with featured images

* Fix null license url issue

* Remove some log lines

* Fix back navigation issue

* fix tests

* fix test inits

* Gracefully handling various error situations

* Added java docs

* Update pull_request_template.md (#1476)

* Update pull_request_template.md

* Remove Javadocs mention

* Added required/optional notes

* resolves #1464 : MediaDataExtractor is making inefficient (redundant) server calls (#1496)

* Open map of place where picture was taken (#1360)

* Intent to map added

*  Merge conflicts resolved

*  Added the functionality to hide FAB incase of null coordinate

*  Merge Conflict resolved

*  Improve pr quality

* Improve Quality

*  Added nested FAB animations

* Nested FAB implemented

*  Improve Quality

*  Added up arrow

*  Javadocs Added

* Add nearby tutorial (#1467)

* Add dependency for MaterialShowcase

* Add actionview class to get a reference to material showcase

* Create a NearbyMaterialShowcaseSequence class

* Apply sequence steps

* Add first three steps of nearby showcase

* Add sequence id constants to make sure they will be displayed only once

* Add last step of sequence to explain plus fab

* Create an object to prevent customize all sequences every time

* Fix typo

* Code cleanup

* Add strings to strings.xml

* Code cleanup

* Revert irrelevant change

* Revert irrelevant change

* Remove showcaseview for recenter button

* Use single showcaseView instead of sequence

* Add single showcase view insted of sequence to be able to edit text style

* Make sure it will be displayed only once

* Cleanup

* Update strings

* Change dismiss text style

* CONTRIBUTING: fix formatting of the gist of the guidelines (#1453)

* CONTRIBUTING: fix formatting of the gist of the guidelines

First level headings for a gist seems to be overkill.

So, replace first level headings with an ordered-list which
sounds more meaningful.

* CONTRIBUTING: specify clearly that 'blame' is a feature of "Git"

The contributing file specifies about the ability to know who wrote
something without the need of @author javadoc tags but incorrectly
attributes the feature to GitHub.

Correctly attribute the feature to where it belongs, Git, and specify
the name of the feature to help users easily take advantage of it.

* Feature/switch to butterknife (#1494)

* Implemented butterknife in MediaDetailFragment [issue #1491]

* Implemented butterknife in MediaDetailPagerFragment [[issue #1491]]

* post merge upstream master wip [[issue #1491]]

* Localisation updates from https://translatewiki.net.

* Bug fix #1504 (#1506)

* Bug fix #1504

* Filtered messages with ConnectException [issue #1504]

* A generalised message for exceptions in Nearby Activity [issue #1504]

* Localisation updates from https://translatewiki.net.

* Fix security exception crash while accessing network location provider (#1498)

* Fix security exception crash while accessing network location provider

* Added java docs

* Localisation updates from https://translatewiki.net.

* Log P18 edits to wikidata corresponding wikidata entity on uploading a nearby image

* Added java docs

* Fix test build

* Refresh nearby

* Refresh nearby list on successful edit

* Java docs

* Make authenticated wikidata edits

* Updated toast message to show entity name that was edited
2018-05-31 11:00:17 +10:00
maskara
59abd022e3 Minor notification fixes 2018-03-21 10:27:19 +05:30
maskara
4ac8f88ec2 Fixes privacy policy link in Login page 2018-03-11 01:36:19 +05:30
Ayushi Negi
cfc1449615 Launch Rate Us Feature from AboutActivity (#1264)
* Launch Rate Us Feature from AboutActivity

Rate us feature is added in Utils, But it is never used/launched.

* Add LaunchRatings Method in AboutActivity

* Fix Package Name to enable rate us feature

The rate us feature was not working for the debug build type since getPackageName() was returning the fr.free.nrw.commons.debug. Use of this package name was leading to an error on google play.

* Replace getPackageName() with BuildConfig.class.getPackage().getName() in rateApp method of Utils.java
2018-03-07 06:44:51 +05:30
Ujjwal Agrawal
eeaa9a90ba
Merge branch 'master' into feat5 2018-02-27 12:17:29 +05:30
Ujjwal Agrawal
fc8b522ac4 Rate Us method added to Utils.java and called on AboutActivity.java 2018-02-27 12:04:04 +05:30
Ujjwal Agrawal
96173e26cf Changed Webviews to Custom Tabs in Nearby Places Dialog, AboutUsActivity (#1185)
* Changed Webviews to Custom Tabs in Nearby Places Dialog, AboutUsActivity

* Created method handleWebUrl in Utils.java
2018-02-25 00:27:49 +05:30
Jón Freysteinn Jónsson
fc7bdc62fb Fix some javadoc issues 2018-02-15 13:20:56 +01:00
Prajeen Govardhanam
d3f2ef32fd
Update Utils.java 2017-12-21 20:58:02 +05:30
prajgov
7e6374f11a added JavaDoc comments 2017-12-19 20:54:28 +05:30
Clay Tsay
eeea0774b6 Added JavaDocs
Added JavaDocs to various files, namely License, Media, PageTitle, and Utils.
2017-12-10 00:28:51 -08:00
Paul Hawke
02b5b9b680 Merge branch 'master' into dependency-injection 2017-11-24 22:30:08 -06:00
maskara
8dd8e09f2a Fixes NPE in Util function 2017-11-16 17:32:45 +05:30
Paul Hawke
f134d23ecb Merge branch 'master' into dependency-injection 2017-10-21 17:20:56 -05:00
Vishan Seru
836a1e3664 Added option in SettingsFragment to allow users to send the logs as a file via email 2017-10-21 13:44:06 +05:30
poojithakr
fc9cd0a3b7 Fixing codacy issues. Reduced reported count from 550 to 518. 2017-10-04 00:28:11 -07:00
Paul Hawke
2d91e81121 Merge branch 'master' into dependency-injection 2017-09-13 20:29:50 -05:00
Paul Hawke
a208c9f273 Further reduced coupling between classes and the need to @Inject the account utils class, fixed imports. 2017-09-10 10:37:58 -05:00
Paul Hawke
ca4b99a1cc Product flavors to allow switching between the production and the beta-cluster Wikimedia servers. 2017-08-26 15:42:44 -05:00
Paul Hawke
d0a85dbd82 Moved single-use code out of Utils over to where it's actually used. 2017-08-26 08:57:16 -05:00
Paul Hawke
7880a08c30 Ensure that activities and content providers are integrated into DI. 2017-08-26 08:56:15 -05:00
mebr1416
0c303298b2 Resolve for "Day mode by default #825" 2017-08-04 18:40:22 +03:00
Yusuke Matsubara
d241d36d66 Add PageTitle class to canonicalize page names 2017-07-13 18:29:30 +09:00
Yusuke Matsubara
39617790f5 Merge pull request #680 from Deskana/fromhtml
Fix usage of deprecated function String.fromHtml(String)
2017-05-28 19:01:30 +09:00
Deskana
14326ae3d0 Fix usage of deprecated function String.fromHtml(String)
String.fromHtml(String) is now deprecated. This patch fixes that by adding a method to Utils that selects the appropriate function based on the user's platform.
2017-05-26 13:52:01 +01:00
Deskana
7a8e04eec1 Simplify if statements
This patch simplifies a few if statements by replacing them with returns, which helps improve code readability and simplicity.
2017-05-26 11:16:22 +01:00
Dmitry Brant
9469bf29e4 Remove dependency on old image-loading library, and remote a lot of code. 2017-05-19 16:24:04 +02:00
Neslihan
e79d18f439 Fix codacy 2017-05-14 15:59:00 +03:00
Neslihan
dc1b04f3ed Switch map button accoding to map and list 2017-05-14 15:51:50 +03:00
addshore
5f6f67d3e2 Use switch statements instead of long if elseifs 2017-05-13 12:52:22 +02:00
addshore
6b75810f37 Collapse try blocks 2017-05-13 12:51:43 +02:00
Yusuke Matsubara
040d99638c Show failed value on license-related RuntimeException 2017-05-12 21:31:10 +09:00
veyndan
d33935c70f Use Timber for logging 2017-04-17 16:41:56 +01:00
Yusuke Matsubara
87b3132d21 Keep obsolete license values to prevent crashe after upgrade 2017-04-16 12:45:16 +09:00
Yusuke Matsubara
8731987385 Generate Nearby list using Wikidata Query
Plus,
* remove duplicate location service manager
* add option to switch data sources of Nearby
* faster sorting of places
* minor coding style improvents
2017-04-14 17:38:45 +09:00
Adam Jones
0fe7a05731 Create SettingsFragment 2017-04-02 16:37:46 +01:00
Adam Jones
c14795043e Merge pull request #469 from veyndan/async-util
Remove AsyncTask utility methods
2017-03-24 23:21:32 +00:00
veyndan
36fe8e3089 Remove AsyncTask utility methods 2017-03-24 23:03:56 +00:00
veyndan
06aeede864 Remove unused method implode(…) 2017-03-24 04:30:08 +00:00
Josephine Lim
3a813dd302 Merge pull request #421 from maskaravivek/fixLintIssues
Fix lint issues
2017-03-12 20:44:55 +10:00
maskara
6cecaf9e8c Fixes #426: Crash fix caused by NPE 2017-03-12 14:18:41 +05:30
maskara
f6f197edbc Minor changes as suggested in comments 2017-03-12 14:00:59 +05:30
maskara
2a7cb20745 Fix lint issue: Locale in date formats 2017-03-11 00:31:31 +05:30
maskara
5ccd24eb33 Fix lint issue: Default locale 2017-03-10 23:37:22 +05:30
maskara
8f6a201d35 Fixes #144: Add CC 4.0 to license options 2017-03-05 03:44:04 +05:30
veyndan
fe42731ee6 Replace fully qualified names with imports 2017-03-02 14:39:08 +00:00
veyndan
d49706ef70 Remove unnecessary imports 2017-03-01 19:15:28 +00:00
misaochan
81503befb0 Add comments 2016-12-15 15:30:33 +13:00
misaochan
bd949f4fd9 Add comments 2016-12-14 16:10:41 +13:00
misaochan
630eebeeac Removed unnecessary comments 2016-12-14 16:06:41 +13:00