* Dangling Javadoc comments
* Replace for loop with foreach
* Explicit type can be replaced with <>
* Anonymous type can be replaced with lambda
* Lambda can be replaced with method reference
* Remove redundant methods
* Use capital L for long literals
* Remove unnecessary StringBuilder
* UploadController: Added support for using author names. Fixes#1707.
* Minor PR tidy-up
* Reword preference item
* Null check to pass startUpload test
* SharedPreferences Dep Injection added, updateLicense() updated
method updateLicense() was previously looking to the UploadModel for the
current default license, this has now been changed so that it gets it from
a SharedPreferences object
* UploadModel.license aligned to SharedPreferences
variable UploadModel.license within the constuctor is now assigned to the string of the
"default_license" value within SharedPreferences
Admittedly this may not be completly necissary as UploadModel.license is modified via
UploadPresenter.updateLicense on creation.
* Updated deleteAll() method to remove all searches insetead of 10 (#2181)
* Updated deleteAll() method to delete all searches instead of 10 (#2181)
* some minor chages
* Add Traceur for getting meaningful RxJava stack traces (#1832)
* Hotfix for overwrite issue in 2.8.0 (#1838)
* This solution is an hotfix for overrite issue came back on 2.8.0 version. What I did is checking the extension, and if it is null, adding .jpg suffix. Because commons files always have suffixes, and we should compare file names after adding suffixes. Othervise overrides are possible.
* Check if file title includes an extension already, by checking if is there any dot in it.
* Fix logic error
* Add uncovered tests
* Remove unecessary line breaks
* Make Javadocs more explicit
* Versioning and changelog for v2.8.2 (#1842)
* Versioning for v2.8.2
* Changelog for v2.8.2
* Delete unused MaterialShowcase class
* Add Javadocs and fix lint errors for DirectUpload.java
* Fix whitespace and add docs
* Replace fragment.getActivity() with the parentActivity var
* Rename unnecessarily-overloaded method getFromWikidataQuery(), add Javadocs
* Javadocs and whitespaces for NearbyPlaces.java
* Use local vars where possible instead of class fields. Non-constants should not be in all caps
* Missed one unnecessary class field
* Remove unnecessary whitespaces that don't improve readability
* Add class summary
* Optimize imports
* Fix access modifiers in Place.java
* Clearer Javadocs
* Add Javadocs to Place.java
* Remove residual conflict
* Fix lint issues in Sitelinks
* Javadocs for Sitelinks.java
* DirectUpload: Replace nested conditionals with guard clauses
* Fix memory leak due to wikidata edit listener (#2048)
* Fix bookmark crash fix (#2047)
* Fix bookmark crash fix
* Fix check for bookmark creator
* Bug fix#2042 (#2056)
* Bug fix#2042
* Added a snack with retry when api in AA fails
* Increased connection timeouts in okhttpclient builder
* added missing string resource
* Bugfix/duplicate categories (#2080)
* Increased timeout to 60 seconds
* Bug fix#1550
* filter duplicate categories
* Fix crash because of inactive fragment UI (#2046)
* Fix crash because of inactive fragment UI
* Add java docs
* Add information icon action Fiixes #2055 2.9.0: the 'i' icon in nearby doesn't do anything (#2057)
* Localisation updates from https://translatewiki.net.
* Remove unused mediawiki api dependency (#1991)
* Categories with pipe suffix (#1873)
* Bug fix issue #1826
Changes made :
-Certain category names used to show suffixed with strings prefixed with pipe '|'. Removed everything after the pipe. As per the discussion on the thread, its safe to remove everything after the pipe, including the pipe
* review suggested changes
*Code formatting
*Extracted out the index of pipe in a variable
*Added issue link in comments
* Remove libraries section from README (#1988)
* Remove libraries section from README
* Add wiki link to "libraries used" to README
* Localisation updates from https://translatewiki.net.
* Localisation updates from https://translatewiki.net.
* Use alert dialog instead of popup window, for nearby information
* Revert irrelevant changes, sorry
* Add cancel and retry buttons on layout contribution
* Make sure your retry logic works
* Add cancel method too
* Add javadocs and remove debug logs
* Remove two unused methods
* Remove old and unused retry buttons as we do for their functions
* Check internet connection before button function, since function requires internet connection
* Remove unused variable
* Display possible solution for badtoken error
* Fix string
* Fixed#1930 Achievements activity is crashing on Android 8.1
* Fixed#1930 Achievements activity is crashing on Android 8.1
* Delete gradle-wrapper.properties
* Update build.gradle
* Create gradle-wrapper.properties
* fixed#1948 Search feature is light in dark theme
* Update FileUtils.java
* Update FileUtils.java
* Update FileUtils.java
* Fixed#1948 Search feature is light in dark theme
* changed files for the build
* Made the changes asked for
* Made the changes asked for
* Update gradle.properties
* Update gradle.properties
* Made changes in RecentSearchFragment
* Update WelcomeActivity.java
Now it starts welcome screen after not finishing the pager. Moved "Skip Tutorial" button here so it does not animate by swipe.
* Update activity_welcome.xml
Putting "Skip Tutorial" button here so that it does not animate by swipes.
* Update LoginActivity.java
Removing the set of "first run " flag from here. we set it after the buttons press or on WelcomeActivity's finish()
* Update welcome_do_upload.xml
removing "skip tut" button from here.
* Update welcome_dont_upload.xml
Removing "Skip Tutorial" button from here so that it does not animate by swipes.
* Update welcome_image_details.xml
Removing "Skip Tutorial" button from here so that it does not animate by swipes.
* Update welcome_wikipedia.xml
Removing "Skip Tutorial" button from here so that it does not animate by swipes.
* Update WelcomePagerAdapter.java
the "welcomyesButton" is removed from the child views in pager, so it is optional now.
* Add JavaDoc to WelcomeActivity.onBackPressed()
* Fix#2103: Remove welcomeYesButton from landscape layout
* Refactor WelcomePagerAdapter
* Add getGeolocation method to geolocation from file path
* Add geolocation check to receiveDirect method checks, means it will be checked durimg nearby direct uploads
* Create method body for geolocation and nearby place coordinate comparaison, this method will be filled on consequent commits
* Add a method to find location missmatch
* app/src/main/java/fr/free/nrw/commons/utils/ImageUtils.java
* Add if check to upload activity to detect pictures with wrong location, and save it to shared prefs
* Do not edit wikidata item if picture has wrong location info
* Add one more bitwise operand to possible warning reasons for wrong location case
* Add a bitwise variable for wrong locatio case
* Share nearby place location just like wikidataEntityId, so that we can compare
* Implement check image geolocation is different method by comparing nearby location and file EXIF geolocation
* Add Javadocs
* Remove logs
* Fix all taken on wrong phrases as taken at
* Fix typo on logs
* Simplify if logic
* Fix string issues
