Paul Hawke
9c0cbe7ad5
Further reduce code calling back to the CommonsApplication by pulling out a SessionManager to manage our current account.
2017-09-09 14:08:40 -05:00
Paul Hawke
388f588301
Correctly configured injection for fragments and services.
2017-08-26 08:57:16 -05:00
Paul Hawke
647cc166ef
@Inject the MediaWikiApi where needed to reduce coupling between classes.
2017-08-26 08:56:15 -05:00
Paul Hawke
8fe2816ca9
First baby steps into the world of dependency injection using Dagger.
2017-08-26 08:56:14 -05:00
Mikel
5cb1f7281b
Fix wrong condition
2017-08-18 20:06:18 +01:00
Mikel
591b10f4c9
Add error message to exception
2017-08-18 20:04:59 +01:00
Mikel
f2e8891db9
Simplify AddAccount task
2017-08-18 17:35:24 +01:00
Mikel
6b80bec3c9
Simplify GetAuthCookie task
2017-08-18 17:34:55 +01:00
Josephine Lim
5796d14e9e
Merge pull request #839 from YDrall/backstack_issue
...
remove signup activity from activity's backstack.
2017-08-14 01:28:54 +10:00
ydrall
68462eac2b
make SignupActivity to terminate on task completion
2017-08-11 15:02:15 +05:30
neslihanturan
0005b82421
Revert "Adding username to Drawer"
2017-08-10 13:56:51 +03:00
Bruce Nishimura
06efa26f5e
Readding log that I accidently deleted
2017-08-02 00:44:27 -04:00
Bruce Nishimura
a014900e37
Removed username from preferences, now uses current account.
...
Improved text positioning/styling slightly.
2017-08-02 00:38:34 -04:00
Bruce Nishimura
2764bc4dd8
Using general preferences instead, splitting long lines.
2017-07-31 20:47:55 -04:00
Bruce Nishimura
d3ce751f59
Added username to picture of the day icon.
2017-07-31 17:08:47 -04:00
Paul Hawke
4796557fb7
Made a pass through the code to introduce lambdas / method references in the places the Android Studio suggested.
2017-07-22 18:04:40 -05:00
Yusuke Matsubara
3b728ca568
Coding style fixes
2017-07-16 15:13:40 +09:00
Josephine Lim
ee409a9e8f
Merge pull request #769 from tised/#748_issue
...
fix for #748
2017-07-16 02:32:26 +10:00
Paul Hawke
8e47f82de6
Merge remote-tracking branch 'upstream/master'
2017-07-15 06:16:31 -05:00
Yusuke Matsubara
d241d36d66
Add PageTitle class to canonicalize page names
2017-07-13 18:29:30 +09:00
Dmytro Vodnik
f3d7465fef
fix for #748
...
that fields doesnt popup because they was shown only after onAuthCookieAcquired fired
2017-07-12 12:28:53 +03:00
Paul Hawke
599e7bb453
Consolidated media wiki api calls in a single place
2017-07-04 14:24:08 -05:00
Paul Hawke
5396fc6ed0
Optimized imports before starting
2017-07-04 14:23:13 -05:00
maskara
bcca6b15e5
Ability to launch welcome activity again
2017-05-29 01:17:07 +05:30
Josephine Lim
c83a0e8e59
Merge pull request #682 from dbrant/textwatcher
...
Always remove TextWatchers when finished with them.
2017-05-28 22:12:02 +10:00
Dmitry Brant
dea43c04b9
Make sure to remove backstackChangeListener when finished.
2017-05-26 16:32:00 -04:00
Dmitry Brant
94e0e5e254
Always remove TextWatcher when finished with it.
2017-05-26 16:06:14 -04:00
Deskana
767878f194
Remove unused imports
...
This patch removes imports across the codebase that are unused to improve
code maintainability and cleanliness.
2017-05-26 11:02:56 +01:00
Fotis Tsalampounis
b83248505f
Removed getSupportActionBar command
...
The getSupportActionBar method caused a null pointer exception in deviced running Android SDK >21 but there is actually no need for it since the theme doesn't have an Action Bar.
2017-05-20 13:14:11 +03:00
Yusuke Matsubara
f039ec37bc
Merge pull request #596 from domdomegg/codestyle
...
Lint issues
2017-05-17 20:15:10 +09:00
addshore
1785e9b179
Fix some codacy issues
2017-05-16 15:19:43 +02:00
addshore
bdfbdc7579
Cleanup CommonsApplication Singelton
2017-05-16 15:19:15 +02:00
maskara
a6bbc8a33b
With NavigationBaseActivity implemented
2017-05-16 11:58:54 +02:00
Adam Jones
75060d7875
Removing unused imports
2017-05-15 16:45:46 +01:00
addshore
367228d758
Switch the main activity to be the LoginActivity
2017-05-15 16:34:54 +02:00
addshore
904ea4554e
Wrap 2fa auth in DEBUG checks
...
Currently although you can log in with 2fa things break
after than. All of the auth code needs a bit of love to
sort this out.
2017-05-14 15:51:04 +02:00
addshore
eb58a847b1
Create AccountUtil class
2017-05-14 15:19:57 +02:00
addshore
a1d8008901
Refactoring in LoginActivity
2017-05-14 15:19:57 +02:00
addshore
1a288176bb
Cleanup WikiAccountAuthenticator logic
...
Some of this logic comes from the wikipedia app,
and basically makes sure that we return 'nice' objects
everywhere rather than lots of null.
There is one note left in the class about the getAuthTokenLabel
method and the fact that we should probably return something
there
2017-05-14 15:19:57 +02:00
addshore
ea051c119a
Add 2fa to login activity
...
Fixes #328
2017-05-14 15:19:57 +02:00
addshore
e8bbbe78d8
Detect when 2FA is needed and error nicely
...
Fixes #507
2017-05-13 12:03:40 +02:00
addshore
d38dde0ec4
Use clientlogin API module
...
This is the first step to allowing 2 factor authentication #328 .
This uses the new API module clientlogin instead of the login module.
We still report the same set of errors in a 'nice' way with real
error messages, how ever there are lots more that can probably be
handled, for example #507 .
2017-05-12 14:36:58 +02:00
veyndan
d33935c70f
Use Timber for logging
2017-04-17 16:41:56 +01:00
veyndan
57a632bdd0
Remove TODOs about being an auto-generated method stub
2017-03-28 06:06:12 +01:00
veyndan
36fe8e3089
Remove AsyncTask utility methods
2017-03-24 23:03:56 +00:00
veyndan
7d4dc12f53
Rename BaseAppCompatActivity to BaseActivity
2017-03-20 21:14:56 +00:00
veyndan
8cc51c4dd9
Extend from AppCompatActivity instead of Activity
2017-03-20 21:14:22 +00:00
misaochan
9be987cd4c
Check for leaky window
2017-03-21 00:54:42 +10:00
misaochan
d7f7a07485
Remove comment
2017-03-20 19:04:20 +10:00
misaochan
8617347927
Add check for null dialog
2017-03-20 19:03:31 +10:00
