Commit graph

2091 commits

Author SHA1 Message Date
Vanshika Arora
cbab7dd303 Resolves Reloading of image on moving to next question in peer review (#2709) 2019-03-23 22:06:12 +00:00
Vanshika Arora
239f74942f Fix #2692: Missing description in upload warning (#2697) 2019-03-23 15:21:27 +00:00
Vanshika Arora
22629a7d8a Fix #2679: Main activity crashing on navigating back from gallery selector (#2680) 2019-03-23 14:42:18 +00:00
Vivek Maskara
8a1a92d44d Remove unused code in ApacheHttpClientMediaWikiApi (#2722) 2019-03-23 14:22:00 +00:00
Dmitry Brant
f7302d4301 Fix a couple more Rx/context inconsistencies. (#2715)
* Stop storing Context!

* Properly contain and dispose of observables.

* Add a few more containments of Rx observables.
2019-03-23 08:52:36 +05:30
Vivek Maskara
7cb1f56165 Use JSON APIs for peer review (#2714) 2019-03-23 01:27:34 +05:30
Vanshika Arora
ce3349385f Refactor asynctasks to Rxjava implementation (#2707) 2019-03-23 00:46:11 +05:30
Dmitry Brant
671e305225 Fix searching in Explore screen. (#2708)
* Fix searching in Explore screen.

* Fix spurious checkstyle issue.
2019-03-22 22:05:04 +05:30
Vanshika Arora
c17a1f90ad Fix #2677: Adjusted position of level number in achievements activity (#2695) 2019-03-21 19:22:58 +00:00
Vivek Maskara
43f314d1df Remove commented code (#2701) 2019-03-21 19:26:12 +03:00
Dmitry Brant
013e1a5430 Fix crash(es) upon upload failure. (#2699)
* Fix crash(es) upon upload failure.

* Further improve Rx structure.
2019-03-21 19:09:36 +03:00
Silky Priya
a32ba452ec Include previous Wikimedia hackathon (2018) task, peer review, to codebase (#2602)
* Add new activity to manifest

* Create review activity layout base

* Add a new menu item to drawer for peer review

* Add a top menu with randomizer icon to review activity

* Add strings for review button

* Add activity to ActivityBuilderModule for injection

* Add a new drawer item to start review acitivty

* Create base of the Review Activity

* Add fragment pager

* Add new fragment for injection

* Create a fragment pager layout

* Wikimedia hackathon 2018 (#1533)

* First draft of fn to get random recent image

* Use log entries for requests to beta, try to connect refresh button

FIXME: runs http request on main thread, breaks

* Tweak button connection

* Add ReviewController class

* Fix fragments

* Wmhack2018 (#1534)

* tiny fixes

* Load pictures into activities

* Re-use same class for all review fragments (#1537)

And try to add pager indicator

* [WIP] category check

* [WIP] add on-click actions to ReviewActivity

* [WIP] add SendThankTask

* Make it beautiful

* Add some category stuff back in to review (#1538)

* Use standalone category extraction code in MediaDataExtractor

* Add categories to category review page

* Change category question text sizes

* Call randomizer whenever the activity is ready

* Add progressbar

* [WIP] add DeleteTask.askReasonAndExecute

* Fix refresh button string

* Typo: "nominate *for* deletion"

* Add formatting to categories and put them in the same textView

* Pass context and adapters as parameters to controller

* Add actions to controller

* Make everyting work

* Add another fragment to thank

* Fix npe

* Add missing execute method

* Some codes

* Add a funy text

* More random recent image selection (#1542)

time-based randomness is biased - if someone uploaded 100 images in
hour, one week ago, and I select a random point in time, their last
image is way more likely to come up than anything else.

With this, there is still bias towards choosing one of the last N
in any burst of uploads (where N is the number of recent changes
fetched) but it's a bit better than before.

* Create Revision class

* Add meaningluf strings

* Error handling for review image/category fetch (#1543)

* Add information layout for username and filename

* Use Single to get firstRevision

* try to add username and filename

* Ensure caption is shown on every review fragment

* Fix build

* Fixes missing import

* Change button text,show current category, add skip image button

* Modify texts, fix night mode issues

* Positive Wording

* fix landscape issue

* Add checkbox popup,rewording

* Spelling Correction

* Fix merge

* Remove commented out code, use lambda

* Simplify toolbar include
2019-03-21 15:05:23 +03:00
Madhur Gupta
d72bd446fe Added information dialog to Statistics #2599 (#2683) 2019-03-20 14:12:20 +03:00
Vanshika Arora
309a51f46a Fix #2659: Nomination notification links to nomination page (#2667) 2019-03-20 08:32:00 +00:00
Zhao Gang
0afcce8919 Remove unused nearby map style code (#2672) 2019-03-19 21:36:33 +00:00
Dmitry Brant
8474c04c64 Fix crash(es) caused by failing to dispose Rx observables (#2669) 2019-03-19 21:08:04 +00:00
Vanshika Arora
38d39e08ac Work on resolving #2311 for viewing failed uploads (#2617) 2019-03-19 21:02:01 +00:00
Dmitry Brant
351109440f Fix memory leak(s). (#2674) 2019-03-19 19:59:33 +00:00
Dmitry Brant
d1ae88ca8b Fix crash on API 19 in Achievements screen. (#2673) 2019-03-19 19:48:55 +00:00
Zhao Gang
f4807a5e4b Remove BitmapUtils (fixed #2638) (#2665)
Use a TextView on top of badge image to show user's level.
2019-03-19 18:16:13 +03:00
Dmitry Brant
adf23c257f Improve extremely inefficient darkness-checking logic. (#2639)
* Improve extremely inefficient darkness-checking logic.

* Use ExifInterface from AndroidX instead of android.media.

* Fix false-positive detekt check.

* Fix false-positive detekt check.
2019-03-19 20:23:36 +05:30
Adam Jones
cfb06f3103 Remove CustomEditText (#2640) 2019-03-19 17:42:01 +03:00
Vanshika Arora
3417d713d2 Fixes #97: Added metadata reader for reading exif data (#2581)
* initial commit

* initial commit

* reading 3 exif directories

* minor changes

* fixed unit tests

* reviwied requested changes

* minor changes

* minor changes
2019-03-19 19:08:42 +05:30
Dmitry Brant
8cd87ad148 Prevent memory leak(s) from QuizChecker. (#2656) 2019-03-19 20:36:14 +10:00
Shubham Pinjwani
3ceaaa9bb4 Fix #2212: Fix back button behaviour in explore views (#2650) 2019-03-18 23:59:58 +00:00
Jason Obeid
04d29fe5f2 Fix #2179: Update ACRA version and theme (#2219) 2019-03-18 23:50:44 +00:00
Bence Konya
66ba35a15f Fix #2205: Fix upload card view arrow direction error (#2653) 2019-03-18 21:03:51 +00:00
Adam Jones
db5290efcf Upload UI tests (#2626)
* Fix SettingsActivityTest

* Add test in SettingsActivity to set recent upload limit to 0

* Add tests to recent upload limit setting

* Simplify activity test rule

* Add UploadTest

* Log the URL where the file should be uploaded

* Generate an image file before testing uploads

* With runtime permissions

* With automatic login

* With automatic login

* Get test credentials from travis
2019-03-19 01:51:44 +05:30
Yusuke Matsubara
ee7af37d00 Stash upload (#2505)
* Introduce Single<UploadResult>

* Two stage upload process

- split upload process and use stash
- resolve filename conflict after upload not before
- use NotificationManagerCompat; add notification tag; assign temporaty stash file name
2019-03-18 21:07:29 +05:30
Shubham Pinjwani
38dc0c3fc8 Fix #2634: Prevent incorrect dialog from appearing if non-GPS location is enabled (#2635)
* Prevent dialog from appearing if location is enabled
* Update Javadoc
2019-03-17 20:41:46 +00:00
Shubham Pinjwani
31c688860d Fix #1850: Show media talk page in media details (#2560) 2019-03-17 17:11:34 +00:00
Adam Jones
3b7b6f91a2
Fix #2203: Require number of uploads not to have decimal (#2615) 2019-03-17 16:54:55 +00:00
Shridhar Goel
40568eccf8 Fix #2394: Prevent crash while navigating between Explore and Achievements (#2395) 2019-03-17 15:29:24 +00:00
Divyanshu Shukla
16df68a073 Fix #2246: Remove NPE in Nearby (#2247) 2019-03-17 15:20:17 +00:00
Brenda Jerop
8e8558ae6d Fix #2017: Explore shows featured images and mobile uploads (#2551) 2019-03-17 10:32:24 +00:00
Vanshika Arora
38dceddbf5 resolved issue #2542 with position of map icon (#2601)
* resolved issue #2542

* removed commented code
2019-03-17 15:42:57 +05:30
Adam Jones
d719a4a9d4 Add tests for PageTitle (#2624) 2019-03-17 11:22:37 +05:30
Adam Jones
cfade144d9 Refactor string sorting utils to remove dependency (#2623)
Also adds Javadocs, and simplifies calculateSimilarity
2019-03-17 11:21:45 +05:30
Shubham Pinjwani
deb0a9874c Fix #2620: Prevent app from crash while visiting achievements in flight mode (#2621) 2019-03-16 17:06:54 +00:00
Vanshika Arora
9d55c1e8d7 Fix #2245: Correct back button behaviour from nearby fragment (#2301) 2019-03-16 16:27:25 +00:00
Vitaly V. Pinchuk
a26b62f51b Fix #1334: Refactor variable names of nearby_query.rq (#2583)
* all variables were refactored to camelCase
2019-03-16 21:09:39 +05:30
Shridhar Goel
a8fac9d160 Fix #2231: Explore recent searches list updates quickly (#2232) 2019-03-16 15:27:28 +00:00
Vivek Maskara
7cb87f3cab Consolidate shared prefs to a single store (#2613)
* Consolidate shared prefs to a single store
* Fix achievements activity
* Fix store usage
2019-03-16 13:56:56 +00:00
Adam Jones
51f58b7118 Add MapBox localization (#2614) 2019-03-16 19:07:21 +05:30
Vivek Maskara
1d225c545e Remove dead code from dialog util (#2612) 2019-03-16 12:55:44 +00:00
Adam Jones
0bbfd54465 Fix #2610: Use dark map theme in night mode (#2611) 2019-03-16 18:03:15 +05:30
Vivek Maskara
6cbce9d283 Fix #1131: Update min sdk version and remove redundant checks (#2608) 2019-03-16 12:21:51 +00:00
Vanshika Arora
900bd4ff2f Fix #2563: Uploading from wikidata with "?" description (#2586) 2019-03-16 12:10:29 +00:00
Vivek Maskara
57e685cf6c Fix #2593: Migrate to androidX (#2594)
* Update dependencies and migrate to androidX
* Make gradle properties tidy
2019-03-16 11:22:37 +00:00
Zhao Gang
bb40c24de8 Fix #2520: Fix dangling snackbar in NearbyFragment (#2521)
NetworkBroadcastReceiver is unregistered in onPause() and not reregistered in onResume(). This causes the snackbar doesn't disappear after network becomes available. Fixed this and improved the null checking logic in snackbar related code.
2019-03-15 23:47:21 +00:00