Deskana
7a8e04eec1
Simplify if statements
...
This patch simplifies a few if statements by replacing them with returns, which helps improve code readability and simplicity.
2017-05-26 11:16:22 +01:00
Deskana
4b7011a725
Remove redundant call to String.format() in CategoryModifier
...
This patch removes a call to String.format that can be replaced with a
literal string which is much clearer.
2017-05-26 11:08:02 +01:00
Deskana
767878f194
Remove unused imports
...
This patch removes imports across the codebase that are unused to improve
code maintainability and cleanliness.
2017-05-26 11:02:56 +01:00
Deskana
9b26465b1d
Remove redundant field in SettingsActivity
...
There is a field that is set in SettingsActivity that is never used at all.
This patch removes that field to improve performance and code tidiness.
2017-05-26 10:55:53 +01:00
Tobias Schönberg
db5dbbfdfd
Fix crash of nearby list when the places list is null
...
Currently the NearbyController crashes when it is called with a
places list that is null. This is caused by the NearbyMapFragment
not handling this state correctly.
This commit adds tests for an empty list and null, which reproduce
the problem. An early return in the NearbyController can make
the tests pass, but might not be the best solution for this issue.
2017-05-24 22:15:38 +02:00
Vivek Maskara
0e71e817b6
Merge pull request #641 from sandarumk/fix_lint_issues
...
Fix lint issues
2017-05-20 19:11:07 +02:00
Josephine Lim
0a94c9c0ba
Merge pull request #647 from dbrant/rotate1
...
Fix showing local image if fetching thumbnail fails.
2017-05-20 16:03:37 +02:00
Dmitry Brant
39e24b1863
Don't put local URI into thumbnail cache.
2017-05-20 15:32:41 +02:00
Josephine Lim
b3215b1e78
Merge pull request #645 from maskaravivek/overlayMenu
...
Add popup menu in nearby info dialog
2017-05-20 15:23:35 +02:00
maskara
75f3fe4ed6
Fixed codacy issues
2017-05-20 13:43:47 +02:00
Dmitry Brant
5fc684fcc5
Fix showing local image if fetching thumbnail fails.
2017-05-20 13:41:23 +02:00
Dinu Kumarasiri
1dbe1fe636
Fix codecy issues
2017-05-20 13:34:51 +02:00
maskara
4823486139
Add popup menu in nearby info dialog
2017-05-20 13:09:16 +02:00
Fotis Tsalampounis
b83248505f
Removed getSupportActionBar command
...
The getSupportActionBar method caused a null pointer exception in deviced running Android SDK >21 but there is actually no need for it since the theme doesn't have an Action Bar.
2017-05-20 13:14:11 +03:00
Josephine Lim
a826ca4049
Merge pull request #639 from dbrant/rotate1
...
Fix display of media detail after screen rotation.
2017-05-20 12:01:32 +02:00
Dinu Kumarasiri
83957bae06
[Lint] Remove class variables to local
2017-05-20 11:53:46 +02:00
Dmitry Brant
96f9526244
Fix display of media detail after screen rotation.
2017-05-20 11:49:15 +02:00
maskara
4cb6fb86f8
Fix back button issue in ShareActivity
2017-05-20 11:35:49 +02:00
Dmitry Brant
269cef559b
Don't show uploads that have been deleted.
2017-05-19 17:59:26 +02:00
Dmitry Brant
ac22525c69
Merge remote-tracking branch 'upstream/master'
2017-05-19 17:38:24 +02:00
Dmitry Brant
38e7cad345
Final touch-ups to improved image loading.
2017-05-19 17:19:10 +02:00
Josephine Lim
9d4c3cd2d9
Merge pull request #633 from maskaravivek/mediaDetail
...
Fix issue where there was no way to back from MediaDetailFragment
2017-05-19 17:02:05 +02:00
maskara
97c76208bd
Fix issue where there was no way to back from MediaDetailFragment
2017-05-19 17:01:26 +02:00
Dmitry Brant
7a4062a377
Merge remote-tracking branch 'upstream/master'
2017-05-19 16:27:08 +02:00
Dmitry Brant
9469bf29e4
Remove dependency on old image-loading library, and remote a lot of code.
2017-05-19 16:24:04 +02:00
Dmitry Brant
85b15cd1c1
Further improve image loading, and remove unused code.
2017-05-19 15:57:25 +02:00
maskara
5fc9f84e79
Fixes #614 : Crash: Fragment State loss exception
2017-05-19 15:44:15 +02:00
Josephine Lim
f6a7759317
Merge pull request #600 from whym/nearby-file
...
Read once and reuse the query file's content
2017-05-19 15:36:49 +02:00
Josephine Lim
6232e35816
Merge pull request #627 from dbrant/master
...
Clean up image loading code, and switch to using Fresco.
2017-05-19 15:20:33 +02:00
Dmitry Brant
a9d58d4757
Merge changes for switching to Fresco.
2017-05-19 15:16:53 +02:00
Dmitry Brant
a3f3ee7fdb
Merge remote-tracking branch 'upstream/master'
2017-05-19 15:14:29 +02:00
Dmitry Brant
bb49fb9801
Clean up image loading code, and switch to using Fresco.
2017-05-19 15:08:29 +02:00
Dinu Kumarasiri
7d6c836e31
Leak Canary Integration
2017-05-19 15:06:15 +02:00
Dinu Kumarasiri
a81aa7fec0
Remove the unnecessary comment
2017-05-19 14:54:21 +02:00
Yusuke Matsubara
19eddb7d26
Merge pull request #619 from f4ww4z/replace-clear
...
Replace 'removeAll(c)' with 'clear()'
2017-05-17 20:28:37 +09:00
Yusuke Matsubara
f039ec37bc
Merge pull request #596 from domdomegg/codestyle
...
Lint issues
2017-05-17 20:15:10 +09:00
Yusuke Matsubara
22f5f51082
Read once and reuse the query file's content
2017-05-17 17:08:31 +09:00
Fawwaz Yusran
547f2a062c
Replace 'removeAll()' with 'clear()'
2017-05-17 13:49:04 +07:00
Tobias Schönberg
bc60cff5fe
Fix lat-long format and add tests
...
Currently the lat-long string in the gallery still contains
negative numbers. Also W values do not work correctly.
This commit fixes the calculations and adds tests for the
LatLng class.
2017-05-16 21:41:18 +02:00
neslihanturan
aec62822fc
Merge pull request #613 from maskaravivek/navigationBeautify
...
With icons in navigation drawer
2017-05-16 18:51:36 +03:00
maskara
c0397858ee
With icons in navigation drawer
2017-05-16 17:20:42 +02:00
addshore
4bda30116a
Update logic from PR 611 that was just merged
2017-05-16 15:20:53 +02:00
addshore
1785e9b179
Fix some codacy issues
2017-05-16 15:19:43 +02:00
addshore
c712b561d4
Get rid of other singletons
2017-05-16 15:19:43 +02:00
addshore
bdfbdc7579
Cleanup CommonsApplication Singelton
2017-05-16 15:19:15 +02:00
Neslihan
be2b944276
Fix codacy
2017-05-16 16:12:16 +03:00
Neslihan
aec4300a2e
Logout thing
2017-05-16 16:01:29 +03:00
Neslihan
cce8c27a66
Add logout action
2017-05-16 15:52:05 +03:00
neslihanturan
1a1fc143c9
Merge pull request #608 from maskaravivek/minorFix
...
Fixes #587 : Remove trailing carriage return
2017-05-16 15:39:56 +03:00
maskara
a4c1087abb
Fixed codacy issue
2017-05-16 13:31:21 +02:00
