misaochan
c3e911f135
Inject prefs into FileProcessor instead of passing it from ShareActivity
2018-05-29 19:12:45 +10:00
misaochan
82659316ff
Add Javadocs to Zoom.java
2018-05-29 19:07:53 +10:00
misaochan
fe185e0da8
Rename mapsFragment to mapButton to be consistent with other FABs
2018-05-29 19:02:38 +10:00
misaochan
96ea3f693d
Fix lint issues
2018-05-29 18:41:47 +10:00
misaochan
7dcf2376a6
Rearrange member vars and method params in Zoom.java
2018-05-29 18:36:37 +10:00
misaochan
0d282af0e6
Catch exceptions in Zoom.java
2018-05-29 18:30:17 +10:00
misaochan
50b674f221
Rearrange member variables and method parameters in Zoom.java
2018-05-29 18:17:27 +10:00
misaochan
56592b3bcd
Fix all compile errors in Zoom.java and ShareActivity.java
2018-05-29 18:12:17 +10:00
neslihanturan
2bd3c318f9
Merge pull request #1562 from ujjwalagrawal17/featured_image_bug
...
Fixes #1518 (fixed Featured image back button bug)
2018-05-29 10:35:16 +03:00
misaochan
c885c31cc5
Merge remote-tracking branch 'refs/remotes/commons-app/master' into upload-overhaul-fork
2018-05-29 16:39:52 +10:00
Ujjwal Agrawal
ab2e8c5919
Javadocs added
2018-05-28 15:14:52 +05:30
Ujjwal Agrawal
89418403f9
fixed featured image back bug
2018-05-28 14:16:29 +05:30
misaochan
3816d81daf
Remove Zoom code from ShareActivity
2018-05-26 00:42:27 +10:00
misaochan
b1055f2fba
Started moving to ZoomUtils.java
2018-05-26 00:42:10 +10:00
misaochan
47f7ee6849
Copy onPositiveResponse() etc to FileProcessor
2018-05-26 00:34:43 +10:00
misaochan
db6ade0d1e
Move detectUnwantedPictures() to FileProcessor
2018-05-26 00:32:33 +10:00
misaochan
11c35b55fc
Tidy up code
2018-05-26 00:30:57 +10:00
misaochan
cc678baa5d
Optimize imports
2018-05-26 00:25:02 +10:00
misaochan
d34ddf3379
Fixed NPE when uploading
2018-05-26 00:17:16 +10:00
misaochan
bc1adca999
Add Dagger usage to FileProcessor
2018-05-26 00:03:48 +10:00
misaochan
bf61d2d8b2
Remove all compile errors
2018-05-26 00:01:39 +10:00
misaochan
89db8847bf
Get FileProcessor working by passing context, Uri, etc
2018-05-25 23:50:20 +10:00
misaochan
af51ffad86
Incomplete creation of FileProcessor object
2018-05-25 23:16:57 +10:00
misaochan
953d00d2f6
Fix whitespace
2018-05-25 23:05:29 +10:00
misaochan
5e0e01b035
Make bulk code transfers to FileProcessor and FileUtils
2018-05-25 23:03:46 +10:00
misaochan
68b5e08eb3
Tidy up getFileCoordinates()
2018-05-25 22:55:22 +10:00
misaochan
104cb5f1d7
Change references to upload.FileUtils
2018-05-25 22:50:22 +10:00
misaochan
5207d8f59a
Remove unused FileUtils after unifying
2018-05-25 22:49:07 +10:00
misaochan
41673c0067
Unify FileUtils.java, misleading to have 2 of it in different packages
2018-05-25 22:48:47 +10:00
misaochan
c97b708b0f
Transfer createCopyPath to FileUtils as a static method
2018-05-25 22:46:50 +10:00
misaochan
3e3956936b
Simplify formatting
2018-05-25 20:26:07 +10:00
misaochan
56eed67ac4
Refactor detectUnwantedPictures()
2018-05-25 20:00:54 +10:00
misaochan
d1981494ad
Refactor checkIfFileExists()
2018-05-25 19:58:55 +10:00
misaochan
5f140a6453
Remove initViewsAndListeners now that ButterKnife has been used
2018-05-25 19:49:02 +10:00
misaochan
99745db13a
Remove comments
2018-05-25 19:45:19 +10:00
misaochan
02a735f2c0
Rearrange member variables
2018-05-25 19:24:58 +10:00
misaochan
e2557f5081
Fix conflicts in ShareActivity.java
2018-05-25 19:22:10 +10:00
misaochan
7cbc2a674c
Merge from commons-app/master
2018-05-25 19:17:55 +10:00
Paul Hawke
a66a0e8ca0
Refactoring to extract GpsCategoryModel and ensure single-responsibility-principle is maintained in CategoryApi.
2018-05-25 01:55:03 -05:00
Paul Hawke
c7948c817b
Extracted a few networking related items into a new Dagger module and finished the process of mocking the main component for tests.
2018-05-25 01:50:35 -05:00
Paul Hawke
32cb8df9ae
Consolidate the networking libraries - drop volley in favor of OkHttp
2018-05-25 01:42:12 -05:00
ShridharGoel
2255bd9a56
Fix for issue #1508 ( #1512 )
...
* Made changes to the error message when user enters wrong login credentials.
* Used a single string for the error message when user enters wrong login credentials.
2018-05-24 16:27:13 +03:00
Vivek Maskara
2a0b9d8a0b
Enable crosswiki notifications and minor UI fixes in displaying notif… ( #1540 )
...
* Enable crosswiki notifications and minor UI fixes in displaying notifications
* Added java docs
2018-05-24 15:54:31 +03:00
Vivek Maskara
41acb76bd8
Show nominate for deletion only for own uploads ( #1541 )
2018-05-24 15:34:04 +03:00
neslihanturan
32d36944fc
Revert "Wmhack2018 ( #1536 )" ( #1539 )
...
This reverts commit 01cb9ccd70
2018-05-19 23:02:29 +03:00
Elliott Eggleston
01cb9ccd70
Wmhack2018 ( #1536 )
...
* Add new activity to manifest
* Create review activity layout base
* Add a new menu item to drawer for peer review
* Add a top menu with randomizer icon to review activity
* Add strings for review button
* Add activity to ActivityBuilderModule for injection
* Add a new drawer item to start review acitivty
* Create base of the Review Activity
* Add fragment pager
* Add new fragment for injection
* Create a fragment pager layout
* Wikimedia hackathon 2018 (#1533 )
* First draft of fn to get random recent image
* Use log entries for requests to beta, try to connect refresh button
FIXME: runs http request on main thread, breaks
* Tweak button connection
* Add ReviewController class
* Fix fragments
* Wmhack2018 (#1534 )
* tiny fixes
* Load pictures into activities
* Re-use same class for all review fragments (#1537 )
And try to add pager indicator
* [WIP] category check
* [WIP] add on-click actions to ReviewActivity
* [WIP] add SendThankTask
* Make it beautiful
* Use standalone category extraction code in MediaDataExtractor
* Add categories to category review page
2018-05-19 23:00:06 +03:00
Vivek Maskara
0cfcd4e942
Merge pull request #1505 from ashishkumar468/feature/switch_to_butterknife
...
Feature/switch to butterknife
2018-05-19 10:29:28 +05:30
Vivek Maskara
f99363c06c
Fix security exception crash while accessing network location provider ( #1498 )
...
* Fix security exception crash while accessing network location provider
* Added java docs
2018-05-18 16:52:11 +05:30
Ashish Kumar
8bdc4f6b95
Bug fix #1504 ( #1506 )
...
* Bug fix #1504
* Filtered messages with ConnectException [issue #1504 ]
* A generalised message for exceptions in Nearby Activity [issue #1504 ]
2018-05-18 16:52:11 +05:30
Ashish Kumar
cd212b7daa
Feature/switch to butterknife ( #1494 )
...
* Implemented butterknife in MediaDetailFragment [issue #1491 ]
* Implemented butterknife in MediaDetailPagerFragment [[issue #1491 ]]
* post merge upstream master wip [[issue #1491 ]]
2018-05-18 16:52:11 +05:30
