Commit graph

175 commits

Author SHA1 Message Date
Josephine Lim
c83a0e8e59 Merge pull request #682 from dbrant/textwatcher
Always remove TextWatchers when finished with them.
2017-05-28 22:12:02 +10:00
Josephine Lim
7a65790251 Merge pull request #679 from Deskana/simplifyif
Simplify if statements in Utils and ExistingFileAsync
2017-05-28 00:33:22 +10:00
Dmitry Brant
5ab060567a Fix vector placeholder images in API <21. 2017-05-26 17:37:18 -04:00
Dmitry Brant
8656098dc5 Fix lint issues. 2017-05-26 16:41:38 -04:00
Dmitry Brant
dea43c04b9 Make sure to remove backstackChangeListener when finished. 2017-05-26 16:32:00 -04:00
Dmitry Brant
bb5a6691f1 Don't pass Activity into MwVolleyApi. 2017-05-26 16:20:55 -04:00
Dmitry Brant
b07432fce2 Don't pass Activity into GPSExtractor. 2017-05-26 16:18:27 -04:00
Dmitry Brant
94e0e5e254 Always remove TextWatcher when finished with it. 2017-05-26 16:06:14 -04:00
Dmitry Brant
1809475fea Don't require Activity to be passed into UploadController. 2017-05-26 15:34:10 -04:00
Dinu Kumarasiri
40c1ea375a Merge pull request #681 from dbrant/crash2
Fix crash when uploading multiple photos.
2017-05-26 23:35:37 +05:30
Dmitry Brant
5923e9ad4a Fix crash in PhotoDisplayAdapter. 2017-05-26 13:35:40 -04:00
Deskana
7a8e04eec1 Simplify if statements
This patch simplifies a few if statements by replacing them with returns, which helps improve code readability and simplicity.
2017-05-26 11:16:22 +01:00
Deskana
767878f194 Remove unused imports
This patch removes imports across the codebase that are unused to improve
code maintainability and cleanliness.
2017-05-26 11:02:56 +01:00
Vivek Maskara
0e71e817b6 Merge pull request #641 from sandarumk/fix_lint_issues
Fix lint issues
2017-05-20 19:11:07 +02:00
Dinu Kumarasiri
1dbe1fe636 Fix codecy issues 2017-05-20 13:34:51 +02:00
Dinu Kumarasiri
83957bae06 [Lint] Remove class variables to local 2017-05-20 11:53:46 +02:00
maskara
4cb6fb86f8 Fix back button issue in ShareActivity 2017-05-20 11:35:49 +02:00
Dmitry Brant
9469bf29e4 Remove dependency on old image-loading library, and remote a lot of code. 2017-05-19 16:24:04 +02:00
Yusuke Matsubara
f039ec37bc Merge pull request #596 from domdomegg/codestyle
Lint issues
2017-05-17 20:15:10 +09:00
addshore
bdfbdc7579 Cleanup CommonsApplication Singelton 2017-05-16 15:19:15 +02:00
maskara
a4c1087abb Fixed codacy issue 2017-05-16 13:31:21 +02:00
maskara
63937a842a Add navigation drawer to Share and Multi Share activity 2017-05-16 13:24:39 +02:00
Adam Jones
8e3e8982c7 Android correctness lint issues 2017-05-15 16:45:46 +01:00
Josephine Lim
364199dcb2 Merge pull request #577 from commons-app/2fa
2fa work
2017-05-15 15:25:24 +02:00
addshore
eb58a847b1 Create AccountUtil class 2017-05-14 15:19:57 +02:00
Yusuke Matsubara
08e6743869 Merge branch 'master' into tidySettings 2017-05-14 20:57:01 +09:00
addshore
5fe95813df Simplify boolean expressions 2017-05-13 13:01:45 +02:00
addshore
d38dde0ec4 Use clientlogin API module
This is the first step to allowing 2 factor authentication #328.
This uses the new API module clientlogin instead of the login module.

We still report the same set of errors in a 'nice' way with real
error messages, how ever there are lots more that can probably be
handled, for example #507.
2017-05-12 14:36:58 +02:00
Adam Jones
d9afd0e4bf Improve code style 2017-05-10 23:16:35 +01:00
Adam Jones
0c5e0869b5 Check in SingleUploadFragment that spinner position is valid before applying 2017-05-10 22:51:33 +01:00
veyndan
d33935c70f Use Timber for logging 2017-04-17 16:41:56 +01:00
veyndan
9d656768aa Use getString(…) with formatArgs 2017-04-12 19:12:58 +01:00
Josephine Lim
24a3225280 Merge pull request #475 from veyndan/illegal-state
Don't have default values when obtaining item from spinner
2017-04-06 01:29:03 +10:00
Adam Jones
0fe7a05731 Create SettingsFragment 2017-04-02 16:37:46 +01:00
Josephine Lim
6d080889ff Merge pull request #479 from maskaravivek/stateloss
Fixes #435: Allowing state loss commit for fragment transaction
2017-04-03 01:14:43 +10:00
maskara
7f7b25f113 Allowing state loss commit for fragment transaction 2017-04-02 03:13:54 +05:30
veyndan
d20bc5f1ce Revert ommitting default value from Prefs.DEFAULT_LICENSE 2017-04-01 21:38:17 +01:00
Josephine Lim
a3a6417b45 Merge pull request #477 from veyndan/generic
Use parameterized types
2017-04-01 21:29:44 +10:00
veyndan
d8b7d5b438 Improve type safety through the use of generics 2017-03-31 22:21:13 +01:00
veyndan
dc53ab9ff8 Remove unnecessary super call 2017-03-31 05:12:23 +01:00
veyndan
3926b2165d Don't have default values when obtaining item from spinner 2017-03-31 03:59:25 +01:00
veyndan
36fe8e3089 Remove AsyncTask utility methods 2017-03-24 23:03:56 +00:00
Adam Jones
ea43e1a796 Fix Codacy Issues + remove unused patch 2017-03-23 17:51:13 +00:00
Neslihan
08b46b8b3f Remove duplicates 2017-03-21 12:08:27 +03:00
Neslihan
235e2239c9 Fix Conflicts 2017-03-21 01:03:20 +03:00
Neslihan
b7d6be5926 Remove unused codes 2017-03-21 00:50:24 +03:00
Neslihan
e567acfc4f Fix spinner theme problem 2017-03-21 00:44:27 +03:00
maskara
060750b050 Added support for butterknife library for view bindings 2017-03-21 00:04:32 +05:30
Neslihan
7b5f5d9dde Remove unused imports 2017-03-18 12:38:22 +03:00
Neslihan
7e256175dc Move theme checkbox to settings activity 2017-03-18 01:49:19 +03:00