Commit graph

2503 commits

Author SHA1 Message Date
Paulina
67beb947c5
Hidden categories are not showed in suggested categories (#3853) 2020-07-19 20:59:29 +05:30
Vivek Maskara
6f4c60b5ff
With pause and resume for uploads (#3858)
* With pause and resume for uploads

* Dispose current upload

* Make pause and resume work

* Check stash validity

* With java docs

* minor
2020-07-08 00:32:41 +10:00
Seán Mac Gillicuddy
e40e9690dd
#3749 Improve MediaClient UnitTests (#3846)
* #3468 Switch from RvRenderer to AdapterDelegates - replace SearchDepictionsRenderer

* #3468 Switch from RvRenderer to AdapterDelegates - replace UploadCategoryDepictionsRenderer

* #3468 Switch from RvRenderer to AdapterDelegates - update BaseAdapter to be easier to use

* #3468 Switch from RvRenderer to AdapterDelegates - replace SearchImagesRenderer

* #3468 Switch from RvRenderer to AdapterDelegates - replace SearchCategoriesRenderer

* #3468 Switch from RvRenderer to AdapterDelegates - replace NotificationRenderer

* #3468 Switch from RvRenderer to AdapterDelegates - replace UploadDepictsRenderer

* #3468 Switch from RvRenderer to AdapterDelegates - replace PlaceRenderer

* #3756 Convert SearchDepictionsFragment to use Pagination - convert SearchDepictionsFragment

* #3756 Convert SearchDepictionsFragment to use Pagination - fix presenter unit tests now that view is not nullable - fix Category prefix imports

* #3756 Convert SearchDepictionsFragment to use Pagination - test DataSource related classes

* #3756 Convert SearchDepictionsFragment to use Pagination - reset rx scheduler - ignore failing test

* #3760 Convert SearchCategoriesFragment to use Pagination - extract functionality of pagination to base classes - add category pagination

* #3772 Convert SearchImagesFragment to use Pagination  - convert SearchImagesFragment - tidy up showing the empty view - make search fragments show snackbar with appropriate text

* #3772 Convert SearchImagesFragment to use Pagination  - allow viewpager to load more data

* #3760 remove test that got re-added by merge

* #3760 remove duplicate dependency

* #3772 fix compilation

* #3780 Create media using a combination of Entities & MwQueryResult - construct media with an entity - move fields from media down to contribution - move dynamic fields outside of media - remove unused constructors - remove all unnecessary fetching of captions/descriptions - bump database version

* #3808 Construct media objects that depict an item id correctly - use generator to construct media for DepictedImages

* #3810 Convert DepictedImagesFragment to use Pagination - extract common media paging methods - convert to DepictedImages to use pagination

* #3810 Convert DepictedImagesFragment to use Pagination - rename base classes to better reflect usage

* #3810 Convert DepictedImagesFragment to use Pagination - map to empty result with no pages

* #3810 Convert DepictedImagesFragment to use Pagination - align test with returned values

* #3780 Create media using a combination of Entities & MwQueryResult - update wikicode to align with expected behaviour

* #3780 Create media using a combination of Entities & MwQueryResult - replace old site of thumbnail title with most relevant caption

* #3818 Convert SubDepictionListFragment to use Pagination - replace SubDepictionList with Child and Parent Fragments - replace contracts with simple presenter declarations - move classes to appropriate packages - delete unused network models - delete duplicated paging classes

* #3820 Convert CategoryImagesListFragment to use Pagination - replace CategoryImagesListFragment with CategoriesMediaFragment - disallow the construction of media objects without imageinfo

* #3822 Convert SubCategoryImagesListFragment to use Pagination - convert subcategories - add continuation support in category client - rely on interfaces for callbacks of PageableMediaFragments

* #3822 Convert SubCategoryImagesListFragment to use Pagination - convert parent categories - delete list fragment - creat base class to support continuation requests in clients

* #3822 Convert SubCategoryImagesListFragment to use Pagination - add tests for ParentCategoriesDataSource

* #3822 Convert SubCategoryImagesListFragment to use Pagination - remove no longer applicable test

* #3749 Improve MediaClient UnitTests - test rewrite

* #3749 Improve MediaClient UnitTests - align with buildConfig property
2020-07-06 11:17:23 -07:00
Saumia Singhal
764f9281e8
remove nested scroll view in fragment_upload_media_detail_fragment (#3859) 2020-07-01 10:15:08 -07:00
Vivek Maskara
96cf57711e
Fix build (#3857) 2020-06-30 12:48:25 -07:00
Seán Mac Gillicuddy
cc2f14dab8
#3847 Convert Media and Contribution to Kotlin Data Classes - convert to data classes - compose a contribution with a media (#3848)
Co-authored-by: Vivek Maskara <maskaravivek@gmail.com>
2020-06-30 12:41:56 -07:00
Vivek Maskara
3361155fad
With chunked uploads (#3855) 2020-06-30 22:01:25 +05:30
Vivek Maskara
f26784e9c3
Set Media legend for wikidata entity (#3838)
* Set media legends and P18

* Minor

* Make media legends work

* Add test cases

* Use statement partial

* With minor refactoring

* Fix build
2020-06-30 22:11:27 +10:00
Bryan Hauser
dea629c2c4
#3726 Add map legend (#3839)
* strings: add strings for map legend

* nearby: split description into a layout and add legend

* nearby: add newline at end of file
2020-06-30 02:11:26 +10:00
Seán Mac Gillicuddy
542d321acc
#3841 Unit Test DepictsClient (#3842)
* #3468 Switch from RvRenderer to AdapterDelegates - replace SearchDepictionsRenderer

* #3468 Switch from RvRenderer to AdapterDelegates - replace UploadCategoryDepictionsRenderer

* #3468 Switch from RvRenderer to AdapterDelegates - update BaseAdapter to be easier to use

* #3468 Switch from RvRenderer to AdapterDelegates - replace SearchImagesRenderer

* #3468 Switch from RvRenderer to AdapterDelegates - replace SearchCategoriesRenderer

* #3468 Switch from RvRenderer to AdapterDelegates - replace NotificationRenderer

* #3468 Switch from RvRenderer to AdapterDelegates - replace UploadDepictsRenderer

* #3468 Switch from RvRenderer to AdapterDelegates - replace PlaceRenderer

* #3756 Convert SearchDepictionsFragment to use Pagination - convert SearchDepictionsFragment

* #3756 Convert SearchDepictionsFragment to use Pagination - fix presenter unit tests now that view is not nullable - fix Category prefix imports

* #3756 Convert SearchDepictionsFragment to use Pagination - test DataSource related classes

* #3756 Convert SearchDepictionsFragment to use Pagination - reset rx scheduler - ignore failing test

* #3760 Convert SearchCategoriesFragment to use Pagination - extract functionality of pagination to base classes - add category pagination

* #3772 Convert SearchImagesFragment to use Pagination  - convert SearchImagesFragment - tidy up showing the empty view - make search fragments show snackbar with appropriate text

* #3772 Convert SearchImagesFragment to use Pagination  - allow viewpager to load more data

* #3760 remove test that got re-added by merge

* #3760 remove duplicate dependency

* #3772 fix compilation

* #3780 Create media using a combination of Entities & MwQueryResult - construct media with an entity - move fields from media down to contribution - move dynamic fields outside of media - remove unused constructors - remove all unnecessary fetching of captions/descriptions - bump database version

* #3808 Construct media objects that depict an item id correctly - use generator to construct media for DepictedImages

* #3810 Convert DepictedImagesFragment to use Pagination - extract common media paging methods - convert to DepictedImages to use pagination

* #3810 Convert DepictedImagesFragment to use Pagination - rename base classes to better reflect usage

* #3810 Convert DepictedImagesFragment to use Pagination - map to empty result with no pages

* #3810 Convert DepictedImagesFragment to use Pagination - align test with returned values

* #3780 Create media using a combination of Entities & MwQueryResult - update wikicode to align with expected behaviour

* #3780 Create media using a combination of Entities & MwQueryResult - replace old site of thumbnail title with most relevant caption

* #3818 Convert SubDepictionListFragment to use Pagination - replace SubDepictionList with Child and Parent Fragments - replace contracts with simple presenter declarations - move classes to appropriate packages - delete unused network models - delete duplicated paging classes

* #3820 Convert CategoryImagesListFragment to use Pagination - replace CategoryImagesListFragment with CategoriesMediaFragment - disallow the construction of media objects without imageinfo

* #3822 Convert SubCategoryImagesListFragment to use Pagination - convert subcategories - add continuation support in category client - rely on interfaces for callbacks of PageableMediaFragments

* #3822 Convert SubCategoryImagesListFragment to use Pagination - convert parent categories - delete list fragment - creat base class to support continuation requests in clients

* #3822 Convert SubCategoryImagesListFragment to use Pagination - add tests for ParentCategoriesDataSource

* #3822 Convert SubCategoryImagesListFragment to use Pagination - remove no longer applicable test

* #3841 Unit Test DepictsClient - add tests

* #3841 Unit Test DepictsClient - fix return types
2020-06-26 17:54:26 +10:00
Seán Mac Gillicuddy
9d59915459
#3822 Convert SubCategoryImagesListFragment to use Pagination (#3824) 2020-06-25 15:40:02 +03:00
Seán Mac Gillicuddy
7817518462
#3820 Convert CategoryImagesListFragment to use Pagination (#3821) 2020-06-25 12:38:58 +03:00
Seán Mac Gillicuddy
0e5ba98c2e
#3818 Convert SubDepictionListFragment to use Pagination (#3819) 2020-06-25 12:08:15 +03:00
Seán Mac Gillicuddy
34ab6f581b
#3810 Convert DepictedImagesFragment to use Pagination (#3815)
* #3468 Switch from RvRenderer to AdapterDelegates - replace SearchDepictionsRenderer

* #3468 Switch from RvRenderer to AdapterDelegates - replace UploadCategoryDepictionsRenderer

* #3468 Switch from RvRenderer to AdapterDelegates - update BaseAdapter to be easier to use

* #3468 Switch from RvRenderer to AdapterDelegates - replace SearchImagesRenderer

* #3468 Switch from RvRenderer to AdapterDelegates - replace SearchCategoriesRenderer

* #3468 Switch from RvRenderer to AdapterDelegates - replace NotificationRenderer

* #3468 Switch from RvRenderer to AdapterDelegates - replace UploadDepictsRenderer

* #3468 Switch from RvRenderer to AdapterDelegates - replace PlaceRenderer

* #3756 Convert SearchDepictionsFragment to use Pagination - convert SearchDepictionsFragment

* #3756 Convert SearchDepictionsFragment to use Pagination - fix presenter unit tests now that view is not nullable - fix Category prefix imports

* #3756 Convert SearchDepictionsFragment to use Pagination - test DataSource related classes

* #3756 Convert SearchDepictionsFragment to use Pagination - reset rx scheduler - ignore failing test

* #3760 Convert SearchCategoriesFragment to use Pagination - extract functionality of pagination to base classes - add category pagination

* #3772 Convert SearchImagesFragment to use Pagination  - convert SearchImagesFragment - tidy up showing the empty view - make search fragments show snackbar with appropriate text

* #3772 Convert SearchImagesFragment to use Pagination  - allow viewpager to load more data

* #3760 remove test that got re-added by merge

* #3760 remove duplicate dependency

* #3772 fix compilation

* #3780 Create media using a combination of Entities & MwQueryResult - construct media with an entity - move fields from media down to contribution - move dynamic fields outside of media - remove unused constructors - remove all unnecessary fetching of captions/descriptions - bump database version

* #3808 Construct media objects that depict an item id correctly - use generator to construct media for DepictedImages

* #3810 Convert DepictedImagesFragment to use Pagination - extract common media paging methods - convert to DepictedImages to use pagination

* #3810 Convert DepictedImagesFragment to use Pagination - rename base classes to better reflect usage

* #3810 Convert DepictedImagesFragment to use Pagination - map to empty result with no pages

* #3810 Convert DepictedImagesFragment to use Pagination - align test with returned values

* #3780 Create media using a combination of Entities & MwQueryResult - update wikicode to align with expected behaviour

* #3780 Create media using a combination of Entities & MwQueryResult - replace old site of thumbnail title with most relevant caption
2020-06-25 18:02:51 +10:00
Seán Mac Gillicuddy
4b22583b60
#3780 Create media using a combination of Entities & MwQueryResult (#3786)
* #3468 Switch from RvRenderer to AdapterDelegates - replace SearchDepictionsRenderer

* #3468 Switch from RvRenderer to AdapterDelegates - replace UploadCategoryDepictionsRenderer

* #3468 Switch from RvRenderer to AdapterDelegates - update BaseAdapter to be easier to use

* #3468 Switch from RvRenderer to AdapterDelegates - replace SearchImagesRenderer

* #3468 Switch from RvRenderer to AdapterDelegates - replace SearchCategoriesRenderer

* #3468 Switch from RvRenderer to AdapterDelegates - replace NotificationRenderer

* #3468 Switch from RvRenderer to AdapterDelegates - replace UploadDepictsRenderer

* #3468 Switch from RvRenderer to AdapterDelegates - replace PlaceRenderer

* #3756 Convert SearchDepictionsFragment to use Pagination - convert SearchDepictionsFragment

* #3756 Convert SearchDepictionsFragment to use Pagination - fix presenter unit tests now that view is not nullable - fix Category prefix imports

* #3756 Convert SearchDepictionsFragment to use Pagination - test DataSource related classes

* #3756 Convert SearchDepictionsFragment to use Pagination - reset rx scheduler - ignore failing test

* #3760 Convert SearchCategoriesFragment to use Pagination - extract functionality of pagination to base classes - add category pagination

* #3772 Convert SearchImagesFragment to use Pagination  - convert SearchImagesFragment - tidy up showing the empty view - make search fragments show snackbar with appropriate text

* #3772 Convert SearchImagesFragment to use Pagination  - allow viewpager to load more data

* #3760 remove test that got re-added by merge

* #3760 remove duplicate dependency

* #3772 fix compilation

* #3780 Create media using a combination of Entities & MwQueryResult - construct media with an entity - move fields from media down to contribution - move dynamic fields outside of media - remove unused constructors - remove all unnecessary fetching of captions/descriptions - bump database version

* #3808 Construct media objects that depict an item id correctly - use generator to construct media for DepictedImages

* #3780 Create media using a combination of Entities & MwQueryResult - update wikicode to align with expected behaviour

* #3780 Create media using a combination of Entities & MwQueryResult - replace old site of thumbnail title with most relevant caption
2020-06-25 17:20:01 +10:00
Seán Mac Gillicuddy
bf4b7e2efc
#3843 Unit Test DepictedItem - add tests (#3844) 2020-06-25 16:59:50 +10:00
Seán Mac Gillicuddy
7cfa8078f4
#3600 [structured-commons] From Nearby, "Next" button greyed out until modifying caption - set textwatcher first (#3809) 2020-06-24 23:49:08 +10:00
Seán Mac Gillicuddy
dd5a1ba5f2
#3834 Fix broken uploads without a place - delete log (#3835) 2020-06-22 16:51:18 +05:30
Seán Mac Gillicuddy
43b753dfe9
#3811 Convert MediaDataExtractor to Kotlin - convert (#3812) 2020-06-17 09:38:43 -07:00
Seán Mac Gillicuddy
422890cac4
#3813 Convert MediaClient to Kotlin (#3814)
* #3813 Convert MediaClient to Kotlin - convert

* #3813 Convert MediaClient to Kotlin - update tests

* #3813 Convert MediaClient to Kotlin - fix List typing

* #3813 Convert MediaClient to Kotlin - fix mock injecting
2020-06-17 09:38:17 -07:00
Seán Mac Gillicuddy
c77ed747fe
#3772 Convert SearchImagesFragment to use Pagination (#3779) 2020-06-16 16:58:48 +03:00
Vivek Maskara
e4190f3f7d
With option for associating image with wikipedia article (#3783) 2020-06-16 16:51:06 +03:00
Seán Mac Gillicuddy
f4d81eb4ca
#3760 Convert SearchCategoriesFragment to use Pagination (#3770) 2020-06-10 15:57:13 +03:00
Ashish Kumar
27cc41069f
Fixes #3784 (#3787)
* Added empty constructor in ContributionsListFragment
* Initialise ContributionsListFragment's callaback in onAttach
2020-06-05 13:51:08 +03:00
Vivek Maskara
d863a404f1
With lazy loading of contributions (#3566) 2020-05-28 14:54:41 +03:00
Seán Mac Gillicuddy
c216fdf0d4
#3756 Convert SearchDepictionsFragment to use Pagination (#3758) 2020-05-28 14:10:04 +03:00
Seán Mac Gillicuddy
b063d6bdfd #3468 Switch from RvRenderer to AdapterDelegates (#3750)
* #3468 Switch from RvRenderer to AdapterDelegates - replace SearchDepictionsRenderer

* #3468 Switch from RvRenderer to AdapterDelegates - replace UploadCategoryDepictionsRenderer

* #3468 Switch from RvRenderer to AdapterDelegates - update BaseAdapter to be easier to use

* #3468 Switch from RvRenderer to AdapterDelegates - replace SearchImagesRenderer

* #3468 Switch from RvRenderer to AdapterDelegates - replace SearchCategoriesRenderer

* #3468 Switch from RvRenderer to AdapterDelegates - replace NotificationRenderer

* #3468 Switch from RvRenderer to AdapterDelegates - replace UploadDepictsRenderer

* #3468 Switch from RvRenderer to AdapterDelegates - replace PlaceRenderer

* #3468 fix constant import

* #3468 Switch from RvRenderer to AdapterDelegates - resolve id conflict
2020-05-27 19:44:21 +10:00
Vaibhav
82d662c8ef Add destroyed column to BookmarkLocation table (##3729) (#3774)
* Add destroyed column to BookmarkLocation table (##3729)

* switch with fall through for migrations
2020-05-27 10:10:00 +01:00
Seán Mac Gillicuddy
df76aef070
#3763 IllegalArgumentException at fetchImagesForDepictedItem - pass entityId in (#3764) 2020-05-22 01:50:49 +10:00
Seán Mac Gillicuddy
618ace707b
#3752 Media details do not show depiction - make request return all languages available and choose preferred or first (#3761) 2020-05-21 21:51:20 +09:00
neslihanturan
3f31c3eded
Add bookmarks to Nearby map (#3728)
* Remove bookmark button from row button set and put to upper level list item

* Fix npe caused by lookinf for parent fragment, we don't have one anymore

* style

* Add new icons for bookmarked places

* Change bookmarked info when bookmarked

* Add pic field to bookmark dao so that we can retrieve them later

* Put bookmarks as the first item of list

* Add bookmark as a label

* Add logic to filter nearby

* remove unneeded changes

* fix word

* Remove logs

* Remove unused part of code

* Fix tests

* Remove logs

* simplify icon picking

* remove redundant margin left

* Remove non needed map and swap

* Add main thread annotation

* Fix tests
2020-05-21 20:58:27 +10:00
Seán Mac Gillicuddy
384afa6c44
#3753 Item label/description: Fall back to non-empty language - attempt to read labels by language or the first one in the list (#3759) 2020-05-21 08:54:09 +09:00
Seán Mac Gillicuddy
de3377c0fe
#3120 Suggest categories based on depictions (#3736) 2020-05-20 17:26:16 +03:00
Cloe Riva
01839dec6e
Adding multidex to support more method references (#3755)
* adding multidex to support more method references

* add multidex version to gradle properties
2020-05-19 14:32:33 +01:00
Cloe Riva
7084fd2535
Nearby: make list resize and display message when empty (#3746)
* Nearby: make list resize and display message when empty

* refactored and renamed for clarity

* refactoring and simplifying based on comments

* refactoring and simplifying based on comments

* removing vertical orientation
2020-05-19 13:43:49 +01:00
Seán Mac Gillicuddy
4690925cf5
#3734 Refactor and convert CategoryPresenter to kotlin (#3735) 2020-05-15 16:17:26 +03:00
Seán Mac Gillicuddy
e597a7c96f
#3745 Upload depiction suggestions not following text input - on upstream error emit empty list (#3751) 2020-05-14 23:32:51 +09:00
Seán Mac Gillicuddy
affcd8a6d7
#3733 On first view of DepictionUpload suggestions don't show - remove zip which was only taking 1 value from the processor (#3737) 2020-05-12 16:38:45 +03:00
Seán Mac Gillicuddy
057d11a0e0
#3077 Hide disambiguation items from depiction search - when fetching depictions get the entity instead of the search result (#3741) 2020-05-12 13:44:17 +03:00
Seán Mac Gillicuddy
4443810823
#3699 Multiple upload: Only one file's caption is used for all files, others ignored - share model data with the UI - inline and remove Remote/LocalDataSource (#3707) 2020-05-08 20:21:17 +10:00
Vaibhav
11ff5fb055
Fix NullPointer when clicking on image in MediaDetailFragment (#3730) (#3738)
Uri.parse would throw NullPointerException if the image in MediaDetailFragment was clicked before the image URL is available
2020-05-08 09:37:00 +05:30
Seán Mac Gillicuddy
77f75a4627
#3716 Depiction search does not return any results - clear so CompositeDisposable can be reused (#3731) 2020-05-06 20:07:40 +10:00
Seán Mac Gillicuddy
953f09d683
#3448 CategoryImagesListFragment.handleError never succeeds (#3710)
* #3448 CategoryImagesListFragment.handleError never succeeds - remove timeouts, rely on default timeout params

* #3448 CategoryImagesListFragment.handleError never succeeds - fix compilation
2020-05-05 12:00:42 -07:00
Vitaly V. Pinchuk
6d687c3efb
Fixes #3720: None of the filters work on Nearby list (#3723) 2020-05-04 17:15:08 +03:00
Vitaly V. Pinchuk
ff9f4f20e7
Fixes #3704: Green pins seen on initial "Nearby" map, despite "Needs Photos" selected (#3721) 2020-05-04 16:43:08 +03:00
Raj Bapat
95372f33b5
There were 2 issues combined into one: (#3643)
1. The languages were shown with the characters of the given language (i.e. Mandarin was displayed with Chinese characters).
2. The languages were not sorted
How I fixed them:
1. I changed the list that was called from AppLanguageLookUpTable from localized to cannonical.
2. I imported List and Collections and I sorted said list in lexicographical order.
2020-04-26 00:23:00 -07:00
Vitaly V. Pinchuk
1fea1bbf49
Get rid of HandlerService #3555 (#3671)
* [WIP] Removed HandlerService

* [WIP] Added PublishProcessor for managing queue

* Resolved conflicts after merge
2020-04-25 23:17:57 -07:00
Seán Mac Gillicuddy
36a31a96dc
#3451 Delete CompatTextView - remove all references to CompatTextView (#3709) 2020-04-25 13:21:19 -07:00
Kshitij Bhardwaj
82bf2d757f
Fixes #3679: Issues with new media details UI (#3697) 2020-04-25 12:34:28 +03:00
Seán Mac Gillicuddy
707e3145c2
#3601 [structured-commons] Wrong thumbnails at the "depictions" step when uploading (#3696)
* #3601 [structured-commons] Wrong thumbnails at the "depictions" step when uploading - fix imageview rendering code

* #3601 [structured-commons] Wrong thumbnails at the "depictions" step when uploading - show selected depictions at the top - ensure updates to nearby places are reflected

* #3601 [structured-commons] Wrong thumbnails at the "depictions" step when uploading - don't set imageUrl when the url is none

* #3601 [structured-commons] Wrong thumbnails at the "depictions" step when uploading - rewrite unit tests

* #3601 [structured-commons] Wrong thumbnails at the "depictions" step when uploading - minor cleanup

* #3601 [structured-commons] Wrong thumbnails at the "depictions" step when uploading - fix erroneous cache access
2020-04-25 12:27:21 +03:00