Commit graph

2503 commits

Author SHA1 Message Date
Ayan Sarkar
0e4755301e
Nearby tab accessible without GPS (#4771)
* Nearby accessible without GPS

* Java doc added

* Added NearbyParentFragment test

* Test added

* merged two method and tests updates
2022-02-05 21:16:08 +05:30
Ayan Sarkar
e135fea20d
Fixes 1848 : Option for adding location for those pictures which have no location (#4755)
* Location wizard

* Location wizard

* Minor fix

* message changed

* Test fail fixed

* Test fail fixed

* Test fail fixed

* last location triggered

* last location added

* Some test added

* Java docs added

* More java docs added
2022-02-05 09:56:59 +09:00
Madhur Gupta
ff8f067841
Add Unit Tests for CategoryEditSearchRecyclerViewAdapter (#4775)
* Add Unit Tests for CategoryEditSearchRecyclerViewAdapter

* Use mock context instead of robolectric context
2022-02-02 16:24:32 +10:00
Madhur Gupta
9e38c33650
Add some more tests for SearchActivity (#4780) 2022-02-01 19:26:13 +10:00
Madhur Gupta
d77ae8e582
Add some more tests for NearbyController (#4778) 2022-02-01 19:25:49 +10:00
Ratnesh
873b4c500b
Show alert dialog card for sharing personal detail submission via email when clicking on the feedback menu. (#4772)
* Fixes #4732 Show alert dialog card for sharing personal detail submission via email when clicking on feedback menu.

* Show alert dialog card for sharing personal detail submission via email when clicking on feedback menu when user is logged in.

Add javadoc for the new methods
Update alert dialog message.
2022-01-31 23:16:02 +09:00
Ayan Sarkar
f162326e53
Fixed bug (#4763) 2022-01-25 21:38:37 +09:00
Ayan Sarkar
7e12d28557
Fixes 4497 : this a photo of place X: Do not ask if the item (depiction) is already selected for addition and the photo already has a caption (#4754)
* Dialog can't be dismissed

* Dialog can't be dismissed

* Nearby Place dialog can remember user preference

* Minor change

* Minor change

* Renamed the map
2022-01-20 23:34:44 +09:00
Ayan Sarkar
92957f4204
Displaying Category image and Description (#4531)
* API call done

* API call

* Image implementation done

* Gradle

* Java docs and code convention

* Description added

* Refactoring Category

* Refactoring Category

* Refactoring Category

* Description and thumbnail issue fixed

* Description and thumbnail issue fixed

* Minor issue fixed

* Minor issue fixed

* Server changed

* Logo changed

* Change in structure

* Fixed failed tests

* Fixed Test failed

* Optimized imports

* Dialog can't be dismissed

* Dialog can't be dismissed

* Resolved Conflicts

* UI fixed

* Added description and thumbnail in local DB

* Added description and thumbnail in local DB

* Test fixed

* Added

* Updated with latest master

* Test Updated with latest master

* Issue fixed

* Revert gradle changes

* Revert gradle changes

* Update gradle-wrapper.properties

* Require Api removed
2022-01-20 15:19:57 +09:00
Ayan Sarkar
0914eeea53
Fixed #4532 Items media in beta version are showing now (#4551)
* logs

* Issue resolved

* Logs removed

* Beta working

* Production GET call only for fetch images from depicted item

* Code convention maintained

* Code convention maintained

* Test resolved

* Java Docs added

* Quotes added
2022-01-19 18:10:55 +03:00
Pratham Pahariya
7bcaab2442
Fixes #53 - Suggest depicted country based on EXIF latitude/longitude (#4756)
* Fix - Suggest depicted country based on EXIF latitude/longitude

* Added null check and moved country suggestion to the end of the list
2022-01-19 20:28:38 +09:00
Pratham Pahariya
35e9a2c267
added feature thumbnail recyclerview moves corresponding to the current picture (#4748)
Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2022-01-06 21:48:09 +09:00
Pratham Pahariya
06a347eee1
Fixes #4543 - Language selection: Search (#4744)
* initial changes

* add search feature for selecting language

* add search feature for selecting language

* upload issue fix

* minor improvement

* added test and updated settings language selection ui

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-12-31 19:33:36 +09:00
Ayan Sarkar
38ed364423
Added bookmark Wikidata items option (#4515)
* classes

* Almost done

* All done but build fail

* All done but build fail

* Modifications

* Modifications

* Fixed

* string resource

* minor change

* Maintained code conventions

* Moving

* Exception handled

* id name changed

* Test fail fixed

* Bookmark is available from other activities

* Test fail fixed

* Documentation error fixed

* Test added

* Revert Project_Default.xml

* Minor Change

* Revert changes
2021-12-28 20:15:09 +09:00
Pratham Pahariya
8a0d5580b2
Fixes #4571 - Nearby: Save last known location and show it immediately without waiting for GPS (#4721)
* save last location feature

* fix lat lng exchange

* removed unnecessary space

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-12-23 17:17:30 +09:00
Ayan Sarkar
8a2c30120d
Fixed 4728 : Suggest User to turn on camera location (#4735)
* Dialog can't be dismissed

* Dialog can't be dismissed

* Suggest users to turn on camera location

* Added safety pattern

* Title removed

* Changed constant
2021-12-22 22:15:58 +09:00
Pratham Pahariya
d8bfd1ffc5
fix achievement zero issue (#4737)
Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-12-22 17:51:43 +09:00
KhyatiSaini
d38c3f1427
unformatted search text field for depicts and categories search field of upload wizard (#4724)
* unformatted search text field for depicts and categories search field of upload wizard

* fix tests by declaring search text field of type PasteSensitiveTextInputEditText
2021-12-17 14:02:58 +03:00
Ashish
a0ff15cdc2
Added advanced query support in Nearby (#4714)
* Added feature for advanced query options in Nearby

* Fix unit-tests coverage

* wip-tests

* Added log to identify if the nearby request is via an advanced query

* Rolledback test-dependency updates

* Fix tests

* build fix

* Added basic tests for relevant method in OkHttpJsonApiClient & NearbyController

* Added NearbyParentFragmentPresenter Tests

* Added AdvancedQueryFragment Unit Tests

* Added more tests for NearbyParentFragmentPresenter

* Reset ContributionsFragment with Upstream

* Overload method loadNearbyPlaces for CustomQuery

* Added more tests

* Added more tests

* Fixed tests for NearbyParentFragmentPresenter
2021-12-14 01:41:33 +10:00
Pratham Pahariya
bd00ce2071
fix-issue-4215 (#4729)
Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-12-13 17:44:14 +05:30
Ayan Sarkar
bf74da7b5d
Fixed 4718 : After uploading by sharing an image from gallery the app returns to contributions tab (#4727)
* Dialog can't be dismissed

* Dialog can't be dismissed

* UploadActivity returns to MainActivity
2021-12-12 21:23:30 +09:00
Prince kushwaha
b7be49333d
rename toolbar name Favorites to Bookmarks (#4717)
* rename toolbar name Favorites to Bookmarks

* fix issue

* fix string.xml file
2021-12-10 15:35:44 +03:00
Ayan Sarkar
674b033d32
"Starting uploads" notification is cleaned up when "Finishing uploads" notification pops up (#4719)
* Dialog can't be dismissed

* Dialog can't be dismissed

* Cleaned up "starting upload" notification before finishing starts
2021-12-10 02:56:55 +03:00
Paul Hawke
8c573eda26
Moved the PagedSearchCategoriesAdapter to use view binding (#4702) 2021-12-09 17:28:45 +03:00
Ayan Sarkar
dcbf57f712
Fixed 4703: Next button is not clickable while background task is going on (#4705)
* Dialog can't be dismissed

* Dialog can't be dismissed

* Dialog can't be dismissed
2021-12-09 17:24:28 +03:00
Ashish
b373617a68
Fixes #4682 - Removed read_phone_state_permission (#4723) 2021-12-09 15:42:08 +03:00
Madhur Gupta
d1bf6d0e1d
Add CommonPlaceClickActions Unit Tests (#4674) 2021-12-06 23:28:58 +03:00
Ayan Sarkar
0269894c64
Fix 4615: Option for editing caption and description (#4672)
* DescriptionEditHelper implemented

* Description extracted

* Description editable

* No description condition handled

* Code cleanup

* Added javadocs

* toolbar added

* API call done

* Caption edit available

* Progress dialog added

* Log

* Problem with ButterKnife

* Caption is editable

* Removed unused import

* Manifest file reverted

* Manifest file reverted

* Manifest file reverted

* View binding added

* Post operation test added

* Java docs added

* Java docs added

* MediaDetailFragment unit tests added

* Test added
2021-12-06 22:50:54 +03:00
dado1111
e910b1d14f
Pasted text should have fonts unified (for Caption/Description) (#4667)
* Changed hardcoded "More" to getStrings(R.string.more) for Unlogged user
- MainActivity toolbar showed "More" when clicked on More options
   in other language than English

* Changed hardcoded "More" to getStrings(R.string.more) for Logged user
- MainActivity toolbar showed "More" when clicked on More options
   in other language than English

* Added test for: MainActivity.setUpPager

* Pasted text is now unformatted for caption and description

* Removed other branch contribution

* Added test

* Rename .java to .kt

* Test from Java to Kotlin; +small fix

* PasteSensitiveTextInputEditTextTest - updated
2021-12-06 21:59:44 +03:00
Shreyas Bansode
ad0aa7d4ea
Tap to view fails issue resolved (#4656)
* upload fail tap to view fixed

* clean code

* added function documentation

* requested changes
2021-12-06 21:22:13 +03:00
Wojuola Ayotola
e297f6c240
**Increased number of leaderboard records fetched in a single request from API** (#4697)
Fixes #4372

What changes did you make and why?
Increased number of leaderboard records fetched in a single request from API

**Tests performed (required)**

Tested ProdDebug on Pixel 4 XL with API level 31.
2021-11-06 19:42:19 +05:30
Madhur Gupta
5535353480
Add RecentSearchesFragment Unit Tests (#4675) 2021-11-06 12:57:23 +03:00
Paul Hawke
462a2ac007
Converted the DepictionAdapter to use ViewBinding (#4689) 2021-11-06 12:51:13 +03:00
Ashish
b4bfc6c5a3
Fixes #4447 1. Updated SDK version to 30 2. Updated WorkManager's version (#4677) (#4692) 2021-10-28 16:12:25 +10:00
KasinaDheeraj
ce8d10ea8f
fix: Cleanup of unnecessary empty file (#4691) 2021-10-27 20:01:41 +05:30
codingtosh
55c0b07ebf
[Contributions-Tab] Scroll to top on NavBar Button Pressed (#4668)
* [Contributions-Tab] Scroll to top on NavBar Button Pressed

On NavBar Contributions Button pressed, if already on the Contributions tab,
scroll to the top of the recyclerView in ContributionsListFragment.

* [UnitTest][Contributions-Tab] Scroll to Top on NavBar Button Pressed
2021-10-27 19:56:16 +05:30
Ashish
88b21a678e
Fixes #3389 - Show User profiles (#4678)
* Fixes #3389 - Show  User profiles

* Don't show dummy achievements data - show data only when loaded
2021-10-25 23:40:08 +03:00
Madhur Gupta
7ce80aa804
Add DepictsFragment Unit Tests and update tests dependencies (#4688)
* Add DepictsFragment Unit Tests and update tests dependencies

* Attempt to fix CI
2021-10-25 23:31:59 +03:00
Paul Hawke
3dcd271980
Swapped over to the ViewBinding version of adapterdelegates4 (#4687) 2021-10-25 23:08:55 +03:00
Paul Hawke
3e656b0c23
Converted the WikipediaInstructionsDialogFragment to use viewbinding, along with a cleaner way to build bundle arguments for the fragment (#4684) 2021-10-22 14:16:46 +03:00
Madhur Gupta
6da3c78d7d
Add view binding dependency and example (#4681)
* Add view binding dependency and example

* Add comments

* Minor change in a comment
2021-10-21 14:57:35 +03:00
dado1111
6649da88a5
Clicking "More" on tabLayout caused it to be displayed on toolbar (in any other language than English) (#4666)
* Changed hardcoded "More" to getStrings(R.string.more) for Unlogged user
- MainActivity toolbar showed "More" when clicked on More options
   in other language than English

* Changed hardcoded "More" to getStrings(R.string.more) for Logged user
- MainActivity toolbar showed "More" when clicked on More options
   in other language than English

* Added test for: MainActivity.setUpPager
2021-10-17 13:54:18 +05:30
Ayan Sarkar
6978d00926
Fix 4511 Update Nearby list according to chip state (#4605)
* Exists and Need Photo list updated

* WLM filter added

* Minor bug fix nad code convention

* Code clean up

* Renamed NeedsPhoto and isExists
2021-10-15 18:53:35 +03:00
Jose Mora
a687046c02
fixed issue #4500 coordinate edit button should be hidden if login skipped (#4662) 2021-10-07 12:54:39 +03:00
jeremybowenn
07bf708fa6
Disabling the managed exifs tab if the user isn't logged in (#4579) 2021-09-29 18:24:43 +03:00
pratik2315
dff6268a55
Added multi-file picker functionality for the WLM (#4637)
* Added multi-file picker functionality for the WLM

* Added multi-file picker functionality for the WLM

* Added multi-file picker functionality for the WLM

* Added multi-file picker functionality for the WLM
2021-09-23 19:27:44 +05:30
Jose Mora
b9273b063c
fixed issue #4590 fab of custom selector is still open after uploading (#4628) 2021-09-20 17:35:36 +03:00
Madhur Gupta
388e8286bc
Add LeaderboardFragment Unit Tests (#4635)
* Add LeaderboardFragment Unit Tests

* Add LeaderboardListAdapter Unit Tests
2021-09-20 17:01:54 +10:00
Madhur Gupta
07d170a79c
Add MediaDetailFragment Unit Tests (#4632)
* Add MediaDetailFragment Unit Tests

* Add ZoomableActivity Unit Tests
2021-09-20 17:00:27 +10:00
Ashish
7476b0a24d
Merge changes from 3.1-release (#4629)
* Cherry-Picked NPE fix from master (#4569)

* Fix notification bug #4547 (#4570)

* Make Single Query for Nearby and WLM pins (#4573)

* Merge nearby and monument queries

* Bug Fix- query resource path change on shouldQueryForMonuments

* Bug Fixes
1. Propagate exceptions for nearby API calls to caller
2. Fix too much work on main thread exception in NearbyParentFragment

* Modify parameters for Nearby query

* Bug fix- current location marker (#4580)

* Move WLM template below geolocation template (#4582)

* Modify string for WLM upload notice

* Fix bug #4583 (#4591)

* Fix bug #4585 by updating kotlin and acra version (#4592)

* Fixes #4554 - only use WLM2021 template for countries that are included in it (#4574)

* Fixes #4554
1. For WLM uploads reverse geo code and see if the country code is supported -only then is the WLM upload flow triggered, otherwise usual nearby uploads happen
2. Bug Fix - Current Location marker and area

* Fixed compile error added after rebasing

* Bug fix for country code in reverse geo code

* Update WLM camaign dates [Do not merge now, merge only after alpha release] (#4584)

* Updates dates for WML campaign

* Bug fix- campaign dates

* Fixed logic for WLM enablement - stick to the month of September

* Add countries supported by WLM2021 template, except Italy

* Versioning for v3.1.0

* Update changelog.md

* Fix empty default lang bug (#4608)

* Fix bug #4583

* Fix empty default lang bug

* Fixes #4595 - Updated nearby query (#4622)

* Fixes #4595 - Updated nearby query

* Removed logic to replace local language in nearby query - that might acccidentally replace other strings

* Fetch property location in usual nearby query

* Remove duplicate line (#4626)

* Change "learn more" link to new wiki

* Add Sweden's P3426 to property filter

* Fixes #4601 - 1. Handle possible exceptions in upload file from stash 2. Modify MWException, as error is nullable, update getTitle and getMessage to rever that (#4627)

* Versioning for v3.1.1

* Update changelog.md

* Updated DB version to rever integrity

Co-authored-by: Madhur Gupta <30932899+madhurgupta10@users.noreply.github.com>
Co-authored-by: Josephine Lim <josephinelim86@gmail.com>
2021-09-16 23:09:29 +10:00