Commit graph

2671 commits

Author SHA1 Message Date
Lawal abiola
751bc6ce6b
fix: thumbnail of rotated image not visible during upload (#5552)
[The image path of rotated image is not save like nornal image.
so imageview cannot load rotated image

check whether the image path is file uri then add imagerequest to load the image]

[fixed: thumbnail not visible when upload rotated image]
2024-03-22 22:51:31 +09:00
Shashank Kumar
2d333a2af0
Custom picker: Show differently pictures that are currently being uploaded (#5618)
* Custom picker: Show differently pictures that are currently being uploaded

* fix tests

* fix test

* fix crash

* handle all cases

* handle all cases

* fix

* Hide Images When showAlreadyActioned is disabled

* Fix Tests

* cleanup
2024-03-22 22:13:19 +09:00
Shashank Kumar
2a6ab66c11
Precise error message password change (#5544)
* Precise Error Message and Action When Password is Changed

* Make message persistent

* code cleanup and fixes

* removed unnecessary string resource

* removed unnecessary string resource

* fix

* fix

* Upload Client to kotlin

* Remove Redundant Code

* Remove Redundant Code

* code cleanup and Improvements

* Improved Java doc

* Improved Java doc

* Improved Javadoc
2024-03-21 23:21:53 +05:30
Kanahia
152e824aa6
Fixed reproducible crash when marking last pictures as "not for upload" (#5635)
* Fixes #5634

* Delete app/src/main/res/values-yue-hant directory
2024-03-21 22:51:33 +09:00
Kanahia
d112be04db
Removed MapBox related imports (#5631)
* Fixed Grey empty screen at Upload wizard caption step after denying files permission

* Empty commit

* Fixed loop issue

* Created docs for earlier commits

* Fixed javadoc

* Fixed spaces

* Added added basic features to OSM Maps

* Added search location feature

* Added filter to Open Street Maps

* Fixed chipGroup in Open Street Maps

* Removed mapBox code

* Removed mapBox's code

* Reformat code

* Reformatted code

* Removed rotation feature to map

* Removed rotation files and Fixed Marker click problem

* Ignored failing tests

* Added voice input feature

* Fixed test cases

* Changed caption and description text

* Replaced mapbox to osmdroid in upload activity

* Fixed Unit Tests

* Made selected marker to be fixed on map

* Changed color of map marker

* Fixes #5439 by capitalizing first letter of voice input

* Removed mapbox code1

* Removed mapbox code2

* Fixed failing tests

* Fixed failing due to merging
2024-03-21 22:43:22 +09:00
Shashank Kumar
7e9aa5b72a
Migrated Media Package to View Binding (#5601)
* Migrated Media Detail Fragment to View Binding
* Migrated ZoomableActivity and PagerFragment
* Improved Java doc
* Improved Java doc
2024-03-20 20:29:07 -05:00
Shashank Kumar
8df0055a5a
Migrated CategoryDetailsActivity , MainActivity to View Binding (#5595)
* Butterknife to ViewBinding
* code fix to pass all tests
2024-03-19 19:21:51 -05:00
Shashwat Kedia
bd06a74caa
#4664 Moved Settings Activity to ViewBinding (#5506)
* Moved Main Activity and Settings Activity to ViewBinding
* Moving only SettingsActivity for now
* Removed values-yue-hant directory
* Removing previously done changes to main.xml
2024-03-17 09:03:21 -05:00
Shashank Kumar
fec6dba341
Fix Crash in LocationPickerActivity when device configuration is changed (#5500)
* Fix Crash in LocationPickerActivity when device configuration is changed (UI Modes)

* clean up

* fix

* fix

* fix

* fix

* removed faulty test

* cleanup

* fix and tests added
2024-03-17 22:46:13 +09:00
Shashank Kumar
161e2edc31
Migrated Bookmarks Package From Butterknife to ViewBinding (#5594)
* Butterknife to ViewBinding
* code fix to pass all tests
* code cleanup & binding added to tests
2024-03-17 08:01:55 -05:00
Shashank Kumar
3e5424e18d
Fix Custom image selector (#5576)
* Custom Image Selector Fix

* Custom Image Selector Fix

* code cleanup

* fixes

* Renamed yue-hant

* added java docs

* fix
2024-03-16 22:15:21 +09:00
Shashank Kumar
f73c9dc4d3
Migrate Upload Package To View Binding from Butterknife (#5590)
* Butterknife to ViewBinding
* Butterknife to ViewBinding
* code cleanup and tests fixed
* code cleanup and optimised imports
2024-03-15 14:37:28 -05:00
Shashank Kumar
c94f607107
Migrated Contributions Package From Butterknife to ViewBinding (#5593)
* Butterknife to ViewBinding
* code fix to pass all tests
* test fix
* test fix
* test fix
* test fix
* Update ContributionsFragmentUnitTests.kt
* code cleanup and tests improved
* tests fixed
* adjustments and code cleanup
* adjustments and code cleanup
2024-03-12 21:16:55 -05:00
Shashank Kumar
2076bf9b29
Migrated Explore Package From Butterknife to ViewBinding (#5592)
* Butterknife to ViewBinding
* code cleanup and tests migrated to binding
* tests fixed
* adjustments and code cleanup
2024-03-11 15:48:37 -05:00
Shashank Kumar
6ed5deac65
Migrated Profile Package from Butterknife to View Binding (#5591)
* Butterknife to ViewBinding
* code fix to pass all tests
* code cleanup and tests migrated to binding
* fix LoD
2024-03-10 14:44:06 -05:00
Neel Doshi
dbe739e755
CodeCleanup : Removed Unused Import from packages. (#5609)
* CodeCleanup : Removed Unused Import from packages.

* Removed : value-yue-hant directory.
2024-03-08 23:21:27 +09:00
Neel Doshi
28ea11127c
Refactor : API calls moved out of the LoginActivity (#5599)
* Refactor :API calls separated from activity added to LoginClient
* getLoginToken() modifier set to private
* Code Cleanup : removed non-null from twofactor and Locale import
* Indentation fix
2024-03-06 08:35:50 -06:00
Shashank Kumar
f5a5159f8c
Fix Crash Edit Categories Fragment (#5510)
* fix crash

* Tests Added

* Tests and Null Checks Added
2024-02-26 18:42:51 +09:00
Ivan C. Acha
535792390e
Changed line break behaviour. (#5562)
Added line breaks to PageContentsCreator.java, CategoryEditHelperUnitTests.kt, and MediaDetailFragmentUnitTests.kt following the example given on issue #5523.
2024-02-25 23:00:45 +09:00
Paul Hawke
f0a1d036a5
Convert upload client to kotlin (#5568)
* Write unit tests for the UploadClient (with gentle refactoring to make it testable)

* Convert Upload client to kotlin
2024-02-21 15:55:35 +09:00
Paul Hawke
728712c4e1
Convert API clients to kotlin (#5567)
* Convert UserClient to kotlin

* Added tests for WikiBaseClient

* Removed superfluous dao tests in review helper and got the proper ReviewDaoTest running in the unit test suite

* Improved tests for ReviewHelper

* Convert the ReviewHelper to kotlin

* Convert the WikiBaseClient to kotlin

* Convert the WikidataClient to kotlin
2024-02-20 09:23:11 +09:00
Rohit Verma
9a8b89c19a
nearby: Show 'no images in this area' message instead of generic error (#5541) 2024-02-18 15:02:19 +00:00
Kanahia
26658e91b3
Removed MAPBOX Access token (#5555)
* Update gradle.properties

* Update build.gradle

* Update CommonsApplication.java

* Update LocationServiceManager.java
2024-02-16 20:56:58 +09:00
Shashank Kumar
4c5d690a9e
Fix Crash When Explore Tab is Clicked (#5550) 2024-02-15 22:54:10 +09:00
Kwong Yu Zhou
013bc7db39
Replaced campaignPreference with CAMPAIGNS_DEFAULT_PREFERENCE (#5357)
Co-authored-by: Kwong Yu Zhou <https://github.com/kwong-yu-zhou>
Co-authored-by: Adam Jones <domdomegg+git@gmail.com>
2024-02-14 21:23:23 +00:00
Shashank Kumar
2d5b7cc579
Fix DNG/RAW Upload Error (#5543)
* Fix DNG/RAW Upload Error

* Fix DNG/RAW Upload Error

* supported formats added

* cleanup
2024-02-14 21:09:48 +09:00
Adam Jones
1cbce77d5f
Migrate from Kotlin synthetics to Jetpack view binding (#5546) 2024-02-14 18:29:06 +09:00
Shashwat Kedia
b18117bc07
Resolved Problems in UploadMediaDetails flow and UX #5511 (#5527)
* Fixed arrow flickering issue on zoom

* Resolved issue point 1 and 3

* Resolved issue point 2

* Minor changes

* Update UploadActivity.java

---------

Co-authored-by: Nicolas Raoul <nicolas.raoul@gmail.com>
2024-02-14 18:07:51 +09:00
Shashank Kumar
a308a1c8b5
Fix Methods Usage Incompatible with Android API Level 21 (#5525) 2024-02-14 09:05:13 +00:00
Shashank Kumar
8df7f66992
Show Labels For FAB in Contribution Page (#5493) 2024-02-13 21:33:03 +00:00
Shashank Kumar
1895bb3ec2
Fix - Unable to Access Privacy Policy (#5534)
* Fix - Unable to Access Privacy Policy

* cleanup
2024-02-11 21:11:20 +09:00
Paul Hawke
f9090b0c2c
Consistent api interfaces (#5530)
* Converted CategoryInterface to kotlin

* Converted DepictsInterface to kotlin

* Convert the MediaDetailInterface to kotlin

* Convert MediaInterface to kotlin

* Convert ReviewInterface to kotlin

* Convert the UserInterface to kotlin

* Convert the WikiBaseInterface to kotlin

* Convert WikidataInterface to kotlin

* Convert WikidataMediaInterface to kotlin

* Convert UploadInterface to kotlin
2024-02-09 13:43:01 +09:00
Paul Hawke
c6cb97e199
Add ability to suppress logging of known unsuccessful API calls (#5526) 2024-02-09 06:55:56 +09:00
Paul Hawke
0c3085257d
Data client simplification / removal (#5507)
* Removed unused code from the data client module

* Move remaining code out of the data-client and remove it
2024-02-03 10:26:06 +09:00
Shashank Kumar
72a6fd2c90
Enhancement - Nearby banner shows Item without image (#5468)
* Enhancement Nearby banner shows Item without image

* spacing

* Enhancement Nearby banner shows Item without image

* spacing

* Fix Crash

* Reverted "Fix Crash"

This reverts commit a41c9362bb.

* Fixed

* Fix null location

* Fix Conflict

* Show Only Items that exists

---------

Co-authored-by: shashankkumar <shashankkumar45556@gmail.com>
Co-authored-by: Nicolas Raoul <nicolas.raoul@gmail.com>
2024-02-01 22:17:52 +09:00
Paul Hawke
8db0b54929
Remove the data-client app adapter implementation (#5499)
* logErrorsInsteadOfCrashing only ever returned false, so remove it and simplify logger

* Removed unused getMediaWikiBaseUrl()

* Removed getDesiredLeadImageDp() from commons app adapter, since it's unused

* Inlined the isLoggedIn() method of the app adapter

* Inline the app adapter username/password

* Removed the unused getRestbaseUriFormat() from the commons app adapter

* Remove references to the data-client SharedPreferenceCookieManager

* Manage our own OkHttpClient and remove the AppAdapter implementation
2024-01-31 10:21:43 +09:00
Paul Hawke
ab9e57f5be
Decouple from the data-client service factory, with some code cleanup in the process (#5496) 2024-01-30 07:46:01 +09:00
Shashank Kumar
8bafee3801
Enhancement-Show Icon Labels When Long Pressed (#5492)
* Enhancement-Show Icon Labels when Long Pressed

* Tests Added
2024-01-29 17:05:43 +09:00
Nicolas Raoul
a8545abff2 Merge remote-tracking branch 'origin/switch-to-commons-toolforge' 2024-01-29 15:35:33 +09:00
Rohit Verma
9f7e407181
DepictsFragment: add null check for media (#5488) 2024-01-29 15:33:36 +09:00
Paul Hawke
84ffffbbe7
Create CsrfTokenClient and LoginClient by injection, along with a little cleanup (#5491) 2024-01-29 12:36:57 +09:00
Shashwat Kedia
5661e8c332
Fixed flickering of nearby banner compass (#5486) 2024-01-29 09:02:30 +09:00
Kaartic Sivaraam
611f40801e Switch to using the commons toolforge instance fully
So far we used both the urbanecmbot instances and also the commons-android-app
toolforge instance for the functioning of the app.

The reality is that the commons-android-app instance itself had the ability
to return all the data necessary for the app. Use the same to get all the
data necessary for the app.

Fixes #5462
2024-01-28 14:27:13 +05:30
Paul Hawke
9e970123fd
Removed references to the data-client Service interface (#5484) 2024-01-28 08:25:56 +09:00
Shashwat Kedia
8222c4a42c
Resolves Issue #5413 Crash when opening Nearby when location permission hasn't been granted yet (#5418)
* Resolves Issue #5413

* Added Javadoc and formatted code
2024-01-27 22:47:36 +09:00
Kanahia
71de19f27b
Fixed javadoc issue (#5481) 2024-01-27 22:40:18 +09:00
Kanahia
96b2608eb1
Replace Mapbox with OSMDroid (Explore Activity) (#5475)
* Fixed Grey empty screen at Upload wizard caption step after denying files permission

* Empty commit

* Fixed loop issue

* Created docs for earlier commits

* Fixed javadoc

* Fixed spaces

* Added added basic features to OSM Maps

* Added search location feature

* Added filter to Open Street Maps

* Fixed chipGroup in Open Street Maps

* Removed mapBox code

* Removed mapBox's code

* Reformat code

* Reformatted code

* Removed rotation feature to map

* Removed rotation files and Fixed Marker click problem

* Ignored failing tests

* Added voice input feature

* Fixed test cases

* Changed caption and description text

* Replaced mapbox to osmdroid in upload activity

* Fixed Unit Tests

* Made selected marker to be fixed on map

* Changed color of map marker

* Fixes #5439 by capitalizing first letter of voice input

* Made UI changes in UploadMediaDetailAdapter

* Added javadoc

* Replaced Mapbox with OSMDroid in explore activity

---------

Co-authored-by: Nicolas Raoul <nicolas.raoul@gmail.com>
2024-01-27 21:39:08 +09:00
Paul Hawke
02ce017c98
Convert the LoginClient to kotlin (#5479)
* Convert the result classes to kotlin

* Convert response and callback to kotlin

* Cleanup code-quality warnings before converting

* Converted the LoginClient to kotlin

* Updated the UserExtendedInfoClientTest to be kotlin, and live in the correct spot
2024-01-27 12:39:00 +09:00
Paul Hawke
0541aacdff
Move login client out of the data-client (#5476) 2024-01-26 23:11:44 +09:00
Shashank Kumar
8789879f10
Fix Multi-Upload Wizard only asks Metadata for one picture (#5478)
* Fix Multi-Upload Wizard only asks Metadata for one picture

* javadoc

* typo

---------

Co-authored-by: shashankkumar <shashankkumar45556@gmail.com>
Co-authored-by: Nicolas Raoul <nicolas.raoul@gmail.com>
2024-01-26 22:43:07 +09:00