* Added permission for Dexter, the runtime permission handling library
* [Preparing fir issue #1773] Added a utility function which would take the user to app settings screen where he could manually give us the required permission
* Added an alert dialog with positive and negative callback [Preparing fir issue #1773]
* Improvements in the way External Storage Permission is handled in MultipleShareActivity[Bug fix#1697]
1. Used dexter to handle the external storage permission
2. Behaviour changes : When user tries to share(uppload) images to commons via MultipleShareActivity, following decision tree is followed
a. If the app has permission for external storage, normal upload operation is followed
b. If the app does not has the permission for external storage, dexter is used to ask for the same
c. If the user gives us the required permission, normal upload flow is proceeded
d. If the doesnot gives us the required permission a rationale dialog is shown with the appropriate message to let him know why we need the permission
e. If he presses okay, steps a-c are followed and if he presses cancel, we close the app.
f. If while asking for permission, the user chooses never ask again, then next time he tries to upload an image via MSA, the rational dialog follows the app setting screen where he could manually give us the required permission and the onActivityResult of same is handled
* Added a Constants class to handle request and result codes from one place and other related constants common to the all app elements
* replaced hardcoded strings ok and cancel in DialogUtil to string resources
* init permission rationale dialog in activities onCreate
* Code formatting, updated access modifiers wherever required, added javadocs for new methods created
* *shifted constants to app class
*Added JavaDocs in PermissionUtils
* removed class REQUEST_CODES from CommonsApplication and instead put the enclosing constants in the App class itself
* Eliminate the use of Picasso.
This gets rid of the single use of the Picasso library (which was causing
the whole library to be imported and shipped) and replaces it with Glide.
TODO: replace this and the other instance(s) of Glide usage with Fresco,
or vice versa.
* Remove dependency on Glide.
This removes the dependency on Glide, as well as the SVG rendering
library, whose only purpose was to display a single SVG image in the
Notification activity. Unfortunately Android doesn't support SVG natively,
but Echo notifications have icons that are SVG formatted. Rather than
import a bunch of heavy libraries to support this single case of SVG
rendering, we can simply create a few local drawables that correspond to
the different types of notifications, and use them instead.
* Remove multidex!
Multidex is a killer of performance and should be avoided at all costs.
* Remove further unused bits.
* Remove final vestige of multidex.
* Create utility class for contribution process
* implement method to save five from given URİ
* Add file utilities for directory checks
* Add ContributionUtils for saving file during upload
* Change method call acordingly with handleImagePicked() method
* Call method to save file temproarily when a photo to upload is chosen from contributions list.
* Call method to save file temproarily when a photo to upload is chosen from nearby list and map
* Arrange method call
* Write a method to save file temporarily during upload process. It will save the file to a internal path and it will be deleted by another method after upload process is done.
* Add a method to save a file to a given path from a content provider Uri
* On openAssetFileDescriptor method, use URi from temporarily saved file, instead of Contributions.getLocalUri which was Uri from content provider
* Edit uploadContribution method so that it will use FileInputStream from temporarily saved file, insdeat of the Uri from content provider.
* Make it work
* Code cleanup
* Add directory cleaner method
* Call temp directory cleaner method at the end of uplpoad process
* Use FileInputStream insted
* Add directory cleaner method
* Add file removal method
* Use external directory instead
* Make destination file name flexible
* Make it work with share action coming from another activity
* Make it work for Multiple hare Activity
* Code cleanup
* Solve camera issue
* Fix camera crash
* Cleanup
* Revert change of commenting out posibly useles code, because I am not sure if it is useless or not. Requires discussion
* Use timestamp in temoorary file names, so that we wont never create same file and access old file reference. It was a weird problem though
* Code cleanup
* Add nullable annotation to handleImagePicked method uri parameter
* Add Nullable anotation to method
* Code cleanup
* Bugfix: use uri.getPath() instead uri.toString
* Remove unecesarry file saving operation, which was added accidentally
* Fix travis fail
* Remove temp file if upload gets failed and file is still there
* Code cleanup:Remove unused parameters from removeTempFile method
* Empty temp directory on app create, in case some of files are still there
* Add null check to array to prevent NPE on first run
* Fix multiple uploads bug
* Remove file if upload is succeed
* Add external storage utility methods
* Check external file permission before saving files temporarily
* finish activity if permission is not granted
* Add log lines
* Remove files even if user decides to go back without sharing
* Add easy null check
* Change storage permission settings in singe upload fragment too
* Finish app if permission is not granted
* Code optimisation
* Remove temp file if upload process never is finalised on activity stop
* Bugfix maybe contribution is never created
* Fix travis build
Adding link to local description page:
(Upload log) !; 15:02 . . Malabarge (talk | contribs | block) uploaded File:Spiegelung 3.jpg (Uploaded using Android Commons app) (Tags: Mobile app edit, Mobile edit)
Using the same edit summary as for edits made using the app, e.g.
(diff | hist) . . ! File:Lul.jpg; 14:48 . . (-20) . . Codedoper (talk | contribs | block) (Added 1 categories. Removed template Uncategorized. Via Commons Mobile App) (Tags: Mobile app edit, Mobile edit)
These are especially old bits of code, where it seems like WMF folks had set up Eventlogging schemas for some rudimentary analytics of the Commons app. These schemas are no longer queried or monitored, and can be safely removed. When the Commons app has a stronger need for more meaningful analytics, we can revisit reintroducing new and better schemas.
