Commit graph

728 commits

Author SHA1 Message Date
Mikel
65ddc1a4bb Add Nullable annotations to reduce risk of NPE 2017-07-15 18:41:10 +02:00
Mikel
9d23907728 Fix Issue with repeating categories in MediaDetail 2017-07-15 18:16:45 +02:00
Mikel
7667180bc5 Make uploaded image's coordinates clickable 2017-07-15 17:53:37 +02:00
Mikel
1044fe13ae Make license in MediaDetail clickable 2017-07-15 09:21:35 +02:00
Josephine Lim
0da51457d0 Merge pull request #771 from tised/#739_issue
fix for #739
2017-07-14 02:17:48 +10:00
Josephine Lim
2e388c0d5e Merge pull request #772 from tised/#708_issue
fix for #708
2017-07-14 01:12:52 +10:00
Josephine Lim
350f9bb697 Merge pull request #773 from tised/#657_issue
improvements for #657 issue
2017-07-14 01:10:34 +10:00
Dmytro Vodnik
0ce99bc10e improvements for #657 issue 2017-07-13 16:26:07 +03:00
Yusuke Matsubara
d241d36d66 Add PageTitle class to canonicalize page names 2017-07-13 18:29:30 +09:00
Dmytro Vodnik
397b4fa586 fix for #708 2017-07-13 12:23:15 +03:00
Dmytro Vodnik
719b30be85 fix for #739 2017-07-13 12:04:51 +03:00
Josephine Lim
691acbf983 Merge pull request #768 from tised/#733_#732_fix
fix for #733,732 issue
2017-07-11 16:30:10 +10:00
Dmytro Vodnik
869790900b fix for #733,732 issue
The problem is that onCreate of content resolver are calling before even Apllication onCreate, so that fields may be null which caused crashes
2017-07-10 17:31:32 +03:00
Paul Hawke
9387d31cb6 Improvements based on codacy-bot feedback. 2017-07-09 17:52:50 -05:00
Paul Hawke
6ccc608a1e Converted nearby list to recycler view and fixed a few issues pointed out by static code analysis. 2017-07-09 17:33:24 -05:00
veyndan
3509b0a413 Remove redundant call to method 2017-06-30 20:19:25 +01:00
Yusuke Matsubara
b83c32f81e Merge pull request #742 from veyndan/place
Use an enum for the place description
2017-06-30 16:46:26 +09:00
veyndan
5d6bada4c8 Use an enum for the place description 2017-06-29 15:11:24 +01:00
veyndan
ae78930808 Make the drawer prettier 2017-06-28 21:39:10 +01:00
Yusuke Matsubara
f8bb106b83 Merge pull request #745 from veyndan/string-sanitation
Simplify string sanitation logic
2017-06-28 09:15:10 +09:00
Yusuke Matsubara
63496e48d4 Merge pull request #744 from veyndan/builder
Prevent instantiation of a class with a builder
2017-06-25 17:35:02 +09:00
Vanethos
e18c628a04 Remove button (#718)
* Changed the "Use previous title/description" button so that it does not delete the title and description edit text fields if there is no previous data. https://github.com/commons-app/apps-android-commons/issues/503

* Changed the "Use previous title/description" button so that it does not delete the title and description edit text fields if there is no previous data.

* Changed the "Use previous title/description" button so that it does not delete the title and description edit text fields if there is no previous data.

* Split the if statement in two lines

* Move && to the beginning of the line

* Restore order of titleEdit and descEdit
2017-06-24 21:44:10 +10:00
veyndan
8c3adbbb97 Simplify string sanitation logic 2017-06-19 17:02:16 +01:00
veyndan
dc01dfa014 Prevent instantiation of a class with a builder 2017-06-19 16:23:09 +01:00
Yusuke Matsubara
fd11c872b9 Fix coding style issues 2017-06-10 17:46:38 +09:00
Yusuke Matsubara
9c69539276 Share file with camera using cache and FileProvider
* Use cache instead of external storage to share file with camera
* Execute ExistingFileAsync after permission is granted
2017-06-10 16:47:37 +09:00
misaochan
7d5469dcfa Add null check for nearbyAsyncTask 2017-06-03 12:40:27 +10:00
misaochan
8e059691f9 Tidy up code 2017-06-02 18:27:39 +10:00
misaochan
6091cc7465 Remove addToBackStack
We do not actually want users to go back to this fragment
2017-06-02 18:26:05 +10:00
misaochan
a8d302bdf3 Remove progress bar and add null check for locationManager 2017-06-02 18:17:23 +10:00
misaochan
c3d4b029c1 Fill out onCreateView in fragment 2017-06-02 18:17:10 +10:00
misaochan
c8a0142c3e Cancel AsyncTask and add backstack 2017-06-02 18:08:34 +10:00
misaochan
18bb59403b Add NoPermissionsFragment 2017-06-02 01:30:13 +10:00
misaochan
2e72b29fba Add TODO and fragment transaction 2017-06-02 01:25:17 +10:00
misaochan
9895093b8f Add @NonNull annotations 2017-06-01 22:15:17 +10:00
misaochan
e6e141e51d Fix whitespace 2017-05-31 19:53:23 +10:00
misaochan
cab0d24692 Add null check to onPause asynctask 2017-05-31 19:50:45 +10:00
misaochan
ec6ba8cf87 Remove hardcoded string 2017-05-31 19:49:19 +10:00
misaochan
93acd40926 Move code into startLookingForNearby() 2017-05-31 19:47:09 +10:00
misaochan
a704f5a740 Register locationManager if permission granted 2017-05-31 19:43:51 +10:00
misaochan
50ecf4fd15 Fix logical error 2017-05-31 19:38:08 +10:00
misaochan
361196bedd Add onRequestPermissionsResult() 2017-05-31 19:36:25 +10:00
misaochan
3bd1baaf8d Add constant for request code 2017-05-31 19:30:19 +10:00
misaochan
40a2e03b9c Add checkLocationPermission() call to onCreate() 2017-05-31 19:25:44 +10:00
misaochan
3ec93115e2 Add permission request for ACCESS_FINE_LOCATION 2017-05-31 19:25:04 +10:00
misaochan
e6383e20a6 Add checkLocationPermission() in NearbyActivity 2017-05-31 19:13:14 +10:00
misaochan
42c86576b3 Use string resource instead of hardcoded string 2017-05-30 20:08:00 +10:00
Josephine Lim
c9a746c8ce Merge pull request #699 from tobias47n9e/master
Fix variable spelling
2017-05-30 16:21:27 +10:00
Josephine Lim
0b39a12d2f Merge pull request #695 from maskaravivek/welcome
Fixes #671: Ability to launch welcome activity again
2017-05-30 16:18:52 +10:00
Tobias Schönberg
7b89731450 Fix variable spelling 2017-05-29 22:00:46 +02:00