Commit graph

845 commits

Author SHA1 Message Date
Josephine Lim
3db421ad8c Merge pull request #789 from achalshant/fix_for_issue#750
Fix for issue#750
2017-07-18 17:20:24 +10:00
Achal Shantharam
e46588e336 Adding whitespaces 2017-07-17 17:03:18 +05:30
Achal Shantharam
3681176f54 Fix for issue #750 irrelevant categories 2017-07-17 12:03:13 +05:30
Achal Shantharam
e405b67bfb Fix for issue #750 irrelevant categories 2017-07-17 12:00:20 +05:30
mwoguri
8f0cd852a5 Update HtmlTextView.java
Added whitespace
2017-07-16 19:14:47 -07:00
Michiyo Wellington-Oguri
10637f4bf2 Use string substitution to avoid translating trademarked text 2017-07-16 14:28:23 -07:00
Yusuke Matsubara
3b728ca568 Coding style fixes 2017-07-16 15:13:40 +09:00
Mikel
7edfe34a3e Merge branch 'master' into media_detail 2017-07-15 18:59:36 +02:00
Mikel
65ddc1a4bb Add Nullable annotations to reduce risk of NPE 2017-07-15 18:41:10 +02:00
Josephine Lim
ee409a9e8f Merge pull request #769 from tised/#748_issue
fix for #748
2017-07-16 02:32:26 +10:00
Mikel
9d23907728 Fix Issue with repeating categories in MediaDetail 2017-07-15 18:16:45 +02:00
Mikel
7667180bc5 Make uploaded image's coordinates clickable 2017-07-15 17:53:37 +02:00
Paul Hawke
8e47f82de6 Merge remote-tracking branch 'upstream/master' 2017-07-15 06:16:31 -05:00
Mikel
1044fe13ae Make license in MediaDetail clickable 2017-07-15 09:21:35 +02:00
Josephine Lim
0da51457d0 Merge pull request #771 from tised/#739_issue
fix for #739
2017-07-14 02:17:48 +10:00
Josephine Lim
2e388c0d5e Merge pull request #772 from tised/#708_issue
fix for #708
2017-07-14 01:12:52 +10:00
Josephine Lim
350f9bb697 Merge pull request #773 from tised/#657_issue
improvements for #657 issue
2017-07-14 01:10:34 +10:00
Dmytro Vodnik
0ce99bc10e improvements for #657 issue 2017-07-13 16:26:07 +03:00
Yusuke Matsubara
d241d36d66 Add PageTitle class to canonicalize page names 2017-07-13 18:29:30 +09:00
Dmytro Vodnik
397b4fa586 fix for #708 2017-07-13 12:23:15 +03:00
Dmytro Vodnik
719b30be85 fix for #739 2017-07-13 12:04:51 +03:00
Dmytro Vodnik
f3d7465fef fix for #748
that fields doesnt popup because they was shown only after onAuthCookieAcquired fired
2017-07-12 12:28:53 +03:00
Paul Hawke
c3649d3efd Merge remote-tracking branch 'upstream/master' 2017-07-11 08:06:55 -05:00
Josephine Lim
691acbf983 Merge pull request #768 from tised/#733_#732_fix
fix for #733,732 issue
2017-07-11 16:30:10 +10:00
Paul Hawke
6f86b1871f Fixed NPE caused by not initializing the resultStatus field of UploadResult when on the happy-path. 2017-07-10 15:23:13 -05:00
Dmytro Vodnik
869790900b fix for #733,732 issue
The problem is that onCreate of content resolver are calling before even Apllication onCreate, so that fields may be null which caused crashes
2017-07-10 17:31:32 +03:00
Paul Hawke
9387d31cb6 Improvements based on codacy-bot feedback. 2017-07-09 17:52:50 -05:00
Paul Hawke
6ccc608a1e Converted nearby list to recycler view and fixed a few issues pointed out by static code analysis. 2017-07-09 17:33:24 -05:00
Paul Hawke
c035b368c4 Added smoke test - run through a few api calls - to verify that the parameters are all correctly encoded and sent, and responses are parsed. 2017-07-05 19:29:48 -05:00
Paul Hawke
d64c1b51cc Refactoring to not expose the ApiResult and Apache HTTP implementation 2017-07-04 16:34:30 -05:00
Paul Hawke
599e7bb453 Consolidated media wiki api calls in a single place 2017-07-04 14:24:08 -05:00
Paul Hawke
5396fc6ed0 Optimized imports before starting 2017-07-04 14:23:13 -05:00
veyndan
3509b0a413 Remove redundant call to method 2017-06-30 20:19:25 +01:00
Yusuke Matsubara
b83c32f81e Merge pull request #742 from veyndan/place
Use an enum for the place description
2017-06-30 16:46:26 +09:00
veyndan
5d6bada4c8 Use an enum for the place description 2017-06-29 15:11:24 +01:00
veyndan
ae78930808 Make the drawer prettier 2017-06-28 21:39:10 +01:00
Yusuke Matsubara
f8bb106b83 Merge pull request #745 from veyndan/string-sanitation
Simplify string sanitation logic
2017-06-28 09:15:10 +09:00
Yusuke Matsubara
63496e48d4 Merge pull request #744 from veyndan/builder
Prevent instantiation of a class with a builder
2017-06-25 17:35:02 +09:00
Vanethos
e18c628a04 Remove button (#718)
* Changed the "Use previous title/description" button so that it does not delete the title and description edit text fields if there is no previous data. https://github.com/commons-app/apps-android-commons/issues/503

* Changed the "Use previous title/description" button so that it does not delete the title and description edit text fields if there is no previous data.

* Changed the "Use previous title/description" button so that it does not delete the title and description edit text fields if there is no previous data.

* Split the if statement in two lines

* Move && to the beginning of the line

* Restore order of titleEdit and descEdit
2017-06-24 21:44:10 +10:00
veyndan
8c3adbbb97 Simplify string sanitation logic 2017-06-19 17:02:16 +01:00
veyndan
dc01dfa014 Prevent instantiation of a class with a builder 2017-06-19 16:23:09 +01:00
Yusuke Matsubara
fd11c872b9 Fix coding style issues 2017-06-10 17:46:38 +09:00
Yusuke Matsubara
9c69539276 Share file with camera using cache and FileProvider
* Use cache instead of external storage to share file with camera
* Execute ExistingFileAsync after permission is granted
2017-06-10 16:47:37 +09:00
misaochan
7d5469dcfa Add null check for nearbyAsyncTask 2017-06-03 12:40:27 +10:00
misaochan
8e059691f9 Tidy up code 2017-06-02 18:27:39 +10:00
misaochan
6091cc7465 Remove addToBackStack
We do not actually want users to go back to this fragment
2017-06-02 18:26:05 +10:00
misaochan
a8d302bdf3 Remove progress bar and add null check for locationManager 2017-06-02 18:17:23 +10:00
misaochan
c3d4b029c1 Fill out onCreateView in fragment 2017-06-02 18:17:10 +10:00
misaochan
c8a0142c3e Cancel AsyncTask and add backstack 2017-06-02 18:08:34 +10:00
misaochan
18bb59403b Add NoPermissionsFragment 2017-06-02 01:30:13 +10:00