* Initial changes to the flow, merged conflicts
* Major changes to flow and logic
* Final major changes to the flow and merged conflicts
* Minor changes to thumbnail flow and merge conflicts
* Fixed ImageProcessingServiceTest
* Removed unnecessary file
* Some code cleanup and fixed UploadRepositoryUnitTest
* Minor javadoc changes and null checks
* Fixed UMDFragmentUnitTest
* Fixed and added new tests in UploadMediaPresenterTest
* Optimised code for no connection cases and minor code cleanup
* Minor bug fix
* Fixed minor bug
* Fixed a failing unit test
* Removed values-yue-hant
* Update UploadRepository.java
---------
Co-authored-by: Nicolas Raoul <nicolas.raoul@gmail.com>
* Custom picker: Show differently pictures that are currently being uploaded
* fix tests
* fix test
* fix crash
* handle all cases
* handle all cases
* fix
* Hide Images When showAlreadyActioned is disabled
* Fix Tests
* cleanup
* Fixed Grey empty screen at Upload wizard caption step after denying files permission
* Empty commit
* Fixed loop issue
* Created docs for earlier commits
* Fixed javadoc
* Fixed spaces
* Added added basic features to OSM Maps
* Added search location feature
* Added filter to Open Street Maps
* Fixed chipGroup in Open Street Maps
* Removed mapBox code
* Removed mapBox's code
* Reformat code
* Reformatted code
* Removed rotation feature to map
* Removed rotation files and Fixed Marker click problem
* Ignored failing tests
* Added voice input feature
* Fixed test cases
* Changed caption and description text
* Replaced mapbox to osmdroid in upload activity
* Fixed Unit Tests
* Made selected marker to be fixed on map
* Changed color of map marker
* Fixes#5439 by capitalizing first letter of voice input
* Removed mapbox code1
* Removed mapbox code2
* Fixed failing tests
* Fixed failing due to merging
* Butterknife to ViewBinding
* code fix to pass all tests
* test fix
* test fix
* test fix
* test fix
* Update ContributionsFragmentUnitTests.kt
* code cleanup and tests improved
* tests fixed
* adjustments and code cleanup
* adjustments and code cleanup
Added line breaks to PageContentsCreator.java, CategoryEditHelperUnitTests.kt, and MediaDetailFragmentUnitTests.kt following the example given on issue #5523.
* Convert UserClient to kotlin
* Added tests for WikiBaseClient
* Removed superfluous dao tests in review helper and got the proper ReviewDaoTest running in the unit test suite
* Improved tests for ReviewHelper
* Convert the ReviewHelper to kotlin
* Convert the WikiBaseClient to kotlin
* Convert the WikidataClient to kotlin
* Converted CategoryInterface to kotlin
* Converted DepictsInterface to kotlin
* Convert the MediaDetailInterface to kotlin
* Convert MediaInterface to kotlin
* Convert ReviewInterface to kotlin
* Convert the UserInterface to kotlin
* Convert the WikiBaseInterface to kotlin
* Convert WikidataInterface to kotlin
* Convert WikidataMediaInterface to kotlin
* Convert UploadInterface to kotlin
* logErrorsInsteadOfCrashing only ever returned false, so remove it and simplify logger
* Removed unused getMediaWikiBaseUrl()
* Removed getDesiredLeadImageDp() from commons app adapter, since it's unused
* Inlined the isLoggedIn() method of the app adapter
* Inline the app adapter username/password
* Removed the unused getRestbaseUriFormat() from the commons app adapter
* Remove references to the data-client SharedPreferenceCookieManager
* Manage our own OkHttpClient and remove the AppAdapter implementation
* Convert the result classes to kotlin
* Convert response and callback to kotlin
* Cleanup code-quality warnings before converting
* Converted the LoginClient to kotlin
* Updated the UserExtendedInfoClientTest to be kotlin, and live in the correct spot
* Fixed Grey empty screen at Upload wizard caption step after denying files permission
* Empty commit
* Fixed loop issue
* Created docs for earlier commits
* Fixed javadoc
* Fixed spaces
* Added added basic features to OSM Maps
* Added search location feature
* Added filter to Open Street Maps
* Fixed chipGroup in Open Street Maps
* Removed mapBox code
* Removed mapBox's code
* Reformat code
* Reformatted code
* Removed rotation feature to map
* Removed rotation files and Fixed Marker click problem
* Ignored failing tests
* Added voice input feature
* Fixed test cases
* Changed caption and description text
* Replaced mapbox to osmdroid in upload activity
* Fixed Unit Tests
* Made selected marker to be fixed on map
* Changed color of map marker
* Fixes#5439 by capitalizing first letter of voice input
* Made UI changes in UploadMediaDetailAdapter
* Added javadoc
---------
Co-authored-by: Nicolas Raoul <nicolas.raoul@gmail.com>
* Fixed Grey empty screen at Upload wizard caption step after denying files permission
* Empty commit
* Fixed loop issue
* Created docs for earlier commits
* Fixed javadoc
* Fixed spaces
* Added added basic features to OSM Maps
* Added search location feature
* Added filter to Open Street Maps
* Fixed chipGroup in Open Street Maps
* Removed mapBox code
* Removed mapBox's code
* Reformat code
* Reformatted code
* Removed rotation feature to map
* Removed rotation files and Fixed Marker click problem
* Ignored failing tests
* Added voice input feature
* Fixed test cases
* Changed caption and description text
* Replaced mapbox to osmdroid in upload activity
* Fixed Unit Tests
* Made selected marker to be fixed on map
* Changed color of map marker
* Resolves issue #2239 by adding an arrow for direction
* Removed unnecessary change in styles.xml
* spacing
* javadoc
---------
Co-authored-by: Nicolas Raoul <nicolas.raoul@gmail.com>
* Removed butterknife from contributions list fragment and overhauled its test
* Suggested fix from stack overflow to remove duplicate class error during build
* feat: add backgroundColor property on media
* feat: add optional menu items for media backgroundColor
* fix: test pass when running in batch
* refactor: remove backgroundColor from media
* refactor: add string for background color menu
* chore: remove useless change
* feat: change media image background color
* feat: pass backgroundColor to ZoomableActivity
* chore: remove extra space
* Add basic image limit warning to custom selector
* Block upload button when image limit is exceeded
* Complete basic functionality for upload limit: Disabled button, warning sign & toast
* Consolidate functionality between upload limit and not for upload marking
* Upload Limit: write unit tests and optimize control flow
* Upload Limit Tests: improve logic coverage and alter to stay valid if limit is changed
* Upload Limit: polish javadocs and add explanation to warning toast.
* Upload Limit: refactor variable names
* Upload Limit: change warning toast to dialog box, repurposing welcome dialog code & layout
* Upload Limit: remove error icon when the mark as not for upload button is pressed
