* Revert stopgaps related to beta server cert issue
The upstream issue with Commons beta server has been
fixed now[1]. So, there's no point in stopgapping
the issue anymore. So, revert the related changes.
This reverts fa87eb5661
and df426f7c42 which
correspond to PRs #3350 and #3349 respectively.
[1]: https://phabricator.wikimedia.org/T243881#5861983
* Test-fix: fix the failing CI test
* #3493 App freezes for 15 seconds when you press Next in UploadMediaDetailsFragment - add apropriate schedulers and convert justs to fromCallable
* #3493 App freezes for 15 seconds when you press Next in UploadMediaDetailsFragment - remove test for removed functionality
* #3493 App freezes for 15 seconds when you press Next in UploadMediaDetailsFragment - replace kotlin with java
* Part of #3127
* Added Room Dependency
* Shifted ContributionsDao to use RoomDB
* Save and Fetch contributions via RoomDAO
* Bugfixes, fixed test cases, injected schedulers for ContributionsPresenter
* removed stetho
* Fixed ReviewHelperTest cases
* Fixed test cases in DeleteHelperTest
* Fetch all contributions [TODO add pagination to use this, maybe later in a seperate PR]
* Update Schema false in AppDatabase
* removed parameter from fetchControbutions
* Added logs for fetch contributions
* Fixed test case ContributionsPresenter
* Added an autogenerate primary key, submit save contributions on executor
* fixed getItemAtPosition
* MainActivity Config changes +=orientation
* BugFixes
* Make AppDataBase Singleton
* Set _id as autogenerate primary key [replacing the previously used filename, seems like they are not unique]
* Replace Execxutor Utils with Subscribers on Singles in UploadService
* BugFix, Upload Progress
* Remove un-nescessary null check on contributions in ContributionsListAdapter
* removed ContributionsListFragment [not-implemeted]
* Review suggested changes
* removed un-nescessary null checks
* provide ContributionsDao
* Minor bug fixes
* wip
* delete existing contributions table (from the existing db) on upgrade
* remove un-nescessary null checks in test classes
* shifted media to be a local variable in ReviewHelperTest
* removed captured folder
* Dispose composite disposables in UploadService
* replaced size check with isEmpty ContributionsPresenter
* transform saveContributions to a Completable
* Addressed comments in review
* Typo in Contributions
* ReasonBuilderTest (create media object instead of mocking)
* Use global Gson object instead of creating a new one in Converters
* Provide Gson to Converters from the CommonsApplicationComponent
* use static method instead of field instead of static field to provide GSON in Converters
* Modified gitignore to exclude captures/*
* MediaDetailFragment: add zoom feature
* fragment_media_detail: add SimpleDrawee for Scroll picture
* ZoomableActivity: activity which facilitates zoom in
* activity_zoomable: xml for zoom activity
* zoomControllers: controllers for handling gesture and zooming
* MediaDetailFragment: fixing name of image variable
* MediaDetailFragment: display as per the aspect ratio of image
* add zoom activity to AndroidManifest
* fix travis ci faliure
* fix resizing of image
* Added Support for System Wide Dark Theme
* changed methods to private
* Moved Strings to strings.xml
* Used Dagger to reduce code repetition
* Changes made as per review suggestions
* Minor Changes
* Fixes as per suggestions
* Minor Fixes as per suggestion
* made the variables static
* removed irrelevant code
It's common for users to expect that re-opening the app would
allow them to "continue where they left off". This also applies
for the case where they leave the app after opening an
external link. It's natural for them to expect that they would
see the webpage they left open when they re-open the app. This
doesn't happen for our app as we open custom tabs in a separate
activity. As a consequence, this makes the experience
un-intuitive.
Fix this by opening custom tabs in the same activity.
Fixes: #2944
Co-authored-by: Adam Jones <jones_adam@rocketmail.com>
* ic_custom_greyed_out_marker: removing grey marker
* NearbyParentFragment: changing function name and description
* change method name to hideAllMarkers
* Avoid showing the quiz pop-up twice to the user
Due to the current flow of code it's possible that in
some cases the quiz pop-up is shown to the user twice.
This is unnecessary and unintentional.
So, change the logic in such a way that the quiz pop-up
would be never be shown twice to the user.
Fixes: #3281
* Quiz: remove unused parameters from methods
Some methods don't seem to be using the parameters that
they receive. So, just remove the unused parameters.
It makes sense to not show the review activity for logged
out users for the same reasons that we don't allow users
to upload images.
We're even considering to limit the review activity to users
with a particular level of achievement[1]. So, it's valid to
not show review activity for logged out users who don't
have achievements levels at all.
[1]: https://github.com/commons-app/apps-android-commons/issues/2852
* Fixes#3303
* Refactor Nearby to alig lifecycle methods
* Pass updated place list to listfragment
* Added default zoom rate to mapbox
* Removed NearbyListFragmet and added the ui login to handle the same in NearbyParentFragment
* More code refactor
* Make BottomSheetList hideable
* onFragmentHide, hide the bottom sheets
* BigFix, Fragmet visibility, register/un-register camera move based on fragments lifecycke
* More code refactor
* Let the ExecutorUtil have non-ui thread
* Add Location Marker on non-ui thread (the non-ui stuffs)
* BugFixes
* Removed configchanges "orientation" from MainActivity in Manifest (That was messing with the fragment lifecycle)
* Some null checks
* Initialise lastknown location in onMapReady
* UI Fixes
* Adjusted UI to support dark and no-dark themes both (in nearby)
* Do not update map on Location Slightly changed
* Fix failing test case, let TestCommonsApplication extend Application instead of CommonsApplication
* start map view when nearby is visible
* start the map when NearbyFragmet is visible
* More bugfixes
* Added DUMMY view for NearbyPresenter's onDetach State
* Added a wrapper frame layout parent for MapView to preven it from drawing above other views
* More bugfixes (Fixes#3287)
* Gray out the un-selected markers from the nearby filter list
* BugFix, search this area should search the nearby places for the current camera position
* More BugFixes
* Handle null primitives with proxy
* Current location marker flow via permission flow
* onCameraMove should have null-check on NearbyController.latestSearchLocation instead of currentLocation
* Search for places around last focus location
* Handle location updates
* If the user is browsing the map, donot update the map with current location
* CategoryClient: fix category search case-sensitivity by converting to lower case as MW api is inherently case-sensitive, the results obtained will be same
* CategoryItem: reverting javadoc changes
* CategoriesModel: make category search case-insensitive
* CategoryItem: fix whitespaces
* Add tests for case-insensitivity
* CategoryClientTest: add more test cases
* CategoryClientTest: fix travis ci test
* CategoriesModelTest: changes mage to CategoriesModel and tested
* Fixes#3336
* Donot redact locatio by default
* Correction inn default tag save
* Use same key across application for managedExifTags
* Updated key name to avoid class cast in existing build
* Fixes#3345
* Trust all hosts for beta
* Added a custom NetworkFetcger for Fresco when on beta
* removed unused assets
* make TestCommonsApplication extend Application instead of Commons Application
* Fixes#3320
* Added SSL certificate for commons beta
* Asked OKHTTP client to use SSLContext from beta certificate
* Probable Fix of #3345
* Use ConfigUtils to verify flavor
