Commit graph

506 commits

Author SHA1 Message Date
Madhur Gupta
48f2bb8863
Add more tests for Quiz (#4411) 2021-05-14 17:20:46 +10:00
Prince kushwaha
0c8b92c7aa
Show media details fragment when on clicking image of Peer Review (#4374)
* * show MediaDetailFragment in ReviewActivity on image click
* Add javadoc
* Reformated code of  ReviewActivity xml

* fix typos

* add unit test

* made minor changes
2021-05-10 19:07:28 +03:00
Madhur Gupta
2f4c30416d
Update Test Dependency version (#4405)
* Update Version and Unit Test

* fix failing tests

* update robolectric
2021-05-10 17:22:56 +10:00
Madhur Gupta
a5154fb7fe
Add few more tests for campaign module (#4384) 2021-04-28 17:12:11 +10:00
Madhur Gupta
cb8a7c22da
Add few more tests for notification module (#4383) 2021-04-28 17:11:52 +10:00
Madhur Gupta
2e0f8e6d68
Add Unit Tests for widget module (#4381) 2021-04-27 11:43:17 +03:00
Madhur Gupta
a03c04e89c
Add MediaDetailPagerFragment Unit Tests (#4362) 2021-04-19 11:54:34 +03:00
neslihanturan
4bca142321
Revert "Add Unit Tests for Upload Service (#4322)" (#4353)
This reverts commit fba7fb8532.
2021-04-13 02:22:30 +10:00
Madhur Gupta
fba7fb8532
Add Unit Tests for Upload Service (#4322) 2021-04-12 17:38:32 +03:00
Ashish
ecbff7e3b8
Fixes #3790- Use WorkManagers to upload contributions (#4298)
* Fixes #3790
Use WorkManagers to process upload contributions
** Removed UploadService and Added UploadWorker to process contributions Upload
** Made nescessary changes to remove the usages of the Service from the classes
** UI Fxies- Minor changes in the retry and cancel uplaod icons to give them a clickable area of 48 dp

* Fixes #3790
Use WorkManagers to process upload contributions
** Removed UploadService and Added UploadWorker to process contributions Upload
** Made nescessary changes to remove the usages of the Service from the classes
** UI Fxies- Minor changes in the retry and cancel uplaod icons to give them a clickable area of 48 dp

* Updated JavaDocs in UploadWorker, Fixed Test cases

* Updated JavaDocs in UploadWorker, Fixed Test cases

* Updated gradle

* Revert "Updated gradle"

This reverts commit c8979fe6dc.

* rolledback to compileSDKVersion 28, fixed tests

* Don't call the show notifications on the main thread

* Bug Fix- Duplicate contributions, handle upload stash errors
2021-04-08 15:59:07 +03:00
Aditya-Srivastav
0a7ff3e068
Added LocationUtilsTest for LocationUtils (#4319)
* added location utils test

* requested changes
2021-04-08 15:40:28 +03:00
Madhur Gupta
b939db91e0
Update Tests for Profile Activity (#4324) 2021-04-05 11:30:36 +03:00
Madhur Gupta
5ddbc9e27a
Add More Unit Tests for NotificationActivity (#4314) 2021-04-02 12:44:28 +03:00
Pratham Pahariya
a479dd5bb1
#4048 - "copy to subsequent media" button (#4308)
* added copy to subsequent media button

* minor change

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-04-02 09:12:11 +03:00
Madhur Gupta
6449d8f639
Add Grid View Adapter Unit Tests (#4301) 2021-03-23 12:57:24 +03:00
Pratham Pahariya
944225c3a3
Fixes #4260 - Item with P582 (end time) shown as existing (#4292)
* fix issue with item with endtime shown as existing

* Removed destroyed and endtime, Added comments and also fixed the broken tests

* minor fix

* Added comments

* fix no such column location_exists error

* minor improvement

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-03-18 00:05:08 +09:00
Aditya-Srivastav
5c02b2fc0a
changed column name (#4288) 2021-03-04 16:55:21 +03:00
Aditya-Srivastav
7a5774e479
Fixes #4281 "Wrong language pre-selected in Nearby upload" (#4285)
* location added

* tests

* changes requested

* comments

* Test fixed, minor improvement
2021-03-04 15:51:28 +03:00
Madhur Gupta
64993dfbc8
Add few more unit tests for AchievementsFragment (#4272) 2021-02-23 19:43:20 +10:00
Madhur Gupta
5f1dda146e
Add BookmarkPicturesFragment Unit Tests (#4264) 2021-02-22 21:15:12 +10:00
Aditya-Srivastav
7d8ea51c4f
Added bookmark section in not-logged-in version (#4256)
* added bookmark in not-logged-in version

* javadoc

* javadoc update

* spacing

* added unit test
2021-02-22 00:23:41 +09:00
Taco
ee50bc8188
Update AndroidX Browser and ExifInterface to latest version (#4223) 2021-02-15 21:35:20 +09:00
Adam Jones
89737b2640
#747: Convert action package (ThanksClient and PageEditClient) to Kotlin (#4075) 2021-01-23 14:36:01 +05:30
Madhur Gupta
aec563efe9
Added Few more Login Activity Tests (#4164) 2021-01-14 02:41:09 +10:00
Madhur Gupta
c8753e8b38
Added Settings Activity Tests (#4165)
* Added Settings Activity Tests

* Remove extra lines
2021-01-14 02:40:10 +10:00
Madhur Gupta
653a41ce24
Added Notification Activity Tests (#4166) 2021-01-14 02:40:04 +10:00
Madhur Gupta
381f54c5ef
Added Review Activity Tests (#4167)
* Added Review Activity Tests

* Remove Unused Code
2021-01-14 02:39:47 +10:00
Madhur Gupta
9296ef6fbd
Extend About Activity Tests (#4168) 2021-01-14 02:39:27 +10:00
Madhur Gupta
cd3ba67cfb
Add Category Details Activity Unit Tests (#4169) 2021-01-14 02:39:14 +10:00
Madhur Gupta
a62c2f5cf0
Add Main Activity Unit Tests (#4171) 2021-01-14 02:38:51 +10:00
Madhur Gupta
7f2316fe46
Add More Bottom Sheet Fragments Unit Tests (#4172)
* Add More Bottom Sheet Fragment Unit Tests

* Add More Bottom Sheet Logged Out Fragment Unit Tests
2021-01-14 02:38:31 +10:00
Madhur Gupta
57aab1927a
Add Achievements Fragment Tests (#4162) 2021-01-12 00:30:04 +00:00
Madhur Gupta
67a9bd56fb
Add Login Activity Test (#4160) 2021-01-12 00:17:27 +00:00
Madhur Gupta
e36640377a
Added Search Activity Unit Tests (#4149) 2021-01-05 03:05:59 +10:00
Madhur Gupta
c3700c9234
Added Signup Activity Test (#4134) 2020-12-28 20:23:03 +10:00
Madhur Gupta
c1659f2bc0
Added Tests for Profile Activity (#4062) 2020-12-05 18:49:25 +00:00
Ashish
d720750ab4
Fixes invalid authorname in explore (#4054)
* Fixes #3341, #4018
* Defined two feild author and user in Media and used them at the corresponding places
Minor bug fixes
-displaying userName in uploadedBy.
-modified HTML parsing in getArtist.
-Replaced creator with author.

* Fixes #3341, #4018
* Defined two feild author and user in Media and used them at the corresponding places
Minor bug fixes
-displaying userName in uploadedBy.
-modified HTML parsing in getArtist.
-Replaced creator with author.
2020-12-01 23:56:41 +10:00
Madhur Gupta
2ed5a74b4d
Added Test for BookmarksPagerAdapter (#4027) 2020-11-10 20:25:01 +10:00
Madhur Gupta
0d5fa048a5
Added Unit Test for About Activity Class (#3978) 2020-10-24 11:02:23 +05:30
Ashish
b8ba89d077
Fixes #3923 (Back" does nothing in Nearby in particular circumstance) (#3961)
* Fixes #3923
* Handled possible missing backpress cases in MainActivity-nearby

* Fixes #3923
* Handled possible missing backpress cases in MainActivity-nearby
2020-10-20 12:41:17 -07:00
neslihanturan
2001da5471
Add tests for LatLng class (#3955) 2020-10-07 21:49:41 +10:00
neslihanturan
b9de8dc145
Add tests for FilePicker public methods (#3948) 2020-10-07 01:34:39 +10:00
Madhur Gupta
67c0004062
Added Test for Quiz Classes (#3953) 2020-10-06 16:36:20 +03:00
neslihanturan
44fb1534bb
Add bookmark location controller test (#3947) 2020-10-01 19:21:33 -07:00
neslihanturan
257e8c57dd
Add MediaConverterTest (#3945) 2020-09-30 12:00:43 -07:00
Vivek Maskara
66f6e2e648
With changes for limited connection mode (#3934)
* With changed for limited connection mode

* Java docs

* With minor fix

* Fix cosmetic issues

* Fix ANR

* Add Unit test
2020-09-25 22:57:22 +10:00
Madhur Gupta
66469e006a
Added Unit Tests for WelcomeActivity Class (#3933) 2020-09-19 01:05:42 +10:00
Ashish
ddd3e1212a
Sync master with release (#3922)
* #3624 DateTimeFormat wrong - match pattern returned from servers (#3625)

* Revert "Fixes: #3179 Make category search non case-sensitive (#3326)" (#3636)

Simply lower casing the name of the category sent to the server
doesn't result in the server doing a case insensitive category
search. In fact, it reduces the category search space as only
categories that has a lower case character is searched even
if the search text contains upper case characters.

The test case did not catch this issue as the first character
of the title is case insensitive[1].

So, revert the changes done in commit afdeaae075.

See further disucssion in the issue thread of #3179 starting
from [2].

[1]: https://www.mediawiki.org/wiki/Manual:Page_title
[2]: https://github.com/commons-app/apps-android-commons/issues/3179#issuecomment-605462140

* Bugfix/security exception (#3627)

* Fixes #3626
* Check is file is actually created before writing to file, file picker android

* Handle Security exception

* Fixes #3436 and #2881: Media Detail design Overhaul (#3505)

* ic_map_dark_24dp: map icon for white background

* ic_info_outline_dark_24dp: info icon for dark background

* MediaDetailFragment: update the spacer as per image aspect ratio

* fragment_media_detail: design overhaul

* fragment_media_detail: remove redundant background color statements

* make requested changes

* add dark mode support

* minor ui tweak

* white map icon in dark mode

* make rquested changes

* make requested changes to layout

* fix misalignment of category list

* subtle amendments

* convert comments to javadocs

* minor amendments

* minor changes

* add styles for media detail

* Media detail fragment refactored

* make suggested changes

* minor name fix

* fix the delete button border

* Fixes #3639 (Fix Save State implementation of CheckBoxTriState ) (#3686)

* Add #3723 and #3721 to 2.13 release, fix conflicts

Conflicts were caused by merging #3723 before #3721 , so I just rolled both into one commit.

* Fix NullPointer when clicking on image in MediaDetailFragment (#3730)… (#3739)

* Update changelog.md

* Versioning for v2.13

* Fixes #3705 (Crash when viewing pic I just uploaded) (#3782)

* Fixes #3705
* Let the MediaDetailPager fragment know when the contributions have been updated

* Handle NPE, null check on adapter in MediaDetailPagerFragment

* Fixed BookmarkLocationsDao DB migration (#3793)

* Fixes #3725 (#3795)

* Downgraded okhttp version to support Api 19 devices

* Handled null CompoundDrawable[2] in etTitle-> UploadMediaDetailsFragment (#3828)

* DownSample Upload image to be shown in UploadMediaDetailFragment to handle OOM, Bitmap Too large exception (#3830)

* Fixes #3829
* DownSample Upload image to be shown in UploadMediaDetailFragment to handle OOM, Bitmap Too large exception

* removed unused imports, handled possible exceptions

* Let Fresco handle the downsampling of image

* invalidate in onTransformEnd

* Expose an interface TransformationListener in ZoomableDraweeView to listen to transformation change end

* removed photoView dependency

* removed unused imports in ZoomableActivity

* Bugfix, expand/collapse

* changed functio name

* Bugfix/p18 uploads (#3869)

* updated gradle plugin version

* BugFix #3856
* Do not use preference for deciding acceptable lat long for nearby uploads, instead save the corresponding location in the Contribution via UploadItem

* Marshall contribution's hasInvalidLocation

* reset un-related changes

* Fixed test cases

* Minor code formatting and docs

* Fixes #3882 (#3883)

* Make hasInvalidLocation non-null integer with default value 0

Co-authored-by: Ashish Kumar <ashish@Ashishs-MacBook-Air.local>

* Fixes #3766, Added OPENSTREET attribution (#3889)

* Fixes #3766
* Added OPENSTREET attribution in nearby

* Added custom text attribution in Nearby

* Deleted unused class CustomBorderTextView

* review suggested changes

* modified telemetry summary string

* Versioning and changelog for v2.13.1 (#3908)

* Update changelog.md

* Versioning for v2.13.1

* Fixes #3914 (#3915)

* Verify user login before setting upload count

* fixed compile-time error

* fix erros

* delete emptied files

* remove empty file CategoriesModel.java

Co-authored-by: Seán Mac Gillicuddy <seantheappdev@gmail.com>
Co-authored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Co-authored-by: Kshitij Bhardwaj <44129798+kbhardwaj123@users.noreply.github.com>
Co-authored-by: Vitaly V. Pinchuk <vetal.978@gmail.com>
Co-authored-by: Josephine Lim <josephinelim86@gmail.com>
Co-authored-by: Ashish Kumar <ashish@Ashishs-MacBook-Air.local>
2020-09-14 21:11:46 +10:00
Madhur Gupta
abdd16c063
Added Test for LevelInfo Class (#3930) 2020-09-13 18:31:25 -07:00
Ashish
4109d23023
Bugfix/categories search (#3913)
* Fixes #3734
* Donot ignore case while searching categories

* Fixed test-cases to ensure search terms are passed as it is to the CategoryClient

* Used a First_Char_Caps title list term just to ensure test case tests as intended

* Fixed searchAll with empty term test case
2020-09-01 02:00:36 +10:00