Dmitry Brant
8255bac32e
Don't store Activity instance in adapter.
2017-05-26 15:15:43 -04:00
Dinu Kumarasiri
40c1ea375a
Merge pull request #681 from dbrant/crash2
...
Fix crash when uploading multiple photos.
2017-05-26 23:35:37 +05:30
Dmitry Brant
5923e9ad4a
Fix crash in PhotoDisplayAdapter.
2017-05-26 13:35:40 -04:00
Josephine Lim
be62646fbe
Merge pull request #677 from Deskana/unusedimports
...
Remove unused imports
2017-05-27 02:10:12 +10:00
Deskana
14326ae3d0
Fix usage of deprecated function String.fromHtml(String)
...
String.fromHtml(String) is now deprecated. This patch fixes that by adding a method to Utils that selects the appropriate function based on the user's platform.
2017-05-26 13:52:01 +01:00
Deskana
7a8e04eec1
Simplify if statements
...
This patch simplifies a few if statements by replacing them with returns, which helps improve code readability and simplicity.
2017-05-26 11:16:22 +01:00
Deskana
4b7011a725
Remove redundant call to String.format() in CategoryModifier
...
This patch removes a call to String.format that can be replaced with a
literal string which is much clearer.
2017-05-26 11:08:02 +01:00
Deskana
767878f194
Remove unused imports
...
This patch removes imports across the codebase that are unused to improve
code maintainability and cleanliness.
2017-05-26 11:02:56 +01:00
Deskana
9b26465b1d
Remove redundant field in SettingsActivity
...
There is a field that is set in SettingsActivity that is never used at all.
This patch removes that field to improve performance and code tidiness.
2017-05-26 10:55:53 +01:00
Tobias Schönberg
d545c9b0ef
Vertically center nearby list loading icon
...
The loading icon of the nearby places list is currently
at the very top of the view.
This commit vertically centers the loading icon.
2017-05-25 17:47:18 +02:00
Tobias Schönberg
db5dbbfdfd
Fix crash of nearby list when the places list is null
...
Currently the NearbyController crashes when it is called with a
places list that is null. This is caused by the NearbyMapFragment
not handling this state correctly.
This commit adds tests for an empty list and null, which reproduce
the problem. An early return in the NearbyController can make
the tests pass, but might not be the best solution for this issue.
2017-05-24 22:15:38 +02:00
Yusuke Matsubara
28d73d2b96
Espresso: match with resource names in settings screen
...
Apparently this is more robust (especially for SDK version 25)
2017-05-21 21:38:35 +09:00
Josephine Lim
aeb66492d6
Merge pull request #664 from sandarumk/replace_upload_with_home
...
Replace upload with home
2017-05-21 12:33:04 +02:00
Josephine Lim
35bead1302
Merge pull request #663 from maskaravivek/guava
...
Adding support for Guava library
2017-05-21 12:31:29 +02:00
Dinu Kumarasiri
471403d7c3
Replace upload with home
2017-05-21 12:30:54 +02:00
maskara
43d841bdf3
Adding support for Guava library
2017-05-21 12:25:28 +02:00
translatewiki.net
1d2ba94c56
Localisation updates from https://translatewiki.net .
2017-05-21 09:52:06 +02:00
Adam Jones
fdb0db9cb3
Fix ellipsis characters
2017-05-21 00:10:38 +01:00
Adam Jones
b872ba011d
Fix github url
2017-05-21 00:09:53 +01:00
Adam Jones
b92d8e03e8
Fix spaces
2017-05-21 00:08:21 +01:00
Vivek Maskara
0e71e817b6
Merge pull request #641 from sandarumk/fix_lint_issues
...
Fix lint issues
2017-05-20 19:11:07 +02:00
Josephine Lim
0a94c9c0ba
Merge pull request #647 from dbrant/rotate1
...
Fix showing local image if fetching thumbnail fails.
2017-05-20 16:03:37 +02:00
Dmitry Brant
39e24b1863
Don't put local URI into thumbnail cache.
2017-05-20 15:32:41 +02:00
Josephine Lim
b3215b1e78
Merge pull request #645 from maskaravivek/overlayMenu
...
Add popup menu in nearby info dialog
2017-05-20 15:23:35 +02:00
Josephine Lim
e7bfd40cc4
Merge pull request #637 from dr0ptp4kt/harmonize-licenses-with-upload-wizard
...
Remove unused interface license message strings
2017-05-20 15:22:19 +02:00
maskara
75f3fe4ed6
Fixed codacy issues
2017-05-20 13:43:47 +02:00
Dmitry Brant
5fc684fcc5
Fix showing local image if fetching thumbnail fails.
2017-05-20 13:41:23 +02:00
Dinu Kumarasiri
1dbe1fe636
Fix codecy issues
2017-05-20 13:34:51 +02:00
maskara
4da88b41ea
Added width and height to dimens file
2017-05-20 13:33:23 +02:00
maskara
4823486139
Add popup menu in nearby info dialog
2017-05-20 13:09:16 +02:00
Josephine Lim
bc09ee4bba
Versioning for v2.4
2017-05-20 12:32:27 +02:00
Dinu Kumarasiri
7629e00f33
Fix merge conflicts
2017-05-20 12:28:39 +02:00
Adam Baso
05515ab80c
Merge branch 'master' into harmonize-licenses-with-upload-wizard
2017-05-20 05:22:49 -05:00
Fotis Tsalampounis
b83248505f
Removed getSupportActionBar command
...
The getSupportActionBar method caused a null pointer exception in deviced running Android SDK >21 but there is actually no need for it since the theme doesn't have an Action Bar.
2017-05-20 13:14:11 +03:00
Josephine Lim
a826ca4049
Merge pull request #639 from dbrant/rotate1
...
Fix display of media detail after screen rotation.
2017-05-20 12:01:32 +02:00
Dinu Kumarasiri
43a707dad5
Fix merge conflicts
2017-05-20 11:58:26 +02:00
Dinu Kumarasiri
83957bae06
[Lint] Remove class variables to local
2017-05-20 11:53:46 +02:00
Dinu Kumarasiri
8f5be5a434
[Lint] Add content description to image views
2017-05-20 11:51:22 +02:00
Dmitry Brant
96f9526244
Fix display of media detail after screen rotation.
2017-05-20 11:49:15 +02:00
Dinu Kumarasiri
7ad1cf294f
[Lint] Remove class variables to local
2017-05-20 11:37:04 +02:00
maskara
4cb6fb86f8
Fix back button issue in ShareActivity
2017-05-20 11:35:49 +02:00
Dinu Kumarasiri
6b51df51f8
[Lint] Add content description to image views
2017-05-20 11:19:21 +02:00
Vivek Maskara
95ecfbd3c2
Merge pull request #620 from tobias47n9e/master
...
Add nearby activity Espresso test
2017-05-20 10:59:21 +02:00
translatewiki.net
6a5629186b
Localisation updates from https://translatewiki.net .
2017-05-20 10:51:38 +02:00
dr0ptp4kt
db4eb3a699
Remove unused interface license message strings
...
The app current displays licenses aligned with MediaWiki's
UploadWizard UploadWizard.config.php file for ownWork. Presently,
the aligned licenses are as follows.h
cc-by-sa-4.0
cc-by-sa-4.0
cc-by-sa-3.0
cc-by-4.0
cc-by-3.0
cc-zero
License messages other than these are removed with this patch.
This closes #243 .
2017-05-20 01:58:51 -05:00
Yusuke Matsubara
3beeac2a4f
Merge pull request #623 from tobias47n9e/feature/test-length-utils
...
Add some tests for the LengthUtils class
2017-05-20 10:29:25 +09:00
Dmitry Brant
269cef559b
Don't show uploads that have been deleted.
2017-05-19 17:59:26 +02:00
Dmitry Brant
ac22525c69
Merge remote-tracking branch 'upstream/master'
2017-05-19 17:38:24 +02:00
Dmitry Brant
38e7cad345
Final touch-ups to improved image loading.
2017-05-19 17:19:10 +02:00
Josephine Lim
9d4c3cd2d9
Merge pull request #633 from maskaravivek/mediaDetail
...
Fix issue where there was no way to back from MediaDetailFragment
2017-05-19 17:02:05 +02:00
