Dmytro Vodnik
0ce99bc10e
improvements for #657 issue
2017-07-13 16:26:07 +03:00
Paul Hawke
9387d31cb6
Improvements based on codacy-bot feedback.
2017-07-09 17:52:50 -05:00
Paul Hawke
6ccc608a1e
Converted nearby list to recycler view and fixed a few issues pointed out by static code analysis.
2017-07-09 17:33:24 -05:00
veyndan
3509b0a413
Remove redundant call to method
2017-06-30 20:19:25 +01:00
Yusuke Matsubara
b83c32f81e
Merge pull request #742 from veyndan/place
...
Use an enum for the place description
2017-06-30 16:46:26 +09:00
veyndan
5d6bada4c8
Use an enum for the place description
2017-06-29 15:11:24 +01:00
Yusuke Matsubara
f8bb106b83
Merge pull request #745 from veyndan/string-sanitation
...
Simplify string sanitation logic
2017-06-28 09:15:10 +09:00
veyndan
8c3adbbb97
Simplify string sanitation logic
2017-06-19 17:02:16 +01:00
veyndan
dc01dfa014
Prevent instantiation of a class with a builder
2017-06-19 16:23:09 +01:00
misaochan
7d5469dcfa
Add null check for nearbyAsyncTask
2017-06-03 12:40:27 +10:00
misaochan
8e059691f9
Tidy up code
2017-06-02 18:27:39 +10:00
misaochan
6091cc7465
Remove addToBackStack
...
We do not actually want users to go back to this fragment
2017-06-02 18:26:05 +10:00
misaochan
a8d302bdf3
Remove progress bar and add null check for locationManager
2017-06-02 18:17:23 +10:00
misaochan
c3d4b029c1
Fill out onCreateView in fragment
2017-06-02 18:17:10 +10:00
misaochan
c8a0142c3e
Cancel AsyncTask and add backstack
2017-06-02 18:08:34 +10:00
misaochan
18bb59403b
Add NoPermissionsFragment
2017-06-02 01:30:13 +10:00
misaochan
2e72b29fba
Add TODO and fragment transaction
2017-06-02 01:25:17 +10:00
misaochan
9895093b8f
Add @NonNull annotations
2017-06-01 22:15:17 +10:00
misaochan
e6e141e51d
Fix whitespace
2017-05-31 19:53:23 +10:00
misaochan
cab0d24692
Add null check to onPause asynctask
2017-05-31 19:50:45 +10:00
misaochan
ec6ba8cf87
Remove hardcoded string
2017-05-31 19:49:19 +10:00
misaochan
93acd40926
Move code into startLookingForNearby()
2017-05-31 19:47:09 +10:00
misaochan
a704f5a740
Register locationManager if permission granted
2017-05-31 19:43:51 +10:00
misaochan
50ecf4fd15
Fix logical error
2017-05-31 19:38:08 +10:00
misaochan
361196bedd
Add onRequestPermissionsResult()
2017-05-31 19:36:25 +10:00
misaochan
3bd1baaf8d
Add constant for request code
2017-05-31 19:30:19 +10:00
misaochan
40a2e03b9c
Add checkLocationPermission() call to onCreate()
2017-05-31 19:25:44 +10:00
misaochan
3ec93115e2
Add permission request for ACCESS_FINE_LOCATION
2017-05-31 19:25:04 +10:00
misaochan
e6383e20a6
Add checkLocationPermission() in NearbyActivity
2017-05-31 19:13:14 +10:00
misaochan
42c86576b3
Use string resource instead of hardcoded string
2017-05-30 20:08:00 +10:00
Tobias Schönberg
7b89731450
Fix variable spelling
2017-05-29 22:00:46 +02:00
Tobias Schönberg
2a7ef947ff
Code style
2017-05-28 18:56:10 +02:00
Tobias Schönberg
0a86a31203
Code style fixes
2017-05-28 18:39:10 +02:00
Tobias Schönberg
4f4a875ebe
Add a marker and circle of accuracy for current location
...
Currently the user's position is not visible on the map. This
commit adds a marker to the user's position and a circular
polygon which shows the accuracy of the location measurement.
2017-05-28 17:53:33 +02:00
Tobias Schönberg
db5dbbfdfd
Fix crash of nearby list when the places list is null
...
Currently the NearbyController crashes when it is called with a
places list that is null. This is caused by the NearbyMapFragment
not handling this state correctly.
This commit adds tests for an empty list and null, which reproduce
the problem. An early return in the NearbyController can make
the tests pass, but might not be the best solution for this issue.
2017-05-24 22:15:38 +02:00
Vivek Maskara
0e71e817b6
Merge pull request #641 from sandarumk/fix_lint_issues
...
Fix lint issues
2017-05-20 19:11:07 +02:00
maskara
75f3fe4ed6
Fixed codacy issues
2017-05-20 13:43:47 +02:00
maskara
4823486139
Add popup menu in nearby info dialog
2017-05-20 13:09:16 +02:00
Dinu Kumarasiri
83957bae06
[Lint] Remove class variables to local
2017-05-20 11:53:46 +02:00
maskara
5fc9f84e79
Fixes #614 : Crash: Fragment State loss exception
2017-05-19 15:44:15 +02:00
Josephine Lim
f6a7759317
Merge pull request #600 from whym/nearby-file
...
Read once and reuse the query file's content
2017-05-19 15:36:49 +02:00
Yusuke Matsubara
f039ec37bc
Merge pull request #596 from domdomegg/codestyle
...
Lint issues
2017-05-17 20:15:10 +09:00
Yusuke Matsubara
22f5f51082
Read once and reuse the query file's content
2017-05-17 17:08:31 +09:00
addshore
c712b561d4
Get rid of other singletons
2017-05-16 15:19:43 +02:00
addshore
bdfbdc7579
Cleanup CommonsApplication Singelton
2017-05-16 15:19:15 +02:00
maskara
583a47e2b4
Fixes #587 : Remove trailing carriage return
2017-05-16 13:11:54 +02:00
maskara
ddd5e602a9
Fixed nearby query to show read article link only for wikipedia articles
2017-05-16 12:46:05 +02:00
maskara
a6bbc8a33b
With NavigationBaseActivity implemented
2017-05-16 11:58:54 +02:00
maskara
09cd596ff6
Integrated navigation drawer in the contributions activity
2017-05-16 11:57:07 +02:00
Yusuke Matsubara
04ea68333b
Print radius with a limited number of digits + reduce debug output
2017-05-16 12:40:48 +09:00