Commit graph

428 commits

Author SHA1 Message Date
Vivek Maskara
02fe0044a6 Merge release branch to master (#1932)
* Bugfix/upload via share (#1920)

* Bug Fix #1878
* Added a java library to fetch the MIME type from input stream
* Fetch MIME type using this and use the contribution tag only when this fails:

* formatting changes, removed unused commented out line

* Versioning and changelog for v2.8.5 (#1923)

* Versioning for v2.8.5

* Update changelog.md
2018-10-13 19:45:00 +11:00
Edward Savage
e36a71a584 Optimize imports (#1927) 2018-10-13 18:31:25 +11:00
Dmitry Brant
e0a79f89e9 Fix crash(es) due to uninitialized notification channel. (#1906)
* Fix crash(es) due to uninitialized notification channel.

The notification channel needs to be created for API versions greater than
OR EQUAL to 26 (O).  Also, the channel does not need to be reinitialized
if it already exists.

* Initialize notification channel when Service is created.
2018-09-28 01:39:32 +10:00
Ashish Kumar
70099a9014 Feature/permissions library (#1855)
* Added permission for Dexter, the runtime permission handling library

* [Preparing fir issue #1773] Added a utility function which would take the user to app settings screen where he could manually give us the required permission

* Added an alert dialog with positive and negative callback [Preparing fir issue #1773]

* Improvements in the way External Storage Permission is handled in MultipleShareActivity[Bug fix #1697]
1. Used dexter to handle the external storage permission
2. Behaviour changes : When user tries to share(uppload) images to commons via MultipleShareActivity, following decision tree is followed
	a. If the app has permission for external storage, normal upload operation is followed
	b. If the app does not has the permission for external storage, dexter is used to ask for the same
	c. If the user gives us the required permission, normal upload flow is proceeded
	d. If the doesnot gives us the required permission a rationale dialog is shown with the appropriate message to let him know why we need the permission
	e. If he presses okay, steps a-c are followed and if he presses cancel, we close the app.
	f. If while asking for permission, the user chooses never ask again, then next time he tries to upload an image via MSA, the rational dialog follows the app setting screen where he could manually give us the required permission and the onActivityResult of same is handled

* Added a Constants class to handle request and result codes from one place and other related constants common to the all app elements

* replaced hardcoded strings ok and cancel in DialogUtil to string resources

* init permission rationale dialog in activities onCreate

* Code formatting, updated access modifiers wherever required, added javadocs for new methods created

* *shifted constants to app class
*Added JavaDocs in PermissionUtils

* removed class REQUEST_CODES from CommonsApplication and instead put the enclosing constants in the App class itself
2018-09-07 02:57:07 +10:00
Yusuke Matsubara
6842420aeb Use NotificationChannel and prevent crash in API 26 (#1835) 2018-08-19 13:19:00 +03:00
Nicolas Raoul
e00f69a23d Merged from 2.8-release 2018-08-08 15:07:51 +09:00
Vivek Maskara
b5e90bea76 Wikidata edit fix (#1800)
Wikidata edit fix
2018-08-07 19:03:59 +10:00
Nicolas Raoul
f12f1d50a3 Merge branch 'skip_login' of github.com:ujjwalagrawal17/apps-android-commons 2018-08-07 13:12:00 +09:00
misaochan
23014e07c8 Merge remote-tracking branch 'refs/remotes/origin/2.8-release' 2018-08-06 18:36:35 +10:00
Vivek Maskara
143ad00149
Fix failed uploads (#1790)
* Cusom Mediawiki api layer

* Fix tests
2018-08-05 01:26:00 +05:30
Josephine Lim
e32f8d3d36 Fix title/desc prefill bug (#1794)
* Move isDirectUpload putExtra above Wikidata edits try catch block

* Check value of boolean isDirectUpload in intent

* Change to getBooleanExtra to prevent NPE

* Fix whitespaces, logging, and lint issues
2018-08-04 21:33:31 +05:30
misaochan
f46da6639c Merge branch 'master' of https://github.com/commons-app/apps-android-commons 2018-08-04 19:29:55 +10:00
Ashish Kumar
12a83da3a2 Feature/localised image descriptions (#1634)
* wip

* Changes for adding descriptions in multipe languages[issue #1501]

* Added callback for the adapter

* Codacy suggested changes

* Sort the languages in the spinner in alphabetical order

* scroll view nested scrolling enabled false

* Nested scrolling enabled false [Allow rv to expand]

* rebased to master, resolved conflicts

* replaced setCompoundDrawables with setCompoundDrawablesWithIntrinsicBounds [the former dint used to work on all devices]

*     replaced setCompoundDrawables with setCompoundDrawablesWithIntrinsicBounds [the former dint used to work on all devices]
2018-08-03 18:09:37 +05:30
Ujjwal Agrawal
bf58fcab59 Fixed upload from gallery 2018-08-02 15:02:23 +05:30
neslihanturan
d29aa2e2e5 Fix urgent crashes A and E (#1749)
* Create utility class for contribution process

* implement method to save five from given URİ

* Add file utilities for directory checks

* Add ContributionUtils for saving file during upload

* Change method call acordingly with handleImagePicked() method

* Call method to save file temproarily when a photo to upload is chosen from contributions list.

* Call method to save file temproarily when a photo to upload is chosen from nearby list and map

* Arrange method call

* Write a method to save file temporarily during upload process. It will save the file to a internal path and it will be deleted by another method after upload process is done.

* Add a method to save a file to a given path from a content provider Uri

* On openAssetFileDescriptor method, use URi from temporarily saved file, instead of Contributions.getLocalUri which was Uri from content provider

* Edit uploadContribution method so that it will use FileInputStream from temporarily saved file, insdeat of the Uri from content provider.

* Make it work

* Code cleanup

* Add directory cleaner method

* Call temp directory cleaner method at the end of uplpoad process

* Use FileInputStream insted

* Add directory cleaner method

* Add file removal method

* Use external directory instead

* Make destination file name flexible

* Make it work with share action coming from another activity

* Make it work for Multiple hare Activity

* Code cleanup

* Solve camera issue

* Fix camera crash

* Cleanup

* Revert change of commenting out posibly useles code, because I am not sure if it is useless or not. Requires discussion

* Use timestamp in temoorary file names, so that we wont never create same file and access old file reference. It was a weird problem though

* Code cleanup

* Add nullable annotation to handleImagePicked method uri parameter

* Add Nullable anotation to method

* Code cleanup

* Bugfix: use uri.getPath() instead uri.toString

* Remove unecesarry file saving operation, which was added accidentally

* Fix travis fail

* Remove temp file if upload gets failed and file is still there

* Code cleanup:Remove unused parameters from removeTempFile method

* Empty temp directory on app create, in case some of files are still there

* Add null check to array to prevent NPE on first run

* Fix multiple uploads bug

* Remove file if upload is succeed

* Add external storage utility methods

* Check external file permission before saving files temporarily

* finish activity if permission is not granted

* Add log lines

* Remove files even if user decides to go back without sharing

* Add easy null check

* Change storage permission settings in singe upload fragment too

* Finish app if permission is not granted

* Code optimisation

* Remove temp file if upload process never is finalised on activity stop

* Bugfix maybe contribution is never created

* Fix travis build
2018-08-02 06:24:08 +10:00
albendz
0678410eea Add a string to tell the user to name their multi image set 2018-08-01 12:07:24 +09:00
Ujjwal Agrawal
23a195f486 Share from gallery for not loggedin fixed 2018-08-01 02:55:07 +05:30
albendz
6aa0f250f3 Provide toast to request title in multi upload share when title is empty 2018-07-30 11:57:01 -07:00
misaochan
d05cf395d8 Merge remote-tracking branch 'origin/2.8-release' into 2.8-release
# Conflicts:
#	app/build.gradle
#	app/src/main/java/fr/free/nrw/commons/di/CommonsApplicationModule.java
2018-07-28 23:39:15 +10:00
neslihanturan
faee423105
Merge pull request #1596 from tanvidadu/imageLicense
Introducing a brief exp of Image License
2018-07-22 15:33:55 +03:00
Vivek Maskara
25b463901f Fix conflict between different product flavors (#1726)
* Fix conflict between different product flavors so that beta and prod apps could coexist

* Fix category content provider
2018-07-20 02:03:28 +10:00
ShridharGoel
a083373285
Merge branch 'master' into master 2018-07-17 20:16:42 +05:30
misaochan
f1f41e59f7 Merge remote-tracking branch 'refs/remotes/origin/2.8-release' 2018-07-11 00:45:02 +10:00
Vivek Maskara
2d831c089d
Merge pull request #1644 from misaochan/fix-automatic-location
Remove current location retrieval from upload process entirely
2018-07-07 22:50:41 +05:30
Vivek Maskara
b2a150a3ae Fix issue where Wikidata edits were not happening (#1682)
* Added logs to debug wikidata edits

* Minor changes in logs
2018-07-05 20:13:37 +10:00
misaochan
107729cdf0 Merge remote-tracking branch 'refs/remotes/origin/2.8-release'
# Conflicts:
#	app/build.gradle
2018-07-05 01:00:51 +10:00
Vivek Maskara
306f23d1e2 Force login when no active session is found while uploading an image (#1684)
* Force login when no active session is found while uploading an image

* Updated not logged in message
2018-07-04 00:29:26 +10:00
Shridhar Goel
90705996a8 Fixes crash when uploading image via share without logging in 2018-06-28 19:57:11 +05:30
ShridharGoel
05def522af
Merge branch 'master' into master 2018-06-28 18:40:08 +05:30
Shridhar Goel
e7270783e4 Fixed crash when uploading image via share without login 2018-06-28 16:10:36 +05:30
misaochan
43d9f0db07 Merge branch 'master' of https://github.com/commons-app/apps-android-commons 2018-06-23 20:35:17 +10:00
misaochan
b5161d64a6 Remove location constant from ShareActivity 2018-06-23 20:13:15 +10:00
misaochan
3ab3b028c4 Optimize imports in ShareActivity 2018-06-23 20:11:31 +10:00
misaochan
798bcbad7f Tidy onRequestPermissionsResult 2018-06-23 20:11:00 +10:00
misaochan
4340d655c4 Remove snackbar from ShareActivity 2018-06-23 20:10:26 +10:00
misaochan
4a5257c2c7 Optimize FileProcessor 2018-06-23 20:07:06 +10:00
misaochan
be5c05435e Remove prefs var in GPSExtractor 2018-06-23 20:04:47 +10:00
misaochan
fe3dda18ce Remove boolean useGPS entirely 2018-06-23 20:03:13 +10:00
misaochan
0b58e28ba5 Remove LocationListener from GPSExtractor 2018-06-23 20:01:58 +10:00
misaochan
7d3e3ae668 Fix other GPSExtractor vars, logs and imports 2018-06-23 20:01:36 +10:00
misaochan
0fd77a1c60 Remove context in other constructor 2018-06-23 20:00:50 +10:00
misaochan
927ceb9aba Remove unnecessary context var 2018-06-23 19:59:19 +10:00
misaochan
df7a944c78 Remove unused methods in GPSExtractor 2018-06-23 19:53:03 +10:00
dlsrks1021
e8b2dd7163 remove unused imports (#1606) 2018-06-21 07:28:27 +09:00
misaochan
801fea631f No need to unregisterLocationManager() as it should never be registered 2018-06-19 20:54:28 +10:00
misaochan
fa238b94aa Do not display Snackbar to get location permissions 2018-06-19 20:52:42 +10:00
misaochan
e8925f5a02 Add TODO 2018-06-19 20:36:01 +10:00
misaochan
371580bf5e Always return null if image has no EXIF data 2018-06-19 20:34:52 +10:00
misaochan
0b0c01d3ac Always return false for gpsPreferenceEnabled() 2018-06-19 20:33:10 +10:00
Tanvi Dadu
ac2de1a1fe back button functionality (#1517) 2018-06-19 18:06:55 +10:00