Commit graph

495 commits

Author SHA1 Message Date
Dmitry Brant
013e1a5430 Fix crash(es) upon upload failure. (#2699)
* Fix crash(es) upon upload failure.

* Further improve Rx structure.
2019-03-21 19:09:36 +03:00
Dmitry Brant
8474c04c64 Fix crash(es) caused by failing to dispose Rx observables (#2669) 2019-03-19 21:08:04 +00:00
Dmitry Brant
adf23c257f Improve extremely inefficient darkness-checking logic. (#2639)
* Improve extremely inefficient darkness-checking logic.

* Use ExifInterface from AndroidX instead of android.media.

* Fix false-positive detekt check.

* Fix false-positive detekt check.
2019-03-19 20:23:36 +05:30
Adam Jones
cfb06f3103 Remove CustomEditText (#2640) 2019-03-19 17:42:01 +03:00
Vanshika Arora
3417d713d2 Fixes #97: Added metadata reader for reading exif data (#2581)
* initial commit

* initial commit

* reading 3 exif directories

* minor changes

* fixed unit tests

* reviwied requested changes

* minor changes

* minor changes
2019-03-19 19:08:42 +05:30
Bence Konya
66ba35a15f Fix #2205: Fix upload card view arrow direction error (#2653) 2019-03-18 21:03:51 +00:00
Yusuke Matsubara
ee7af37d00 Stash upload (#2505)
* Introduce Single<UploadResult>

* Two stage upload process

- split upload process and use stash
- resolve filename conflict after upload not before
- use NotificationManagerCompat; add notification tag; assign temporaty stash file name
2019-03-18 21:07:29 +05:30
Vanshika Arora
38dceddbf5 resolved issue #2542 with position of map icon (#2601)
* resolved issue #2542

* removed commented code
2019-03-17 15:42:57 +05:30
Vivek Maskara
7cb87f3cab Consolidate shared prefs to a single store (#2613)
* Consolidate shared prefs to a single store
* Fix achievements activity
* Fix store usage
2019-03-16 13:56:56 +00:00
Vivek Maskara
6cbce9d283 Fix #1131: Update min sdk version and remove redundant checks (#2608) 2019-03-16 12:21:51 +00:00
Vanshika Arora
900bd4ff2f Fix #2563: Uploading from wikidata with "?" description (#2586) 2019-03-16 12:10:29 +00:00
Vivek Maskara
57e685cf6c Fix #2593: Migrate to androidX (#2594)
* Update dependencies and migrate to androidX
* Make gradle properties tidy
2019-03-16 11:22:37 +00:00
Zhao Gang
62c14ecb66 Make DeleteTask notification quieter on some devices(Fixed #2528) (#2538)
As commit ab4fca5e does, this commit fixed the repeated notification
alarms in DeleteTask.class.

Since progress indication in notification can be cleared by calling
.setProgress(0,0,false) on notificationBuilder(As shown in DeleteTask.class).
This commit also refactored notification related code in UploadService.class.
Make progress and failed notification uses the same notificationBuilder.
2019-03-12 14:19:09 +03:00
Zhao Gang
52724b8be0 Add setting Picture_Has_Correct_Location prefs(Fixed #2530) (#2536)
Update Picture_Has_Correct_Location prefs in method handleImage. This
fixed an issue that this prefs is not set and related wikidata
can't be updated.
2019-03-12 17:02:51 +09:00
Vanshika Arora
6389b35b49 replaced icafe with metadata extractor (#2546)
* replaced icafe with metadata extractor

* replaced icafe with metadata extractor

* removed icafe from gradle

* removed icafe from gradle

* Revert: travis commented code

* Use original content URI

* merged pr

* commit after merge

* modified unit tests
2019-03-12 00:20:47 +05:30
Vanshika Arora
2e23658b77 resolved rtl issue in category (#2567)
* resolved rtl issue in category

* combined nested if

* modified code
2019-03-11 21:39:29 +05:30
Vanshika Arora
d1a7b2cbfe resolved progressbar overlap issue (#2575) 2019-03-11 21:37:49 +05:30
Ronan Brigdale
480c05b2f3 Fix Lint Issues #171: Fix numerous errors/warnings (#2537) 2019-03-10 23:55:35 +05:30
Ronan Brigdale
de9a72d465 Fix Lint Issues #171: Remove unused imports (#2533)
* Fix Lint Issues #171: Remove unused imports

Removed unused Java imports

* Fix Lint Issues #171: Perfromance issue, close cursor

Cursor was not closed when no longer needed
2019-03-02 19:30:50 +05:30
Zhao Gang
ab4fca5ea9 Make uploading file notification quieter on some devices(Fixed #2528) (#2529)
Add setOnlyAlertOnce flag to NotificationCompat.Builder. This fixed
the issue that notification makes an alarm(beep) every time uploading
progress updated on some devices.

Also let UploadService.class reuse NotificationCompat.Builder as much
as possible(instead of creating a NotificationCompat.Builder every
time in method uploadContribution). And some small refactors.
2019-03-01 06:12:47 +13:00
Shridhar Goel
6365815e0d Toggle state of bottom card on click (#2391) 2019-02-27 02:03:59 +05:30
Vanshika Arora
3a822d3c30 Added IPTC reader (#2383)
* graddle changes

* readfbmd class

* jar files

* added icafe

* gradle changes

* ReadFBMD

* recent commit

* commit changes

* commit changes

* fixed code quality issues

* optimised imports

* changes for  reviews

* not instantiating class

* removed irrelevant code

* added documentation

* modified test cases

* commit changes

* modified variable

* modified variable

* javadoc

* test changes

* removed .log file

* Show warning dialog for FBMD
2019-02-24 23:16:22 +05:30
Vivek Maskara
546322ac35
Fix update date template based on date source (#2483) (#2492)
* Fix update date template based on date source

* Add javadocs
2019-02-20 20:14:19 +05:30
Vivek Maskara
d1e9b2f801 Fix errors while making image quality checks (#2444) 2019-02-13 23:04:15 +13:00
Vivek Maskara
2bc0d41748 Fix date time issue for google photos (#2438) 2019-02-13 00:17:06 +13:00
Vivek Maskara
52ab39381e Add module for file picker for camera and gallery uploads (#2375)
* Use easy image for image picker

* Do not use harcoded mime type

* Use uploadable file for image uploads

* Add picker files in filepicker module

* Remove redundant checks for file

* Make usage of file extensions consistent

* Add javadocs

* Fix tests

* Enable image upload using bookmark activity

* Fix multiple uploads

* Fix external image uploads

* Fix chooser intents

* Fix image quality checks

* Segregate internal and external upload intents

* Invoke all error messages from one place

* Minor changes

* Fix tests

* Add image processing service tests
2019-02-03 22:40:31 +02:00
Vivek Maskara
16927057d0 Remove drawer layout from upload activity (#2380) 2019-02-01 23:31:28 +13:00
Vivek Maskara
2ba6ed622f Use channel ID while showing failed upload notification (#2322) 2019-01-30 12:04:00 +02:00
Shubham Pinjwani
34829938a0 fixed Toggling of top card expand button issue(#2363) (#2364)
* fixed Toggling of top card expand button issue(#2363)

* removed debugging code
2019-01-27 22:30:23 +05:30
Shubham Pinjwani
e82e3b9cb6 fixed image not visible in top card issue(#2354) (#2355)
* fixed image not visible in top card issue(#2354)

* some minor changes
2019-01-27 21:33:43 +05:30
Vivek Maskara
de9611821b Fix version number for alpha builds (#2325) 2019-01-24 23:32:16 +05:30
Vivek Maskara
e389a95592 Fix log file not being attached (#2316)
* Fix log file not being attached

* Add filter for email clients
2019-01-24 18:21:07 +10:00
Vivek Maskara
532ab8aeae Fix uploads getting stuck (#2309)
* Fix uploads getting stuck

* Fix test

* Use single instance of Gson across the app

* More logs to help debug upload failure

* Add request identifier

* wip

* Fix issues with image quality check dialogs
2019-01-24 17:56:18 +10:00
Shridhar Goel
aac0b7c52f Fix #2312: Prevent crash when internet connection is not available (#2320)
* Fixes crash when internet connection is not available

* Fixes crash when internet connection is not available

* Remove unused imports
2019-01-20 01:47:52 +05:30
Vivek Maskara
559127dfa3 Fix app stuck and memory issues while uploading images (#2287)
* Do not use an image array to store all bitmap pixels at once

* Extract image preprocessing to a different service and use computation thread

* Add java docs

* Cleanup code to remove temp file logic

* Add logs in upload flow

* Fix tests

* Fix more tests
2019-01-16 18:32:25 +02:00
Vivek Maskara
d4fa9cfa45 Use wrapper for interacting with shared preferences (#2288)
* Use wrapper for accessing shared preferences across the app

* Use Json kv store for storing place object

* Fix tests

* Fix test failure

* Fix UI tests
2019-01-14 00:13:21 +05:30
Vivek Maskara
164ef9bcac Use image picker to pick images for upload (#2278)
* Use image picker to pick images for upload

* Consolidate storage permissions in Upload activity

* With proper request codes for image upload

* Use constants for upload limits

* Check for request code while handling requests

* Let fragment initiate the camera/gallery instead of activity

* Delete unused external storage utils
2019-01-09 02:26:46 +10:00
sp2710
dabcd43a5b Removed default license settings, and implemented selecting last selected license as default licence(#2170) (#2218)
* Removed default license settings, and implemented selecting last selected license as default licence(#2170)
* Replace settings license tests with recent upload limit test
2019-01-04 15:26:39 +00:00
Vivek Maskara
e773a82206 Handle null URI while uploading picture (#2262)
* Handle null URI while uploading picture

* Modify cache method to never return null path

* Fix tests
2019-01-04 18:21:55 +10:00
Vivek Maskara
be98a56ba0 Improve text for receiving shared images (#2266) 2019-01-04 00:05:00 +10:00
DylanRobson
55113b3018 Fix issue #2164 Links open with handleWebUrl. (#2220)
* AboutActivity links now open with the in-app tabbed browser.
* UploadActivity license and policy links now open with the in-app tabbed browser.
2019-01-01 16:21:33 +05:30
Zhao Gang
af291a5fcc Fix #2163: Hide subtitle message when uploading a single image (#2169)
* Hide subtitle message when uploading a single image (#2163)

* updateSubtitleVisibility: Javadoc and replace if with ternary operator

* updateSubtitleVisibility: change findViewById to BindView

* Remove null checks for views

Null check is not required while binding views with butterknife.
2019-01-01 16:08:12 +05:30
Adam Jones
493fa6b721 Fix okay buttons in alert dialogs (#2206) 2018-12-21 17:30:36 +02:00
Adam Jones
f04503bb3e Lint issues (#2114)
* Dangling Javadoc comments

* Replace for loop with foreach

* Explicit type can be replaced with <>

* Anonymous type can be replaced with lambda

* Lambda can be replaced with method reference

* Remove redundant methods

* Use capital L for long literals

* Remove unnecessary StringBuilder
2018-12-21 13:09:04 +02:00
Hariharan
8e967a3698 UploadController: Added support for using author names. Fixes #1707. (#1856)
* UploadController: Added support for using author names. Fixes #1707.

* Minor PR tidy-up

* Reword preference item

* Null check to pass startUpload test
2018-12-21 12:52:59 +02:00
Reid
809c0c32d7 Add missing Javadocs to License, Media, and Utils classes (#1965)
* Add missing Javadocs to License, Media, and Utils classes
2018-12-20 21:12:18 +00:00
briancollins-92
fcd5432f74 Fix 2072: default license selector in Settings (#2084)
* SharedPreferences Dep Injection added, updateLicense() updated

method updateLicense() was previously looking to the UploadModel for the
current default license, this has now been changed so that it gets it from
a SharedPreferences object

* UploadModel.license aligned to SharedPreferences

variable UploadModel.license within the constuctor is now assigned to the string of the
"default_license" value within SharedPreferences

Admittedly this may not be completly necissary as UploadModel.license is modified via
UploadPresenter.updateLicense on creation.
2018-12-20 18:10:06 +00:00
Josephine Lim
21edcb7cbe
Retry failed uploads - #1556 Allow users to easily re-upload failed uploads... (#2112)
* Add cancel and retry buttons on layout contribution

* Make sure your retry logic works

* Add cancel method too

* Add javadocs and remove debug logs

* Remove two unused methods

* Remove old and unused retry buttons as we do for their functions

* Check internet connection before button function, since function requires internet connection

* Remove unused variable

* Display possible solution for badtoken error

* Fix string
2018-12-20 02:56:00 +10:00
Zhao Gang
db38174eb4 Fix #2156: Add plural support for share_license_summary string (#2161) 2018-12-18 17:29:11 +00:00
sp2710
1d80cbaac9 fixing issue#2131: same description for all photos in multiple uploads (#2132)
* fixing same description in multiple uploads issue(#2131)

* Remove setNewDescription method
2018-12-18 21:14:30 +05:30