Shashank Kumar
f73c9dc4d3
Migrate Upload Package To View Binding from Butterknife ( #5590 )
...
* Butterknife to ViewBinding
* Butterknife to ViewBinding
* code cleanup and tests fixed
* code cleanup and optimised imports
2024-03-15 14:37:28 -05:00
translatewiki.net
1b5df47362
Localisation updates from https://translatewiki.net .
2024-03-14 13:03:25 +01:00
Shashank Kumar
c94f607107
Migrated Contributions Package From Butterknife to ViewBinding ( #5593 )
...
* Butterknife to ViewBinding
* code fix to pass all tests
* test fix
* test fix
* test fix
* test fix
* Update ContributionsFragmentUnitTests.kt
* code cleanup and tests improved
* tests fixed
* adjustments and code cleanup
* adjustments and code cleanup
2024-03-12 21:16:55 -05:00
Shashank Kumar
2076bf9b29
Migrated Explore Package From Butterknife to ViewBinding ( #5592 )
...
* Butterknife to ViewBinding
* code cleanup and tests migrated to binding
* tests fixed
* adjustments and code cleanup
2024-03-11 15:48:37 -05:00
translatewiki.net
7b63185d5a
Localisation updates from https://translatewiki.net .
2024-03-11 13:02:23 +01:00
Shashank Kumar
6ed5deac65
Migrated Profile Package from Butterknife to View Binding ( #5591 )
...
* Butterknife to ViewBinding
* code fix to pass all tests
* code cleanup and tests migrated to binding
* fix LoD
2024-03-10 14:44:06 -05:00
Neel Doshi
dbe739e755
CodeCleanup : Removed Unused Import from packages. ( #5609 )
...
* CodeCleanup : Removed Unused Import from packages.
* Removed : value-yue-hant directory.
2024-03-08 23:21:27 +09:00
translatewiki.net
b5ce7c735d
Localisation updates from https://translatewiki.net .
2024-03-07 13:02:16 +01:00
Neel Doshi
28ea11127c
Refactor : API calls moved out of the LoginActivity ( #5599 )
...
* Refactor :API calls separated from activity added to LoginClient
* getLoginToken() modifier set to private
* Code Cleanup : removed non-null from twofactor and Locale import
* Indentation fix
2024-03-06 08:35:50 -06:00
translatewiki.net
2c376da46e
Localisation updates from https://translatewiki.net .
2024-03-04 13:02:19 +01:00
translatewiki.net
9e5854766e
Localisation updates from https://translatewiki.net .
2024-02-29 13:02:11 +01:00
translatewiki.net
55346c125b
Localisation updates from https://translatewiki.net .
2024-02-26 13:02:48 +01:00
Shashank Kumar
f5a5159f8c
Fix Crash Edit Categories Fragment ( #5510 )
...
* fix crash
* Tests Added
* Tests and Null Checks Added
2024-02-26 18:42:51 +09:00
Ivan C. Acha
535792390e
Changed line break behaviour. ( #5562 )
...
Added line breaks to PageContentsCreator.java, CategoryEditHelperUnitTests.kt, and MediaDetailFragmentUnitTests.kt following the example given on issue #5523 .
2024-02-25 23:00:45 +09:00
translatewiki.net
0656c88fbe
Localisation updates from https://translatewiki.net .
2024-02-22 13:02:22 +01:00
Paul Hawke
f0a1d036a5
Convert upload client to kotlin ( #5568 )
...
* Write unit tests for the UploadClient (with gentle refactoring to make it testable)
* Convert Upload client to kotlin
2024-02-21 15:55:35 +09:00
Paul Hawke
728712c4e1
Convert API clients to kotlin ( #5567 )
...
* Convert UserClient to kotlin
* Added tests for WikiBaseClient
* Removed superfluous dao tests in review helper and got the proper ReviewDaoTest running in the unit test suite
* Improved tests for ReviewHelper
* Convert the ReviewHelper to kotlin
* Convert the WikiBaseClient to kotlin
* Convert the WikidataClient to kotlin
2024-02-20 09:23:11 +09:00
translatewiki.net
c43405267a
Localisation updates from https://translatewiki.net .
2024-02-19 13:02:18 +01:00
Rohit Verma
9a8b89c19a
nearby: Show 'no images in this area' message instead of generic error ( #5541 )
2024-02-18 15:02:19 +00:00
tamojitdas
74f2e9cd60
fix: unit tests for switching from MapBox to OpenStreetMap ( #5536 )
...
Fixes #5408
2024-02-18 14:06:40 +00:00
Kanahia
26658e91b3
Removed MAPBOX Access token ( #5555 )
...
* Update gradle.properties
* Update build.gradle
* Update CommonsApplication.java
* Update LocationServiceManager.java
2024-02-16 20:56:58 +09:00
Shashank Kumar
4c5d690a9e
Fix Crash When Explore Tab is Clicked ( #5550 )
2024-02-15 22:54:10 +09:00
Kwong Yu Zhou
013bc7db39
Replaced campaignPreference with CAMPAIGNS_DEFAULT_PREFERENCE ( #5357 )
...
Co-authored-by: Kwong Yu Zhou <https://github.com/kwong-yu-zhou >
Co-authored-by: Adam Jones <domdomegg+git@gmail.com>
2024-02-14 21:23:23 +00:00
Shashank Kumar
2d5b7cc579
Fix DNG/RAW Upload Error ( #5543 )
...
* Fix DNG/RAW Upload Error
* Fix DNG/RAW Upload Error
* supported formats added
* cleanup
2024-02-14 21:09:48 +09:00
Adam Jones
1cbce77d5f
Migrate from Kotlin synthetics to Jetpack view binding ( #5546 )
2024-02-14 18:29:06 +09:00
Shashwat Kedia
b18117bc07
Resolved Problems in UploadMediaDetails flow and UX #5511 ( #5527 )
...
* Fixed arrow flickering issue on zoom
* Resolved issue point 1 and 3
* Resolved issue point 2
* Minor changes
* Update UploadActivity.java
---------
Co-authored-by: Nicolas Raoul <nicolas.raoul@gmail.com>
2024-02-14 18:07:51 +09:00
Shashank Kumar
a308a1c8b5
Fix Methods Usage Incompatible with Android API Level 21 ( #5525 )
2024-02-14 09:05:13 +00:00
Shashank Kumar
8df7f66992
Show Labels For FAB in Contribution Page ( #5493 )
2024-02-13 21:33:03 +00:00
translatewiki.net
d8b7e27b48
Localisation updates from https://translatewiki.net .
2024-02-12 13:02:39 +01:00
Shashank Kumar
1895bb3ec2
Fix - Unable to Access Privacy Policy ( #5534 )
...
* Fix - Unable to Access Privacy Policy
* cleanup
2024-02-11 21:11:20 +09:00
Paul Hawke
f9090b0c2c
Consistent api interfaces ( #5530 )
...
* Converted CategoryInterface to kotlin
* Converted DepictsInterface to kotlin
* Convert the MediaDetailInterface to kotlin
* Convert MediaInterface to kotlin
* Convert ReviewInterface to kotlin
* Convert the UserInterface to kotlin
* Convert the WikiBaseInterface to kotlin
* Convert WikidataInterface to kotlin
* Convert WikidataMediaInterface to kotlin
* Convert UploadInterface to kotlin
2024-02-09 13:43:01 +09:00
Paul Hawke
c6cb97e199
Add ability to suppress logging of known unsuccessful API calls ( #5526 )
2024-02-09 06:55:56 +09:00
translatewiki.net
ba11f0d06e
Localisation updates from https://translatewiki.net .
2024-02-08 13:02:19 +01:00
translatewiki.net
a534c11bbb
Localisation updates from https://translatewiki.net .
2024-02-05 13:03:06 +01:00
Paul Hawke
0c3085257d
Data client simplification / removal ( #5507 )
...
* Removed unused code from the data client module
* Move remaining code out of the data-client and remove it
2024-02-03 10:26:06 +09:00
Shashank Kumar
72a6fd2c90
Enhancement - Nearby banner shows Item without image ( #5468 )
...
* Enhancement Nearby banner shows Item without image
* spacing
* Enhancement Nearby banner shows Item without image
* spacing
* Fix Crash
* Reverted "Fix Crash"
This reverts commit a41c9362bb .
* Fixed
* Fix null location
* Fix Conflict
* Show Only Items that exists
---------
Co-authored-by: shashankkumar <shashankkumar45556@gmail.com>
Co-authored-by: Nicolas Raoul <nicolas.raoul@gmail.com>
2024-02-01 22:17:52 +09:00
translatewiki.net
60046f4881
Localisation updates from https://translatewiki.net .
2024-02-01 13:02:45 +01:00
Paul Hawke
8db0b54929
Remove the data-client app adapter implementation ( #5499 )
...
* logErrorsInsteadOfCrashing only ever returned false, so remove it and simplify logger
* Removed unused getMediaWikiBaseUrl()
* Removed getDesiredLeadImageDp() from commons app adapter, since it's unused
* Inlined the isLoggedIn() method of the app adapter
* Inline the app adapter username/password
* Removed the unused getRestbaseUriFormat() from the commons app adapter
* Remove references to the data-client SharedPreferenceCookieManager
* Manage our own OkHttpClient and remove the AppAdapter implementation
2024-01-31 10:21:43 +09:00
Paul Hawke
ab9e57f5be
Decouple from the data-client service factory, with some code cleanup in the process ( #5496 )
2024-01-30 07:46:01 +09:00
translatewiki.net
7ec2a22fce
Localisation updates from https://translatewiki.net .
2024-01-29 13:03:35 +01:00
Shashank Kumar
8bafee3801
Enhancement-Show Icon Labels When Long Pressed ( #5492 )
...
* Enhancement-Show Icon Labels when Long Pressed
* Tests Added
2024-01-29 17:05:43 +09:00
Nicolas Raoul
a8545abff2
Merge remote-tracking branch 'origin/switch-to-commons-toolforge'
2024-01-29 15:35:33 +09:00
Rohit Verma
9f7e407181
DepictsFragment: add null check for media ( #5488 )
2024-01-29 15:33:36 +09:00
Paul Hawke
84ffffbbe7
Create CsrfTokenClient and LoginClient by injection, along with a little cleanup ( #5491 )
2024-01-29 12:36:57 +09:00
Shashwat Kedia
5661e8c332
Fixed flickering of nearby banner compass ( #5486 )
2024-01-29 09:02:30 +09:00
Kaartic Sivaraam
f1276e4697
Fix broken reference to a missing resource ID
...
Seems like a fallout of the change done in PR #5464
This hopefully should make the instrumentation tests resume.
2024-01-28 17:53:27 +05:30
Kaartic Sivaraam
805076ee6b
Update test case for the toolforge URL change
2024-01-28 17:09:43 +05:30
Kaartic Sivaraam
611f40801e
Switch to using the commons toolforge instance fully
...
So far we used both the urbanecmbot instances and also the commons-android-app
toolforge instance for the functioning of the app.
The reality is that the commons-android-app instance itself had the ability
to return all the data necessary for the app. Use the same to get all the
data necessary for the app.
Fixes #5462
2024-01-28 14:27:13 +05:30
Paul Hawke
9e970123fd
Removed references to the data-client Service interface ( #5484 )
2024-01-28 08:25:56 +09:00
Shashwat Kedia
8222c4a42c
Resolves Issue #5413 Crash when opening Nearby when location permission hasn't been granted yet ( #5418 )
...
* Resolves Issue #5413
* Added Javadoc and formatted code
2024-01-27 22:47:36 +09:00