From 2df1cdfbd9d5591a0ca49b8eb030e4b5042325de Mon Sep 17 00:00:00 2001
From: veyndan <veyndan89@gmail.com>
Date: Sun, 16 Apr 2017 21:35:09 +0100
Subject: [PATCH] Reduce scope of places field

---
 .../free/nrw/commons/nearby/NearbyListFragment.java | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/app/src/main/java/fr/free/nrw/commons/nearby/NearbyListFragment.java b/app/src/main/java/fr/free/nrw/commons/nearby/NearbyListFragment.java
index 47d3dada1..e7aedd249 100644
--- a/app/src/main/java/fr/free/nrw/commons/nearby/NearbyListFragment.java
+++ b/app/src/main/java/fr/free/nrw/commons/nearby/NearbyListFragment.java
@@ -40,8 +40,6 @@ public class NearbyListFragment extends ListFragment implements TaskListener {
 
     private boolean isTaskRunning = false;
 
-    private List<Place> places;
-
     private static final String TAG = NearbyListFragment.class.getName();
 
     public NearbyListFragment() {
@@ -145,15 +143,14 @@ public class NearbyListFragment extends ListFragment implements TaskListener {
 
         @Override
         protected List<Place> doInBackground(Void... params) {
-            places = loadAttractionsFromLocation(
+            return loadAttractionsFromLocation(
                     ((NearbyActivity)getActivity()).getLocationManager().getLatestLocation()
             );
-            return places;
         }
 
         @Override
-        protected void onPostExecute(List<Place> result) {
-            super.onPostExecute(result);
+        protected void onPostExecute(List<Place> places) {
+            super.onPostExecute(places);
 
             if (isCancelled()) {
                 return;
@@ -164,14 +161,14 @@ public class NearbyListFragment extends ListFragment implements TaskListener {
 
             listview.setAdapter(adapter);
 
-            listener.onTaskFinished(result);
+            listener.onTaskFinished(places);
             adapter.notifyDataSetChanged();
         }
     }
 
     @OnItemClick(R.id.listview)
     void onItemClicked(int position) {
-        Place place = places.get(position);
+        Place place = (Place) listview.getItemAtPosition(position);
         LatLng placeLatLng = place.location;
 
         double latitude = placeLatLng.latitude;