From 234c7ccd485aab0d579dfb241217a973c8eb2cbc Mon Sep 17 00:00:00 2001 From: Josephine Lim Date: Sun, 4 Oct 2015 23:56:57 +1300 Subject: [PATCH 1/3] Removed EVENT_EVENTLOGGING_CHANGE Object in CommonsApplication --- .../src/main/java/org/wikimedia/commons/CommonsApplication.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/commons/src/main/java/org/wikimedia/commons/CommonsApplication.java b/commons/src/main/java/org/wikimedia/commons/CommonsApplication.java index 65773886e..c593a1166 100644 --- a/commons/src/main/java/org/wikimedia/commons/CommonsApplication.java +++ b/commons/src/main/java/org/wikimedia/commons/CommonsApplication.java @@ -65,7 +65,7 @@ public class CommonsApplication extends Application { public static final Object[] EVENT_LOGIN_ATTEMPT = {"MobileAppLoginAttempts", 5257721L}; public static final Object[] EVENT_SHARE_ATTEMPT = {"MobileAppShareAttempts", 5346170L}; public static final Object[] EVENT_CATEGORIZATION_ATTEMPT = {"MobileAppCategorizationAttempts", 5359208L}; - public static final Object[] EVENT_EVENTLOGGING_CHANGE = {"MobileAppTrackingChange", 5369400L}; + public static final String DEFAULT_EDIT_SUMMARY = "Uploaded using Android Commons app"; From 23c73ab45a14f14049ee8d701841e75e698d35c6 Mon Sep 17 00:00:00 2001 From: Josephine Lim Date: Sun, 4 Oct 2015 23:58:08 +1300 Subject: [PATCH 2/3] Removed Prefs.TRACKING_ENABLED condition in SettingsActivity.java --- .../main/java/org/wikimedia/commons/SettingsActivity.java | 7 ------- 1 file changed, 7 deletions(-) diff --git a/commons/src/main/java/org/wikimedia/commons/SettingsActivity.java b/commons/src/main/java/org/wikimedia/commons/SettingsActivity.java index ee71d2f2c..a33026e48 100644 --- a/commons/src/main/java/org/wikimedia/commons/SettingsActivity.java +++ b/commons/src/main/java/org/wikimedia/commons/SettingsActivity.java @@ -54,13 +54,6 @@ public class SettingsActivity extends SherlockPreferenceActivity implements Shar } public void onSharedPreferenceChanged(SharedPreferences sharedPreferences, String key) { - if(key.equals(Prefs.TRACKING_ENABLED)) { - // We force log this, so it is logged even if EL is turned off - EventLog.schema(CommonsApplication.EVENT_EVENTLOGGING_CHANGE) - .param("username", app.getCurrentAccount().name) - .param("state", sharedPreferences.getBoolean(key, true)) - .log(true); - } } } From 3c2ff3d9d77204a89a82e1414dd5ef31310ed56e Mon Sep 17 00:00:00 2001 From: Josephine Lim Date: Sun, 4 Oct 2015 23:59:21 +1300 Subject: [PATCH 3/3] Removed usage tracking preference option in Settings layout file --- commons/res/xml/preferences.xml | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/commons/res/xml/preferences.xml b/commons/res/xml/preferences.xml index 00cba51b0..802e60b6d 100644 --- a/commons/res/xml/preferences.xml +++ b/commons/res/xml/preferences.xml @@ -1,12 +1,7 @@ - +