diff --git a/app/src/main/java/fr/free/nrw/commons/AboutActivity.java b/app/src/main/java/fr/free/nrw/commons/AboutActivity.java index a2f67a3bf..54e12fcf2 100644 --- a/app/src/main/java/fr/free/nrw/commons/AboutActivity.java +++ b/app/src/main/java/fr/free/nrw/commons/AboutActivity.java @@ -65,4 +65,10 @@ public class AboutActivity extends NavigationBaseActivity { Intent browserIntent = new Intent(Intent.ACTION_VIEW, Uri.parse("https://commons-app.github.io/\\")); startActivity(browserIntent); } + + @OnClick(R.id.about_rate_us) + public void rateApp(View view) { + + Utils.rateApp(this); + } } \ No newline at end of file diff --git a/app/src/main/java/fr/free/nrw/commons/Utils.java b/app/src/main/java/fr/free/nrw/commons/Utils.java index 817c39f24..48a8ce739 100644 --- a/app/src/main/java/fr/free/nrw/commons/Utils.java +++ b/app/src/main/java/fr/free/nrw/commons/Utils.java @@ -1,6 +1,8 @@ package fr.free.nrw.commons; import android.content.Context; +import android.content.Intent; +import android.net.Uri; import android.preference.PreferenceManager; import android.support.annotation.NonNull; @@ -159,4 +161,15 @@ public class Utils { return stringBuilder.toString(); } -} + + public static void rateApp(Context context) { + final String appPackageName = context.getPackageName(); + try { + context.startActivity(new Intent(Intent.ACTION_VIEW, Uri.parse("market://details?id=" + appPackageName))); + } + catch (android.content.ActivityNotFoundException anfe) { + context.startActivity(new Intent(Intent.ACTION_VIEW, Uri.parse("https://play.google.com/store/apps/details?id=" + appPackageName))); + } + return ; + } +} \ No newline at end of file diff --git a/app/src/main/java/fr/free/nrw/commons/theme/NavigationBaseActivity.java b/app/src/main/java/fr/free/nrw/commons/theme/NavigationBaseActivity.java index 5d577e73d..a2c85d50b 100644 --- a/app/src/main/java/fr/free/nrw/commons/theme/NavigationBaseActivity.java +++ b/app/src/main/java/fr/free/nrw/commons/theme/NavigationBaseActivity.java @@ -23,6 +23,7 @@ import fr.free.nrw.commons.AboutActivity; import fr.free.nrw.commons.BuildConfig; import fr.free.nrw.commons.CommonsApplication; import fr.free.nrw.commons.R; +import fr.free.nrw.commons.Utils; import fr.free.nrw.commons.WelcomeActivity; import fr.free.nrw.commons.auth.AccountUtil; import fr.free.nrw.commons.auth.LoginActivity; @@ -133,17 +134,6 @@ public abstract class NavigationBaseActivity extends BaseActivity Toast.makeText(this, R.string.no_email_client, Toast.LENGTH_SHORT).show(); } return true; - case R.id.action_rate: - drawerLayout.closeDrawer(navigationView); - final String appPackageName = getPackageName(); - Toast.makeText(this, appPackageName, Toast.LENGTH_SHORT).show(); - try { - startActivity(new Intent(Intent.ACTION_VIEW, Uri.parse("market://details?id=" + appPackageName))); - } - catch (android.content.ActivityNotFoundException anfe) { - startActivity(new Intent(Intent.ACTION_VIEW, Uri.parse("https://play.google.com/store/apps/details?id=" + appPackageName))); - } - return true; case R.id.action_logout: new AlertDialog.Builder(this) .setMessage(R.string.logout_verification) diff --git a/app/src/main/res/drawable-hdpi/ic_star_black_24dp.png b/app/src/main/res/drawable-hdpi/ic_star_black_24dp.png deleted file mode 100644 index 8ab80a622..000000000 Binary files a/app/src/main/res/drawable-hdpi/ic_star_black_24dp.png and /dev/null differ diff --git a/app/src/main/res/drawable-mdpi/ic_star_black_24dp.png b/app/src/main/res/drawable-mdpi/ic_star_black_24dp.png deleted file mode 100644 index 8da3c8f5c..000000000 Binary files a/app/src/main/res/drawable-mdpi/ic_star_black_24dp.png and /dev/null differ diff --git a/app/src/main/res/drawable-xhdpi/ic_star_black_24dp.png b/app/src/main/res/drawable-xhdpi/ic_star_black_24dp.png deleted file mode 100644 index 63490ed07..000000000 Binary files a/app/src/main/res/drawable-xhdpi/ic_star_black_24dp.png and /dev/null differ diff --git a/app/src/main/res/drawable-xxhdpi/ic_star_black_24dp.png b/app/src/main/res/drawable-xxhdpi/ic_star_black_24dp.png deleted file mode 100644 index abc65dfe8..000000000 Binary files a/app/src/main/res/drawable-xxhdpi/ic_star_black_24dp.png and /dev/null differ diff --git a/app/src/main/res/drawable-xxxhdpi/ic_star_black_24dp.png b/app/src/main/res/drawable-xxxhdpi/ic_star_black_24dp.png deleted file mode 100644 index e853bc683..000000000 Binary files a/app/src/main/res/drawable-xxxhdpi/ic_star_black_24dp.png and /dev/null differ diff --git a/app/src/main/res/layout/activity_about.xml b/app/src/main/res/layout/activity_about.xml index 76c51a4aa..4286371a9 100644 --- a/app/src/main/res/layout/activity_about.xml +++ b/app/src/main/res/layout/activity_about.xml @@ -104,6 +104,14 @@ + - - Thank you for making an edit %1$s mentioned you on %2$s. Toggle view - Rate Us + Rate Us