From fb9c88026b6fe036b51c41a153a94fc285840f5f Mon Sep 17 00:00:00 2001
From: parneet-guraya <gurayaparneet@gmail.com>
Date: Sat, 12 Oct 2024 02:09:34 +0530
Subject: [PATCH] remove unused result expectancy for settings screen launch

Signed-off-by: parneet-guraya <gurayaparneet@gmail.com>
---
 .../fr/free/nrw/commons/CommonsApplication.java    |  1 -
 .../fr/free/nrw/commons/upload/UploadActivity.java |  8 --------
 .../fr/free/nrw/commons/utils/PermissionUtils.java |  3 +--
 .../nrw/commons/upload/UploadActivityUnitTests.kt  | 14 --------------
 4 files changed, 1 insertion(+), 25 deletions(-)

diff --git a/app/src/main/java/fr/free/nrw/commons/CommonsApplication.java b/app/src/main/java/fr/free/nrw/commons/CommonsApplication.java
index c3dde9caa..3aceb957a 100644
--- a/app/src/main/java/fr/free/nrw/commons/CommonsApplication.java
+++ b/app/src/main/java/fr/free/nrw/commons/CommonsApplication.java
@@ -107,7 +107,6 @@ public class CommonsApplication extends MultiDexApplication {
     /**
      * Constants begin
      */
-    public static final int OPEN_APPLICATION_DETAIL_SETTINGS = 1001;
 
     public static final String DEFAULT_EDIT_SUMMARY = "Uploaded using [[COM:MOA|Commons Mobile App]]";
 
diff --git a/app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.java b/app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.java
index 23b187340..35906c3fb 100644
--- a/app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.java
+++ b/app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.java
@@ -441,14 +441,6 @@ public class UploadActivity extends BaseActivity implements UploadContract.View,
         super.onRequestPermissionsResult(requestCode, permissions, grantResults);
     }
 
-    @Override
-    protected void onActivityResult(int requestCode, int resultCode, Intent data) {
-        super.onActivityResult(requestCode, resultCode, data);
-        if (requestCode == CommonsApplication.OPEN_APPLICATION_DETAIL_SETTINGS) {
-            //TODO: Confirm if handling manual permission enabled is required
-        }
-    }
-
     /**
      * Sets the flag indicating whether the upload is of a specific place.
      *
diff --git a/app/src/main/java/fr/free/nrw/commons/utils/PermissionUtils.java b/app/src/main/java/fr/free/nrw/commons/utils/PermissionUtils.java
index 9082c1f0f..828ef2338 100644
--- a/app/src/main/java/fr/free/nrw/commons/utils/PermissionUtils.java
+++ b/app/src/main/java/fr/free/nrw/commons/utils/PermissionUtils.java
@@ -54,8 +54,7 @@ public class PermissionUtils {
         final Intent intent = new Intent(Settings.ACTION_APPLICATION_DETAILS_SETTINGS);
         final Uri uri = Uri.fromParts("package", activity.getPackageName(), null);
         intent.setData(uri);
-        activity.startActivityForResult(intent,
-            CommonsApplication.OPEN_APPLICATION_DETAIL_SETTINGS);
+        activity.startActivity(intent);
     }
 
     /**
diff --git a/app/src/test/kotlin/fr/free/nrw/commons/upload/UploadActivityUnitTests.kt b/app/src/test/kotlin/fr/free/nrw/commons/upload/UploadActivityUnitTests.kt
index d15fe06e5..938e595af 100644
--- a/app/src/test/kotlin/fr/free/nrw/commons/upload/UploadActivityUnitTests.kt
+++ b/app/src/test/kotlin/fr/free/nrw/commons/upload/UploadActivityUnitTests.kt
@@ -167,20 +167,6 @@ class UploadActivityUnitTests {
         activity.makeUploadRequest()
     }
 
-    @Test
-    @Throws(Exception::class)
-    fun testOnActivityResult() {
-        val method: Method =
-            UploadActivity::class.java.getDeclaredMethod(
-                "onActivityResult",
-                Int::class.java,
-                Int::class.java,
-                Intent::class.java,
-            )
-        method.isAccessible = true
-        method.invoke(activity, CommonsApplication.OPEN_APPLICATION_DETAIL_SETTINGS, 0, Intent())
-    }
-
     @Test
     @Throws(Exception::class)
     fun testReceiveSharedItems() {