mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-31 06:43:56 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix a couple more Rx/context inconsistencies. (#2715)

Browse source 
* Stop storing Context!

* Properly contain and dispose of observables.

* Add a few more containments of Rx observables.
This commit is contained in:
Dmitry Brant 2019-03-22 23:22:36 -04:00 • committed by Vivek Maskara
parent 7cb1f56165
commit f7302d4301
6 changed files with 76 additions and 92 deletions
Download patch file Download diff file Expand all files Collapse all files

4
app/src/main/java/fr/free/nrw/commons/upload/UploadPresenter.java
View file

@ -115,11 +115,11 @@ public class UploadPresenter {
List<Description> descriptions) {
Timber.e("Inside handleNext");
view.showProgressDialog();
uploadModel.getImageQuality(uploadModel.getCurrentItem(), true)
compositeDisposable.add(uploadModel.getImageQuality(uploadModel.getCurrentItem(), true)
.subscribeOn(Schedulers.io())
.observeOn(AndroidSchedulers.mainThread())
.subscribe(imageResult -> handleImage(title, descriptions, imageResult),
throwable -> Timber.e(throwable, "Error occurred while handling image"));
throwable -> Timber.e(throwable, "Error occurred while handling image")));
}
private void handleImage(Title title, List<Description> descriptions, Integer imageResult) {