From f66d02cd85a4e74a4f42870a867a8c539f7f3dec Mon Sep 17 00:00:00 2001 From: Adam Jones Date: Mon, 17 Dec 2018 09:20:04 +0000 Subject: [PATCH] Fix #2123: Remove unnecessary calls to getParentFragment() to avoid NPE (#2138) --- .../fr/free/nrw/commons/media/MediaDetailPagerFragment.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.java b/app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.java index 3db8258fb..76549b207 100644 --- a/app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.java +++ b/app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.java @@ -343,7 +343,7 @@ public class MediaDetailPagerFragment extends CommonsDaggerSupportFragment imple @Override public void onPageScrolled(int i, float v, int i2) { - if(getParentFragment().getActivity() == null) { + if(getActivity() == null) { Timber.d("Returning as activity is destroyed!"); return; } @@ -398,7 +398,7 @@ public class MediaDetailPagerFragment extends CommonsDaggerSupportFragment imple public Fragment getItem(int i) { if (i == 0) { // See bug https://code.google.com/p/android/issues/detail?id=27526 - if(getParentFragment().getActivity() == null) { + if(getActivity() == null) { Timber.d("Skipping getItem. Returning as activity is destroyed!"); return null; }