mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 04:43:54 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Bugfix/fix upload presenter tests (#3158)

Browse source 
* Revert "Merge branch 'backend-overhaul' into master"

This reverts commit 0090f24257, reversing
changes made to 9bccbfe443.

* * Fixed upload presenter tests
* Deleted app/src/main/res/values-en-gb/error.xml
This commit is contained in:
Ashish Kumar 2019-09-29 15:08:46 +05:30 • committed by Vivek Maskara
parent 844e0903f0
commit f64e6eb432
2 changed files with 1 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

10
app/src/main/res/values-en-gb/error.xml
View file

@ -1,10 +0,0 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- Authors:
* Cblair91
-->
<resources>
<string name="crash_dialog_title">Commons has crashed</string>
<string name="crash_dialog_text">Oops. Something went wrong!</string>
<string name="crash_dialog_comment_prompt">Tell us what you were doing, then share it via email to us. Will help us fix it!</string>
<string name="crash_dialog_ok_toast">Thank you!</string>
</resources>

8
app/src/test/kotlin/fr/free/nrw/commons/upload/UploadPresenterTest.kt
View file

@ -59,13 +59,7 @@ class UploadPresenterTest {
verify(view)?.isLoggedIn verify(view)?.isLoggedIn
verify(view)?.showProgress(true) verify(view)?.showProgress(true)
verify(repository)?.buildContributions() verify(repository)?.buildContributions()
val buildContributions = repository?.buildContributions() verify(repository)?.buildContributions()
buildContributions?.test()?.assertNoErrors()?.assertValue {
verify(repository)?.prepareService()
verify(view)?.showProgress(false)
verify(view)?.showMessage(ArgumentMatchers.any(Int::class.java))
true
}
} }
/** /**