mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 04:43:54 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Merge pull request #402 from veyndan/unused-menu-icon

Browse source 
Remove references to icons when showAsAction is set to never
This commit is contained in:
Josephine Lim 2017-03-08 01:16:48 +10:00 • committed by GitHub
commit f573789920
2 changed files with 0 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

4
app/src/main/res/menu/fragment_contributions_list.xml
View file

@ -15,22 +15,18 @@
<item android:id="@+id/menu_settings" <item android:id="@+id/menu_settings"
android:title="@string/menu_settings" android:title="@string/menu_settings"
app:showAsAction="never" app:showAsAction="never"
android:icon="@android:drawable/ic_menu_preferences"
/> />
<item android:id="@+id/menu_about" <item android:id="@+id/menu_about"
android:title="@string/menu_about" android:title="@string/menu_about"
app:showAsAction="never" app:showAsAction="never"
android:icon="@android:drawable/ic_menu_info_details"
/> />
<item android:id="@+id/menu_feedback" <item android:id="@+id/menu_feedback"
android:title="@string/menu_feedback" android:title="@string/menu_feedback"
app:showAsAction="never" app:showAsAction="never"
android:icon="@android:drawable/ic_menu_send"
/> />
<item android:id="@+id/menu_nearby" <item android:id="@+id/menu_nearby"
android:title="@string/menu_nearby" android:title="@string/menu_nearby"
app:showAsAction="never" app:showAsAction="never"
android:icon="@android:drawable/ic_menu_myplaces"
/> />
<item android:id="@+id/menu_refresh" <item android:id="@+id/menu_refresh"
android:title="@string/menu_refresh" android:title="@string/menu_refresh"

3
app/src/main/res/menu/fragment_image_detail.xml
View file

@ -9,12 +9,10 @@
app:showAsAction="ifRoom|withText" /> app:showAsAction="ifRoom|withText" />
<item <item
android:id="@+id/menu_browser_current_image" android:id="@+id/menu_browser_current_image"
android:icon="@android:drawable/ic_menu_view"
android:title="@string/menu_open_in_browser" android:title="@string/menu_open_in_browser"
app:showAsAction="never" /> app:showAsAction="never" />
<item <item
android:id="@+id/menu_download_current_image" android:id="@+id/menu_download_current_image"
android:icon="@drawable/ic_menu_download"
android:title="@string/menu_download" android:title="@string/menu_download"
app:showAsAction="never" /> app:showAsAction="never" />
<item <item
@ -27,7 +25,6 @@
<item <item
android:id="@+id/menu_cancel_current_image" android:id="@+id/menu_cancel_current_image"
android:enabled="false" android:enabled="false"
android:icon="@android:drawable/ic_menu_delete"
android:title="@string/menu_cancel_upload" android:title="@string/menu_cancel_upload"
android:visible="false" android:visible="false"
app:showAsAction="never" /> app:showAsAction="never" />