mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 04:43:54 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Add TODOs

Browse source
This commit is contained in:
misaochan 2018-05-09 02:29:52 +10:00
parent cf583c5a77
commit f4cef8da1b
1 changed files with 16 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

29
app/src/main/java/fr/free/nrw/commons/upload/ShareActivity.java
View file

@ -216,6 +216,10 @@ public class ShareActivity
.commit(); .commit();
} }
/**
* Send categories to modifications queue after they are selected
* @param categories categories selected
*/
@Override @Override
public void onCategoriesSave(List<String> categories) { public void onCategoriesSave(List<String> categories) {
if (categories.size() > 0) { if (categories.size() > 0) {
@ -253,10 +257,6 @@ public class ShareActivity
finish(); finish();
} }
protected boolean isNearbyUpload() {
return isNearbyUpload;
}
@Override @Override
public void onCreate(Bundle savedInstanceState) { public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState); super.onCreate(savedInstanceState);
@ -309,8 +309,6 @@ public class ShareActivity
} }
}); });
zoomInButton = (FloatingActionButton) findViewById(R.id.media_upload_zoom_in); zoomInButton = (FloatingActionButton) findViewById(R.id.media_upload_zoom_in);
try { try {
zoomInButton.setOnClickListener(new View.OnClickListener() { zoomInButton.setOnClickListener(new View.OnClickListener() {
@ -345,6 +343,7 @@ public class ShareActivity
} }
} }
//TODO: We should only use snackbar for location permissions, since storage permissions are MANDATORY
// Check storage permissions if marshmallow or newer // Check storage permissions if marshmallow or newer
if (useNewPermissions && (!storagePermitted || !locationPermitted)) { if (useNewPermissions && (!storagePermitted || !locationPermitted)) {
if (!storagePermitted && !locationPermitted) { if (!storagePermitted && !locationPermitted) {
@ -404,7 +403,8 @@ public class ShareActivity
} }
}); });
} }
/*
/**
* Function to display the zoom and map FAB * Function to display the zoom and map FAB
*/ */
private void showFABMenu(){ private void showFABMenu(){
@ -419,8 +419,8 @@ public class ShareActivity
zoomInButton.animate().translationY(-getResources().getDimension(R.dimen.first_fab)); zoomInButton.animate().translationY(-getResources().getDimension(R.dimen.first_fab));
} }
/* /**
* function to close the zoom and map FAB * Function to close the zoom and map FAB
*/ */
private void closeFABMenu(){ private void closeFABMenu(){
isFABOpen=false; isFABOpen=false;
@ -429,7 +429,6 @@ public class ShareActivity
zoomInButton.animate().translationY(0).setListener(new Animator.AnimatorListener() { zoomInButton.animate().translationY(0).setListener(new Animator.AnimatorListener() {
@Override @Override
public void onAnimationStart(Animator animator) { public void onAnimationStart(Animator animator) {
} }
@Override @Override
@ -438,21 +437,25 @@ public class ShareActivity
maps_fragment.setVisibility(View.GONE); maps_fragment.setVisibility(View.GONE);
zoomInButton.setVisibility(View.GONE); zoomInButton.setVisibility(View.GONE);
} }
} }
@Override @Override
public void onAnimationCancel(Animator animator) { public void onAnimationCancel(Animator animator) {
} }
@Override @Override
public void onAnimationRepeat(Animator animator) { public void onAnimationRepeat(Animator animator) {
} }
}); });
} }
/**
* Checks if upload was initiated via Nearby
* @return true if upload was initiated via Nearby
*/
protected boolean isNearbyUpload() {
return isNearbyUpload;
}
@Override @Override
public void onRequestPermissionsResult(int requestCode, public void onRequestPermissionsResult(int requestCode,