From f3818c6e2305aebe941df3f27b2e507dd78f5d20 Mon Sep 17 00:00:00 2001 From: neslihanturan Date: Thu, 13 Dec 2018 18:07:50 +0300 Subject: [PATCH] Remove old and unused retry buttons as we do for their functions --- .../commons/media/MediaDetailPagerFragment.java | 16 ---------------- app/src/main/res/menu/fragment_image_detail.xml | 13 ------------- 2 files changed, 29 deletions(-) diff --git a/app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.java b/app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.java index 3db8258fb..27eb08055 100644 --- a/app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.java +++ b/app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.java @@ -189,16 +189,6 @@ public class MediaDetailPagerFragment extends CommonsDaggerSupportFragment imple // Set wallpaper setWallpaper(m); return true; - case R.id.menu_retry_current_image: - // Retry - //((MainActivity) getActivity()).retryUpload(pager.getCurrentItem()); - getActivity().getSupportFragmentManager().popBackStack(); - return true; - case R.id.menu_cancel_current_image: - // todo: delete image - //((MainActivity) getActivity()).deleteUpload(pager.getCurrentItem()); - getActivity().getSupportFragmentManager().popBackStack(); - return true; default: return super.onOptionsItemSelected(item); } @@ -279,8 +269,6 @@ public class MediaDetailPagerFragment extends CommonsDaggerSupportFragment imple Media m = provider.getMediaAtPosition(pager.getCurrentItem()); if (m != null) { // Enable default set of actions, then re-enable different set of actions only if it is a failed contrib - menu.findItem(R.id.menu_retry_current_image).setEnabled(false).setVisible(false); - menu.findItem(R.id.menu_cancel_current_image).setEnabled(false).setVisible(false); menu.findItem(R.id.menu_browser_current_image).setEnabled(true).setVisible(true); menu.findItem(R.id.menu_share_current_image).setEnabled(true).setVisible(true); menu.findItem(R.id.menu_download_current_image).setEnabled(true).setVisible(true); @@ -297,8 +285,6 @@ public class MediaDetailPagerFragment extends CommonsDaggerSupportFragment imple Contribution c = (Contribution) m; switch (c.getState()) { case Contribution.STATE_FAILED: - menu.findItem(R.id.menu_retry_current_image).setEnabled(true).setVisible(true); - menu.findItem(R.id.menu_cancel_current_image).setEnabled(true).setVisible(true); menu.findItem(R.id.menu_browser_current_image).setEnabled(false).setVisible(false); menu.findItem(R.id.menu_share_current_image).setEnabled(false).setVisible(false); menu.findItem(R.id.menu_download_current_image).setEnabled(false).setVisible(false); @@ -306,8 +292,6 @@ public class MediaDetailPagerFragment extends CommonsDaggerSupportFragment imple break; case Contribution.STATE_IN_PROGRESS: case Contribution.STATE_QUEUED: - menu.findItem(R.id.menu_retry_current_image).setEnabled(false).setVisible(false); - menu.findItem(R.id.menu_cancel_current_image).setEnabled(false).setVisible(false); menu.findItem(R.id.menu_browser_current_image).setEnabled(false).setVisible(false); menu.findItem(R.id.menu_share_current_image).setEnabled(false).setVisible(false); menu.findItem(R.id.menu_download_current_image).setEnabled(false).setVisible(false); diff --git a/app/src/main/res/menu/fragment_image_detail.xml b/app/src/main/res/menu/fragment_image_detail.xml index 3161bd155..21f5f9be9 100644 --- a/app/src/main/res/menu/fragment_image_detail.xml +++ b/app/src/main/res/menu/fragment_image_detail.xml @@ -25,18 +25,5 @@ android:id="@+id/menu_set_as_wallpaper" android:title="@string/menu_set_wallpaper" app:showAsAction="never" /> - - \ No newline at end of file