mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-28 05:13:53 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix memory leak due to wikidata edit listener (#2048)

Browse source
This commit is contained in:
Vivek Maskara 2018-11-30 20:49:42 +05:30 • committed by neslihanturan
parent 6391307fad
commit f2d271af37
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
app/src/main/java/fr/free/nrw/commons/nearby/NearbyFragment.java
View file

@ -114,7 +114,6 @@ public class NearbyFragment extends CommonsDaggerSupportFragment
resumeFragment();*/ resumeFragment();*/
bundle = new Bundle(); bundle = new Bundle();
initBottomSheetBehaviour(); initBottomSheetBehaviour();
wikidataEditListener.setAuthenticationStateListener(this);
this.view = view; this.view = view;
return view; return view;
} }
@ -642,6 +641,7 @@ public class NearbyFragment extends CommonsDaggerSupportFragment
@Override @Override
public void onAttach(Context context) { public void onAttach(Context context) {
super.onAttach(context); super.onAttach(context);
wikidataEditListener.setAuthenticationStateListener(this);
} }
@Override @Override
@ -650,6 +650,7 @@ public class NearbyFragment extends CommonsDaggerSupportFragment
if (placesDisposable != null) { if (placesDisposable != null) {
placesDisposable.dispose(); placesDisposable.dispose();
} }
wikidataEditListener.setAuthenticationStateListener(null);
} }
@Override @Override
@ -657,6 +658,7 @@ public class NearbyFragment extends CommonsDaggerSupportFragment
super.onDetach(); super.onDetach();
snackbar = null; snackbar = null;
broadcastReceiver = null; broadcastReceiver = null;
wikidataEditListener.setAuthenticationStateListener(null);
} }
@Override @Override