From f1b40728b2a21a768428c3181f898e66829e55dd Mon Sep 17 00:00:00 2001
From: Ashish <ashishkumar468@gmail.com>
Date: Tue, 1 Dec 2020 16:38:30 +0530
Subject: [PATCH] Fixes #343 (#4057)

Removed the quantity item zero from string plural contributions_subtitle
Handled zero uplaod count from MainActivity
---
 .../fr/free/nrw/commons/contributions/MainActivity.java     | 6 ++++--
 app/src/main/res/values/strings.xml                         | 4 +---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/app/src/main/java/fr/free/nrw/commons/contributions/MainActivity.java b/app/src/main/java/fr/free/nrw/commons/contributions/MainActivity.java
index 26fa55bc2..97a6515a1 100644
--- a/app/src/main/java/fr/free/nrw/commons/contributions/MainActivity.java
+++ b/app/src/main/java/fr/free/nrw/commons/contributions/MainActivity.java
@@ -207,9 +207,11 @@ public class MainActivity  extends BaseActivity
      */
     public void setNumOfUploads(int uploadCount) {
         if (activeFragment == ActiveFragment.CONTRIBUTIONS) {
-            setTitle(getResources().getString(R.string.contributions_fragment) +" "+ getResources()
+            setTitle(getResources().getString(R.string.contributions_fragment) +" "+ (
+                !(uploadCount == 0) ?
+                getResources()
                 .getQuantityString(R.plurals.contributions_subtitle,
-                    uploadCount, uploadCount));
+                    uploadCount, uploadCount):getString(R.string.contributions_subtitle_zero)));
         }
     }
 
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 63b55dc8f..aaa9cb0fb 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -5,8 +5,6 @@
     <item quantity="other">%1$d files uploading</item>
   </plurals>
   <plurals name="contributions_subtitle">
-    <!--zero is not used in english. Category mentioned here for easy reference in future-->
-    <item quantity="zero">@string/contributions_subtitle_zero</item>
     <item quantity="one">(%1$d)</item>
     <item quantity="other">(%1$d)</item>
   </plurals>
@@ -98,7 +96,7 @@
   <string name="display_list_button">List</string>
   <string name="gps_disabled">GPS is disabled in your device. Would you like to enable it?</string>
   <string name="enable_gps">Enable GPS</string>
-  <string name="contributions_subtitle_zero">No uploads yet</string>
+  <string name="contributions_subtitle_zero">(No uploads yet)</string>
   <string name="categories_not_found">No categories matching %1$s found</string>
   <string name="depictions_not_found">No Wikidata items matching %1$s found</string>
   <string name="no_child_classes">%1$s has no child classes</string>