mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 12:53:55 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

UploadMediaDetailAdapter: made selecting a language deselect all others (#5883)

Browse source 
>> Made it so that selecting a language results in the hashmap storing the currently selected language(s) being cleared. Considered refactoring the hashmap storing this into a single pair storing the language positition index and its code, as only one language should ever be selected, however I am not confident that this would not introduce unintended side-effects
This commit is contained in:
cambo14 2024-10-23 04:50:37 +11:00 • committed by GitHub
parent 9c1c95f5cf
commit f1205c19be
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
app/src/main/java/fr/free/nrw/commons/upload/UploadMediaDetailAdapter.java
View file

@ -407,7 +407,7 @@ public class UploadMediaDetailAdapter extends
recentLanguagesDao recentLanguagesDao
.addRecentLanguage(new Language(languageName, languageCode)); .addRecentLanguage(new Language(languageName, languageCode));
selectedLanguages.remove(position); selectedLanguages.clear();
selectedLanguages.put(position, languageCode); selectedLanguages.put(position, languageCode);
((LanguagesAdapter) adapterView ((LanguagesAdapter) adapterView
.getAdapter()).setSelectedLangCode(languageCode); .getAdapter()).setSelectedLangCode(languageCode);
@ -497,7 +497,7 @@ public class UploadMediaDetailAdapter extends
} }
recentLanguagesDao.addRecentLanguage(new Language(languageName, languageCode)); recentLanguagesDao.addRecentLanguage(new Language(languageName, languageCode));
selectedLanguages.remove(position); selectedLanguages.clear();
selectedLanguages.put(position, languageCode); selectedLanguages.put(position, languageCode);
((RecentLanguagesAdapter) adapterView ((RecentLanguagesAdapter) adapterView
.getAdapter()).setSelectedLangCode(languageCode); .getAdapter()).setSelectedLangCode(languageCode);