mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 12:53:55 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Rename Constants to Follow Kotlin Naming Conventions (#6107)

Browse source 
* Rename Constants to Follow Kotlin Naming Conventions

>This PR refactors constant names in the project to adhere to Kotlin's UPPERCASE_SNAKE_CASE naming convention, improving code readability and maintaining consistency across the codebase.

>Renamed the following constants in LoginActivity:
>saveProgressDialog → SAVE_PROGRESS_DIALOG
>saveErrorMessage → SAVE_ERROR_MESSAGE
>saveUsername → SAVE_USERNAME
>savePassword → SAVE_PASSWORD

>Updated all references to these constants throughout the project.

* Update Project_Default.xml
This commit is contained in:
Akshay Komar 2025-01-06 22:30:02 +05:30 • committed by GitHub
parent 940c0740b0
commit ecb19d6984
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 13 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

26
app/src/main/java/fr/free/nrw/commons/auth/LoginActivity.kt
View file

@ -184,32 +184,32 @@ class LoginActivity : AccountAuthenticatorActivity() {
// if progressDialog is visible during the configuration change then store state as true else false so that // if progressDialog is visible during the configuration change then store state as true else false so that
// we maintain visibility of progressDialog after configuration change // we maintain visibility of progressDialog after configuration change
if (progressDialog != null && progressDialog!!.isShowing) { if (progressDialog != null && progressDialog!!.isShowing) {
outState.putBoolean(saveProgressDialog, true) outState.putBoolean(SAVE_PROGRESS_DIALOG, true)
} else { } else {
outState.putBoolean(saveProgressDialog, false) outState.putBoolean(SAVE_PROGRESS_DIALOG, false)
} }
outState.putString( outState.putString(
saveErrorMessage, SAVE_ERROR_MESSAGE,
binding!!.errorMessage.text.toString() binding!!.errorMessage.text.toString()
) //Save the errorMessage ) //Save the errorMessage
outState.putString( outState.putString(
saveUsername, SAVE_USERNAME,
binding!!.loginUsername.text.toString() binding!!.loginUsername.text.toString()
) // Save the username ) // Save the username
outState.putString( outState.putString(
savePassword, SAVE_PASSWORD,
binding!!.loginPassword.text.toString() binding!!.loginPassword.text.toString()
) // Save the password ) // Save the password
} }
override fun onRestoreInstanceState(savedInstanceState: Bundle) { override fun onRestoreInstanceState(savedInstanceState: Bundle) {
super.onRestoreInstanceState(savedInstanceState) super.onRestoreInstanceState(savedInstanceState)
binding!!.loginUsername.setText(savedInstanceState.getString(saveUsername)) binding!!.loginUsername.setText(savedInstanceState.getString(SAVE_USERNAME))
binding!!.loginPassword.setText(savedInstanceState.getString(savePassword)) binding!!.loginPassword.setText(savedInstanceState.getString(SAVE_PASSWORD))
if (savedInstanceState.getBoolean(saveProgressDialog)) { if (savedInstanceState.getBoolean(SAVE_PROGRESS_DIALOG)) {
performLogin() performLogin()
} }
val errorMessage = savedInstanceState.getString(saveErrorMessage) val errorMessage = savedInstanceState.getString(SAVE_ERROR_MESSAGE)
if (sessionManager.isUserLoggedIn) { if (sessionManager.isUserLoggedIn) {
showMessage(R.string.login_success, R.color.primaryDarkColor) showMessage(R.string.login_success, R.color.primaryDarkColor)
} else { } else {
@ -396,9 +396,9 @@ class LoginActivity : AccountAuthenticatorActivity() {
fun startYourself(context: Context) = fun startYourself(context: Context) =
context.startActivity(Intent(context, LoginActivity::class.java)) context.startActivity(Intent(context, LoginActivity::class.java))
const val saveProgressDialog: String = "ProgressDialog_state" const val SAVE_PROGRESS_DIALOG: String = "ProgressDialog_state"
const val saveErrorMessage: String = "errorMessage" const val SAVE_ERROR_MESSAGE: String = "errorMessage"
const val saveUsername: String = "username" const val SAVE_USERNAME: String = "username"
const val savePassword: String = "password" const val SAVE_PASSWORD: String = "password"
} }
} }