mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-29 05:43:55 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Change hardcoded strings in the language search dialog to messages (#6440)

Browse source 
Another comment: While working on this, I also noticed that
"Recent Searches" is hardcoded in the XML file, and
I'm not sure where does it actually appear. I fixed it, too,
but perhaps it can be completely removed.

Fixes #6439.
This commit is contained in:
Amir E. Aharoni 2025-10-03 21:43:10 -04:00 • committed by GitHub
parent 10c384ffa7
commit e9a1af0f52
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 9 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
app/src/main/res/layout/dialog_select_language.xml
View file

@ -12,7 +12,7 @@
android:layout_marginStart="8dp"
android:layout_marginTop="8dp"
android:layout_marginEnd="8dp"
android:hint="Type Language Name"
android:hint="@string/language_search_type_language_name"
android:padding="12dp"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
@ -22,7 +22,7 @@
android:id="@+id/recent_searches"
android:layout_width="0dp"
android:layout_height="wrap_content"
android:text="Recent Searches"
android:text="@string/language_search_recent_searches"
app:layout_constraintTop_toBottomOf="@id/search_language"
app:layout_constraintEnd_toEndOf="@+id/language_history_list"
android:layout_marginEnd="8dp"
@ -55,7 +55,7 @@
android:id="@+id/all_languages"
android:layout_width="0dp"
android:layout_height="wrap_content"
android:text="All Languages"
android:text="@string/language_search_all_languages"
app:layout_constraintTop_toBottomOf="@id/separator"
app:layout_constraintEnd_toEndOf="@+id/language_history_list"
android:layout_margin="8dp"