mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-26 20:33:53 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix crash when no email client is installed

Browse source 
See issue #114
This commit is contained in:
Adam Jones 2016-06-04 00:00:24 +01:00
parent 99cbad747f
commit e7ade759dd
2 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

11
commons/app/src/main/java/main/java/fr/free/nrw/commons/contributions/ContributionsListFragment.java
View file

@ -1,6 +1,7 @@
package fr.free.nrw.commons.contributions;
import android.app.Activity;
import android.content.ActivityNotFoundException;
import android.content.Context;
import android.content.Intent;
import android.content.SharedPreferences;
@ -17,6 +18,7 @@ import android.support.v4.app.Fragment;
import android.view.Menu;
import android.view.MenuInflater;
import android.view.MenuItem;
import android.widget.Toast;
import fr.free.nrw.commons.AboutActivity;
import fr.free.nrw.commons.CommonsApplication;
@ -106,7 +108,14 @@ public class ContributionsListFragment extends Fragment {
feedbackIntent.setType("message/rfc822");
feedbackIntent.putExtra(Intent.EXTRA_EMAIL, new String[] { CommonsApplication.FEEDBACK_EMAIL });
feedbackIntent.putExtra(Intent.EXTRA_SUBJECT, String.format(CommonsApplication.FEEDBACK_EMAIL_SUBJECT, CommonsApplication.APPLICATION_VERSION));
startActivity(feedbackIntent);
try {
startActivity(feedbackIntent);
}
catch (ActivityNotFoundException e) {
Toast.makeText(getActivity(), R.string.no_email_client, Toast.LENGTH_SHORT).show();
}
return true;
case R.id.menu_refresh:
((SourceRefresher)getActivity()).refreshSource();

1
commons/app/src/main/res/values/strings.xml
View file

@ -80,6 +80,7 @@
<string name="about_privacy_policy">&lt;a href="https://wikimediafoundation.org/wiki/Privacy_policy">Privacy policy&lt;/a></string>
<string name="title_activity_about">About</string>
<string name="menu_feedback">Send Feedback (via Email)</string>
<string name="no_email_client">No email client installed</string>
<string name="provider_categories">Recently used categories</string>
<string name="waiting_first_sync">Waiting for first sync...</string>