From e5f38ab6d27141feec4c19c8ed077e2a7d7261a9 Mon Sep 17 00:00:00 2001 From: Brion Vibber Date: Mon, 29 Apr 2013 07:56:24 -0700 Subject: [PATCH] Disable fade-in effect on images in Android 2.3 This should fix the flickering problem during updates, though it won't look quite as nice when scrolling the contribs list. --- .../src/main/java/org/wikimedia/commons/Utils.java | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/commons/src/main/java/org/wikimedia/commons/Utils.java b/commons/src/main/java/org/wikimedia/commons/Utils.java index 5cfdeadb9..455f0503c 100644 --- a/commons/src/main/java/org/wikimedia/commons/Utils.java +++ b/commons/src/main/java/org/wikimedia/commons/Utils.java @@ -92,8 +92,15 @@ public class Utils { public static DisplayImageOptions.Builder getGenericDisplayOptions() { if(defaultImageOptionsBuilder == null) { defaultImageOptionsBuilder = new DisplayImageOptions.Builder().cacheInMemory() - .imageScaleType(ImageScaleType.IN_SAMPLE_POWER_OF_2) - .displayer(new FadeInBitmapDisplayer(300)) + .imageScaleType(ImageScaleType.IN_SAMPLE_POWER_OF_2); + if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.HONEYCOMB) { + // List views flicker badly during data updates on Android 2.3; we + // haven't quite figured out why but cells seem to be rearranged oddly. + // Disable the fade-in on 2.3 to reduce the effect. + defaultImageOptionsBuilder = defaultImageOptionsBuilder + .displayer(new FadeInBitmapDisplayer(300)); + } + defaultImageOptionsBuilder = defaultImageOptionsBuilder .cacheInMemory() .resetViewBeforeLoading(); }