From e5c8e40b766bb40cdb4479dbf21df5fb9c64c5ef Mon Sep 17 00:00:00 2001 From: maskara Date: Sat, 10 Mar 2018 22:44:37 +0530 Subject: [PATCH] Suggested changes for notification fixes --- app/build.gradle | 6 ------ .../nrw/commons/mwapi/ApacheHttpClientMediaWikiApi.java | 4 +++- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/app/build.gradle b/app/build.gradle index 16f7c49fa..a7af07ac0 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -102,12 +102,6 @@ dependencies { compile 'com.android.support.constraint:constraint-layout:1.0.2' } -repositories { - mavenCentral() - google() -} - - android { compileSdkVersion project.compileSdkVersion buildToolsVersion project.buildToolsVersion diff --git a/app/src/main/java/fr/free/nrw/commons/mwapi/ApacheHttpClientMediaWikiApi.java b/app/src/main/java/fr/free/nrw/commons/mwapi/ApacheHttpClientMediaWikiApi.java index 1a059fcd4..34435a444 100644 --- a/app/src/main/java/fr/free/nrw/commons/mwapi/ApacheHttpClientMediaWikiApi.java +++ b/app/src/main/java/fr/free/nrw/commons/mwapi/ApacheHttpClientMediaWikiApi.java @@ -46,6 +46,7 @@ import io.reactivex.Observable; import io.reactivex.Single; import timber.log.Timber; +import static fr.free.nrw.commons.notification.NotificationType.THANK_YOU_EDIT; import static fr.free.nrw.commons.notification.NotificationType.UNKNOWN; import static fr.free.nrw.commons.notification.NotificationUtils.getNotificationFromApiResult; import static fr.free.nrw.commons.notification.NotificationUtils.getNotificationType; @@ -453,7 +454,8 @@ public class ApacheHttpClientMediaWikiApi implements MediaWikiApi { for (int i = 0; i < childNodes.getLength(); i++) { Node node = childNodes.item(i); if (isCommonsNotification(node) - && !getNotificationType(node).equals(UNKNOWN)) { + && !getNotificationType(node).equals(UNKNOWN) + && !getNotificationType(node).equals(THANK_YOU_EDIT)) { notifications.add(getNotificationFromApiResult(context, node)); } }