mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 12:53:55 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fixed two item was inaccessable with bottom sheet in landscape mode. (#4187)

Browse source 
scrollview is added so that last options are scrollable.
This commit is contained in:
Pratham Pahariya 2021-03-01 19:11:09 +05:30 • committed by GitHub
parent 93cd89a34b
commit e5c89c0b8b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 150 additions and 120 deletions
Download patch file Download diff file Expand all files Collapse all files

155
app/src/main/res/layout/fragment_more_bottom_sheet.xml
View file

@ -5,80 +5,95 @@
android:theme="?attr/more_bottom_sheet_style" android:theme="?attr/more_bottom_sheet_style"
android:orientation="vertical"> android:orientation="vertical">
<TextView <ScrollView
android:id="@+id/more_profile" android:layout_width="match_parent"
android:layout_width="match_parent" android:layout_height="match_parent"
android:layout_height="wrap_content" android:nestedScrollingEnabled="true">
android:layout_margin="12dp"
android:drawableStart="@drawable/ic_person_black_24dp"
android:drawablePadding="12dp"
android:padding="8dp"
android:text="@string/Profile"
android:textSize="18sp" />
<TextView <LinearLayout
android:id="@+id/more_peer_review" android:layout_width="match_parent"
android:layout_width="match_parent" android:layout_height="wrap_content"
android:layout_height="wrap_content" android:orientation="vertical">
android:layout_margin="12dp"
android:drawableStart="@drawable/ic_check_black_24dp"
android:drawablePadding="12dp"
android:padding="8dp"
android:text="@string/navigation_item_review"
android:textSize="18sp" />
<TextView <TextView
android:id="@+id/more_settings" android:id="@+id/more_profile"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_margin="12dp" android:layout_margin="12dp"
android:drawableStart="@drawable/ic_settings_black_24dp" android:drawableStart="@drawable/ic_person_black_24dp"
android:drawablePadding="12dp" android:drawablePadding="12dp"
android:padding="8dp" android:padding="8dp"
android:text="@string/menu_settings" android:text="@string/Profile"
android:textSize="18sp" /> android:textSize="18sp" />
<TextView <TextView
android:id="@+id/more_tutorial" android:id="@+id/more_peer_review"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_margin="12dp" android:layout_margin="12dp"
android:drawableStart="@drawable/ic_help_black_24dp" android:drawableStart="@drawable/ic_check_black_24dp"
android:drawablePadding="12dp" android:drawablePadding="12dp"
android:padding="8dp" android:padding="8dp"
android:text="@string/navigation_item_info" android:text="@string/navigation_item_review"
android:textSize="18sp" /> android:textSize="18sp" />
<TextView <TextView
android:id="@+id/more_feedback" android:id="@+id/more_settings"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_margin="12dp" android:layout_margin="12dp"
android:drawableLeft="@drawable/ic_feedback_black_24dp" android:drawableStart="@drawable/ic_settings_black_24dp"
android:drawablePadding="12dp" android:drawablePadding="12dp"
android:padding="8dp" android:padding="8dp"
android:text="@string/navigation_item_feedback" android:text="@string/menu_settings"
android:textSize="18sp" /> android:textSize="18sp" />
<TextView <TextView
android:id="@+id/more_about" android:id="@+id/more_tutorial"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_margin="12dp" android:layout_margin="12dp"
android:drawableStart="@drawable/ic_info_outline_24dp" android:drawableStart="@drawable/ic_help_black_24dp"
android:drawablePadding="12dp" android:drawablePadding="12dp"
android:padding="8dp" android:padding="8dp"
android:text="@string/navigation_item_about" android:text="@string/navigation_item_info"
android:textSize="18sp" /> android:textSize="18sp" />
<TextView
android:id="@+id/more_feedback"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_margin="12dp"
android:drawableLeft="@drawable/ic_feedback_black_24dp"
android:drawablePadding="12dp"
android:padding="8dp"
android:text="@string/navigation_item_feedback"
android:textSize="18sp" />
<TextView
android:id="@+id/more_about"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_margin="12dp"
android:drawableStart="@drawable/ic_info_outline_24dp"
android:drawablePadding="12dp"
android:padding="8dp"
android:text="@string/navigation_item_about"
android:textSize="18sp" />
<TextView
android:id="@+id/more_logout"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_margin="12dp"
android:drawableStart="@drawable/ic_exit_to_app_black_24dp"
android:drawablePadding="12dp"
android:padding="8dp"
android:text="@string/navigation_item_logout"
android:textSize="18sp" />
</LinearLayout>
</ScrollView>
<TextView
android:id="@+id/more_logout"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_margin="12dp"
android:drawableStart="@drawable/ic_exit_to_app_black_24dp"
android:drawablePadding="12dp"
android:padding="8dp"
android:text="@string/navigation_item_logout"
android:textSize="18sp" />
</LinearLayout> </LinearLayout>

115
app/src/main/res/layout/fragment_more_bottom_sheet_logged_out.xml
View file

@ -5,58 +5,73 @@
android:theme="?attr/more_bottom_sheet_style" android:theme="?attr/more_bottom_sheet_style"
android:orientation="vertical"> android:orientation="vertical">
<TextView <ScrollView
android:id="@+id/more_settings" android:layout_width="match_parent"
android:layout_width="match_parent" android:layout_height="match_parent"
android:layout_height="wrap_content" android:nestedScrollingEnabled="true">
android:layout_margin="12dp"
android:drawableStart="@drawable/ic_settings_black_24dp"
android:drawablePadding="12dp"
android:padding="8dp"
android:text="@string/menu_settings"
android:textSize="18sp" />
<TextView <LinearLayout
android:id="@+id/more_tutorial" android:layout_width="match_parent"
android:layout_width="match_parent" android:layout_height="wrap_content"
android:layout_height="wrap_content" android:orientation="vertical" >
android:layout_margin="12dp"
android:drawableStart="@drawable/ic_help_black_24dp"
android:drawablePadding="12dp"
android:padding="8dp"
android:text="@string/navigation_item_info"
android:textSize="18sp" />
<TextView <TextView
android:id="@+id/more_feedback" android:id="@+id/more_settings"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_margin="12dp" android:layout_margin="12dp"
android:drawableLeft="@drawable/ic_feedback_black_24dp" android:drawableStart="@drawable/ic_settings_black_24dp"
android:drawablePadding="12dp" android:drawablePadding="12dp"
android:padding="8dp" android:padding="8dp"
android:text="@string/navigation_item_feedback" android:text="@string/menu_settings"
android:textSize="18sp" /> android:textSize="18sp" />
<TextView <TextView
android:id="@+id/more_about" android:id="@+id/more_tutorial"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_margin="12dp" android:layout_margin="12dp"
android:drawableStart="@drawable/ic_info_outline_24dp" android:drawableStart="@drawable/ic_help_black_24dp"
android:drawablePadding="12dp" android:drawablePadding="12dp"
android:padding="8dp" android:padding="8dp"
android:text="@string/navigation_item_about" android:text="@string/navigation_item_info"
android:textSize="18sp" /> android:textSize="18sp" />
<TextView
android:id="@+id/more_feedback"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_margin="12dp"
android:drawableLeft="@drawable/ic_feedback_black_24dp"
android:drawablePadding="12dp"
android:padding="8dp"
android:text="@string/navigation_item_feedback"
android:textSize="18sp" />
<TextView
android:id="@+id/more_about"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_margin="12dp"
android:drawableStart="@drawable/ic_info_outline_24dp"
android:drawablePadding="12dp"
android:padding="8dp"
android:text="@string/navigation_item_about"
android:textSize="18sp" />
<TextView
android:id="@+id/more_login"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_margin="12dp"
android:drawableStart="@drawable/ic_baseline_person_24"
android:drawablePadding="12dp"
android:padding="8dp"
android:text="@string/navigation_item_login"
android:textSize="18sp" />
</LinearLayout>
</ScrollView>
<TextView
android:id="@+id/more_login"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_margin="12dp"
android:drawableStart="@drawable/ic_baseline_person_24"
android:drawablePadding="12dp"
android:padding="8dp"
android:text="@string/navigation_item_login"
android:textSize="18sp" />
</LinearLayout> </LinearLayout>