mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-11-03 08:13:55 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix title/desc prefill bug (#1794)

Browse source 
* Move isDirectUpload putExtra above Wikidata edits try catch block

* Check value of boolean isDirectUpload in intent

* Change to getBooleanExtra to prevent NPE

* Fix whitespaces, logging, and lint issues
This commit is contained in:
Josephine Lim 2018-08-05 02:03:31 +10:00 • committed by Vivek Maskara
parent ff9f43ef8b
commit e32f8d3d36
2 changed files with 13 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

7
app/src/main/java/fr/free/nrw/commons/upload/ShareActivity.java
View file

@ -351,9 +351,7 @@ public class ShareActivity
if (Intent.ACTION_SEND.equals(intent.getAction())) {
mediaUri = intent.getParcelableExtra(Intent.EXTRA_STREAM);
contentProviderUri = mediaUri;
mediaUri = ContributionUtils.saveFileBeingUploadedTemporarily(this, mediaUri);
if (intent.hasExtra(UploadService.EXTRA_SOURCE)) {
@ -361,7 +359,10 @@ public class ShareActivity
} else {
source = Contribution.SOURCE_EXTERNAL;
}
if (intent.hasExtra("isDirectUpload")) {
boolean isDirectUpload = intent.getBooleanExtra("isDirectUpload", false);
if (isDirectUpload) {
Timber.d("This was initiated by a direct upload from Nearby");
isNearbyUpload = true;
wikiDataEntityId = intent.getStringExtra(WIKIDATA_ENTITY_ID_PREF);