From 6c0d8f68c942ad5b7b48be04b44196b4e04f448c Mon Sep 17 00:00:00 2001 From: Amire80 Date: Thu, 15 Dec 2016 09:09:45 +0200 Subject: [PATCH 1/3] Rephrase a translatable string without comma splice --- app/src/main/res/values/strings.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index b84e63e6d..8a883fa26 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -10,7 +10,7 @@ Please wait... Login success! Login failed! - File not found, please try another file + File not found. Please try another file. Authentication failed! Upload started! From 908c7460dec554641afa7c6bd134312313b49306 Mon Sep 17 00:00:00 2001 From: Amire80 Date: Thu, 15 Dec 2016 09:10:43 +0200 Subject: [PATCH 2/3] Remove unnecessary whitespace from an English translatable string --- app/src/main/res/values/strings.xml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index b84e63e6d..3782b0c8d 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -44,8 +44,7 @@ Unable to login - network failure Unable to login - please check your username Unable to login - please check your password - Too many unsuccessful attempts. Please try again in a few minutes - + Too many unsuccessful attempts. Please try again in a few minutes. Sorry, this user has been blocked on Commons Login failed From 72b22e8a18ad912335b84eeed3fa47318208ac51 Mon Sep 17 00:00:00 2001 From: Amire80 Date: Thu, 15 Dec 2016 09:28:41 +0200 Subject: [PATCH 3/3] Rephrase bug reports and suggestions without slash This looks more natural in English. --- app/src/main/res/values/strings.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index b84e63e6d..60519e752 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -80,7 +80,7 @@ About Open Source software released under the <a href="https://github.com/wikimedia/apps-android-commons/blob/master/COPYING">Apache License v2</a>. Wikimedia Commons and its logo are trademarks of the Wikimedia Foundation and are used with the permission of the Wikimedia Foundation. We are not endorsed by or affiliated with the Wikimedia Foundation. - <a href="https://github.com/commons-app/apps-android-commons">Source</a> and <a href="https://commons-app.github.io/">website</a> on GitHub</a>. Create a new <a href="https://github.com/commons-app/apps-android-commons/issues">GitHub issue</a> for bug reports/suggestions. + <a href="https://github.com/commons-app/apps-android-commons">Source</a> and <a href="https://commons-app.github.io/">website</a> on GitHub</a>. Create a new <a href="https://github.com/commons-app/apps-android-commons/issues">GitHub issue</a> for bug reports and suggestions. <a href="https://wikimediafoundation.org/wiki/Privacy_policy">Privacy policy</a> About