From 4432f2ca1a18dd57220c1c3cb6c35d7f75f6a433 Mon Sep 17 00:00:00 2001 From: Ujjwal Agrawal Date: Sat, 24 Feb 2018 17:36:54 +0530 Subject: [PATCH 1/3] Rate Us feature added --- .../commons/theme/NavigationBaseActivity.java | 12 ++++++++++++ .../res/drawable-hdpi/ic_star_black_24dp.png | Bin 0 -> 440 bytes .../res/drawable-mdpi/ic_star_black_24dp.png | Bin 0 -> 296 bytes .../res/drawable-xhdpi/ic_star_black_24dp.png | Bin 0 -> 577 bytes .../res/drawable-xxhdpi/ic_star_black_24dp.png | Bin 0 -> 844 bytes .../res/drawable-xxxhdpi/ic_star_black_24dp.png | Bin 0 -> 1148 bytes app/src/main/res/menu/drawer.xml | 5 +++++ app/src/main/res/values/strings.xml | 1 + 8 files changed, 18 insertions(+) create mode 100644 app/src/main/res/drawable-hdpi/ic_star_black_24dp.png create mode 100644 app/src/main/res/drawable-mdpi/ic_star_black_24dp.png create mode 100644 app/src/main/res/drawable-xhdpi/ic_star_black_24dp.png create mode 100644 app/src/main/res/drawable-xxhdpi/ic_star_black_24dp.png create mode 100644 app/src/main/res/drawable-xxxhdpi/ic_star_black_24dp.png diff --git a/app/src/main/java/fr/free/nrw/commons/theme/NavigationBaseActivity.java b/app/src/main/java/fr/free/nrw/commons/theme/NavigationBaseActivity.java index 99c9f253b..5d577e73d 100644 --- a/app/src/main/java/fr/free/nrw/commons/theme/NavigationBaseActivity.java +++ b/app/src/main/java/fr/free/nrw/commons/theme/NavigationBaseActivity.java @@ -5,6 +5,7 @@ import android.accounts.AccountManager; import android.content.ActivityNotFoundException; import android.content.Context; import android.content.Intent; +import android.net.Uri; import android.support.annotation.NonNull; import android.support.design.widget.NavigationView; import android.support.v4.widget.DrawerLayout; @@ -132,6 +133,17 @@ public abstract class NavigationBaseActivity extends BaseActivity Toast.makeText(this, R.string.no_email_client, Toast.LENGTH_SHORT).show(); } return true; + case R.id.action_rate: + drawerLayout.closeDrawer(navigationView); + final String appPackageName = getPackageName(); + Toast.makeText(this, appPackageName, Toast.LENGTH_SHORT).show(); + try { + startActivity(new Intent(Intent.ACTION_VIEW, Uri.parse("market://details?id=" + appPackageName))); + } + catch (android.content.ActivityNotFoundException anfe) { + startActivity(new Intent(Intent.ACTION_VIEW, Uri.parse("https://play.google.com/store/apps/details?id=" + appPackageName))); + } + return true; case R.id.action_logout: new AlertDialog.Builder(this) .setMessage(R.string.logout_verification) diff --git a/app/src/main/res/drawable-hdpi/ic_star_black_24dp.png b/app/src/main/res/drawable-hdpi/ic_star_black_24dp.png new file mode 100644 index 0000000000000000000000000000000000000000..8ab80a62264238e19bfbeaddaa76efe9ec6b96eb GIT binary patch literal 440 zcmV;p0Z0CcP)wx8@;|HT1YAW0<{w_Fb3l1ba2cw zAT}a4>g0j=Dh(ZT8HnXbO;7wlyoUyk*#*RWr&kBeyK=q!XmSgy#QIL%mJ;VY~waQKY{oM5R1~nf?6Q{55-l~Hk<{BpCDQA2#A@fX+ap0;V>LT ziGcz@tOmq3KpY6fXRugs5-Mj6RVzTq&h6c`S}?NGCD zf(#)3Lx#b>fjE`eIPe7G&mMAasU7g?2`KWwX|vg00001r;P)$$Y#C}JZb_wfC8BU^lQwk^vV?AEKYz^S zH^4ouS*98uIy)TH!%jUj(lGFW6A%Q?Ad-eTRz#?Gki7WFTT0nzLDXOzr?Z0<(HLwL z^P9k$$qwO_Q%`&9jNDZ9#nw~j^+dO zD9Tl(;E02HKPVA(GAoaVOAO5~W^?jpst$$$T5~bHO)?CSlM&m`Fu;Lm^U6H`!Z5&- z=m2#bcA;940fsmPaElDEq0`hQq37B)kpV&}%)EmUIxiGP>9b^Ou0@%zOkre)u8B8> z?50>-E+Rl*g67JjU#E`sUEnG~4VQ=j3o%W@V4U7a>y?$>A%$aV&5H;S&@|iw)mhZ4 z0sESI=OQN2U%KI(4C{7-8_WMcI>kH#w1X*n=w~gZ<}_%rm@;L`lr;JS9nnljg}Zh9 P00000NkvXXu0mjfGgke@ literal 0 HcmV?d00001 diff --git a/app/src/main/res/drawable-xxhdpi/ic_star_black_24dp.png b/app/src/main/res/drawable-xxhdpi/ic_star_black_24dp.png new file mode 100644 index 0000000000000000000000000000000000000000..abc65dfe8c247ab9a5f29137da513e4016c3b01d GIT binary patch literal 844 zcmV-S1GD^zP)9w-mv7Dp&A#LFp44RURyc$pdxnv|4F6bX$o5A&eG!+0YKrQxJ8 zq4D5NLP!}#io_TUGX7uZ+d0^0pM5!JueJ92{`GsA&g`|;Z>GK0`qny*BauiX5{aZd zS;R<+C+vLm&A&2+{rrRW_HKZV-#TGf^KwktwA3>E3f_6lZF$6tKvz*aj zeGEA+YrrT|YB-ZX24q1!XaYxge{}`i1J5JAb4t<2&+Z17K^wQ-#C^$f->8qnDj{Gw zXaom%*0}(>z$5UUr`|zBpuWE2zIX9hT6t`ZJl4=z0D29Q5S3mYYotsC4^k|L#x|uK z>y}&!<=o)0l_ev<*%ZlXb1HNwu+MNY^s?Sl>FIs5lRw}yO%5GMZc1tmw3MfMQ{>PT zza;5};tXD>=`QCfs8zL^uHlueu5#{zY901i7d4b~UZ*`971f(Hl5>nJ2ik?|H9r-K z`2iYq-{sQ@#AgL^K7kdc)PClJHwnsl?c~q+jmn(_1$CMxXC$v&lM>X=`$c22Siw8U zsN1o-6$mowlEYO6f-aeKw4-7p`_>devlT8BYfTW;pis~@69ly@6m-S}L2+tCUzw=C z|5$f9lVc2yX1-}moLR71XF*ZU-szrVoyW84oM3kt|7Eq#f?7fr(GPLK&94}DIOHKg zv(AF<2OLC4$SIjVdp+Q@yLFXQ6`)x560D8U27SS$r$ieACH^awCF|4a@8BpHQ>H(} zaeij8_Lk`==wOk~-UKr%v|{fp(x#SQ$jfkx}9N1Q?rO z`*cg=WWhV|gQMBk7Z!5I==Rneh5g7BlzKBd3EBv@XjE?58gsUkNF)-8L?V$${PP=) WT`Ll6gAF7A0000H@P(!i!!-OuvH%y^;yyvh<0S;0;-VzUfH7URsuphtqm~>d>nxA zAL3+@lUBcg?YI}OE;*Go?I?SYHDB8$t z#I~{)jA!ll@~YHOOV(}rQI$sCb#RETbHKcjcR}Lt&-&R=3l~v1g(qA1ytx>dd&{yU zEWi>LAofUDfIux@tdp<+SAr6L3|`>KR)7|4qi9dM#AiXXf>3}Gi3_kb2nDESa!;&l zO{C;~q4(Iy)s~40v?7vqF2Du_3b0P+0-RK!09ro?R)v;yy{_RWF?Hqx5_K%VO2HxV zbx1j==ru{pbu56WwWNGG;C|Ne;e2uU{;h(xu}{YW+!YYaHE^=YHc|yO`n0>Fvaice zC%@4;&*DW=1irSx#rF8)4YYdJ&_Wl78$Np$?_it#!9&dX>h1YD6<{ZGHaRZh*D=!Y zkYacH+jT0yWg9!rpAnJI#Lmz1_gW8rv@woLx`f}2nLlng^ht+DzyThPh5ypVQHzJA zW)`NqUPLp^!p`0TXZSd#nc!^;<4V<`0L9FF`CmbpK52ZLh0MG?UZ_I>&X_d421_tL zz6!4LA7ebNLjgLs3GRWjB^>7*@P4PUzEM5=F(Es{AHKSY$^BzH(Rj#g4jK1Il?#xI zJHhXmNl<9q{IN8raO|s9{{l`|c>Mfon0^p~AP9mW2!bF8f*=Tj5W*jNP%vNGd;WI- O0000 + + Thank you for making an edit %1$s mentioned you on %2$s. Toggle view + Rate Us From fc8b522ac406164b944b3de35a3c7bed61297a4a Mon Sep 17 00:00:00 2001 From: Ujjwal Agrawal Date: Tue, 27 Feb 2018 12:04:04 +0530 Subject: [PATCH 2/3] Rate Us method added to Utils.java and called on AboutActivity.java --- .../java/fr/free/nrw/commons/AboutActivity.java | 6 ++++++ app/src/main/java/fr/free/nrw/commons/Utils.java | 15 ++++++++++++++- .../commons/theme/NavigationBaseActivity.java | 12 +----------- .../res/drawable-hdpi/ic_star_black_24dp.png | Bin 440 -> 0 bytes .../res/drawable-mdpi/ic_star_black_24dp.png | Bin 296 -> 0 bytes .../res/drawable-xhdpi/ic_star_black_24dp.png | Bin 577 -> 0 bytes .../res/drawable-xxhdpi/ic_star_black_24dp.png | Bin 844 -> 0 bytes .../res/drawable-xxxhdpi/ic_star_black_24dp.png | Bin 1148 -> 0 bytes app/src/main/res/layout/activity_about.xml | 8 ++++++++ app/src/main/res/menu/drawer.xml | 5 ----- app/src/main/res/values/strings.xml | 2 +- 11 files changed, 30 insertions(+), 18 deletions(-) delete mode 100644 app/src/main/res/drawable-hdpi/ic_star_black_24dp.png delete mode 100644 app/src/main/res/drawable-mdpi/ic_star_black_24dp.png delete mode 100644 app/src/main/res/drawable-xhdpi/ic_star_black_24dp.png delete mode 100644 app/src/main/res/drawable-xxhdpi/ic_star_black_24dp.png delete mode 100644 app/src/main/res/drawable-xxxhdpi/ic_star_black_24dp.png diff --git a/app/src/main/java/fr/free/nrw/commons/AboutActivity.java b/app/src/main/java/fr/free/nrw/commons/AboutActivity.java index a2f67a3bf..54e12fcf2 100644 --- a/app/src/main/java/fr/free/nrw/commons/AboutActivity.java +++ b/app/src/main/java/fr/free/nrw/commons/AboutActivity.java @@ -65,4 +65,10 @@ public class AboutActivity extends NavigationBaseActivity { Intent browserIntent = new Intent(Intent.ACTION_VIEW, Uri.parse("https://commons-app.github.io/\\")); startActivity(browserIntent); } + + @OnClick(R.id.about_rate_us) + public void rateApp(View view) { + + Utils.rateApp(this); + } } \ No newline at end of file diff --git a/app/src/main/java/fr/free/nrw/commons/Utils.java b/app/src/main/java/fr/free/nrw/commons/Utils.java index 817c39f24..48a8ce739 100644 --- a/app/src/main/java/fr/free/nrw/commons/Utils.java +++ b/app/src/main/java/fr/free/nrw/commons/Utils.java @@ -1,6 +1,8 @@ package fr.free.nrw.commons; import android.content.Context; +import android.content.Intent; +import android.net.Uri; import android.preference.PreferenceManager; import android.support.annotation.NonNull; @@ -159,4 +161,15 @@ public class Utils { return stringBuilder.toString(); } -} + + public static void rateApp(Context context) { + final String appPackageName = context.getPackageName(); + try { + context.startActivity(new Intent(Intent.ACTION_VIEW, Uri.parse("market://details?id=" + appPackageName))); + } + catch (android.content.ActivityNotFoundException anfe) { + context.startActivity(new Intent(Intent.ACTION_VIEW, Uri.parse("https://play.google.com/store/apps/details?id=" + appPackageName))); + } + return ; + } +} \ No newline at end of file diff --git a/app/src/main/java/fr/free/nrw/commons/theme/NavigationBaseActivity.java b/app/src/main/java/fr/free/nrw/commons/theme/NavigationBaseActivity.java index 5d577e73d..a2c85d50b 100644 --- a/app/src/main/java/fr/free/nrw/commons/theme/NavigationBaseActivity.java +++ b/app/src/main/java/fr/free/nrw/commons/theme/NavigationBaseActivity.java @@ -23,6 +23,7 @@ import fr.free.nrw.commons.AboutActivity; import fr.free.nrw.commons.BuildConfig; import fr.free.nrw.commons.CommonsApplication; import fr.free.nrw.commons.R; +import fr.free.nrw.commons.Utils; import fr.free.nrw.commons.WelcomeActivity; import fr.free.nrw.commons.auth.AccountUtil; import fr.free.nrw.commons.auth.LoginActivity; @@ -133,17 +134,6 @@ public abstract class NavigationBaseActivity extends BaseActivity Toast.makeText(this, R.string.no_email_client, Toast.LENGTH_SHORT).show(); } return true; - case R.id.action_rate: - drawerLayout.closeDrawer(navigationView); - final String appPackageName = getPackageName(); - Toast.makeText(this, appPackageName, Toast.LENGTH_SHORT).show(); - try { - startActivity(new Intent(Intent.ACTION_VIEW, Uri.parse("market://details?id=" + appPackageName))); - } - catch (android.content.ActivityNotFoundException anfe) { - startActivity(new Intent(Intent.ACTION_VIEW, Uri.parse("https://play.google.com/store/apps/details?id=" + appPackageName))); - } - return true; case R.id.action_logout: new AlertDialog.Builder(this) .setMessage(R.string.logout_verification) diff --git a/app/src/main/res/drawable-hdpi/ic_star_black_24dp.png b/app/src/main/res/drawable-hdpi/ic_star_black_24dp.png deleted file mode 100644 index 8ab80a62264238e19bfbeaddaa76efe9ec6b96eb..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 440 zcmV;p0Z0CcP)wx8@;|HT1YAW0<{w_Fb3l1ba2cw zAT}a4>g0j=Dh(ZT8HnXbO;7wlyoUyk*#*RWr&kBeyK=q!XmSgy#QIL%mJ;VY~waQKY{oM5R1~nf?6Q{55-l~Hk<{BpCDQA2#A@fX+ap0;V>LT ziGcz@tOmq3KpY6fXRugs5-Mj6RVzTq&h6c`S}?NGCD zf(#)3Lx#b>fjE`eIPe7G&mMAasU7g?2`KWwX|vg00001r;P)$$Y#C}JZb_wfC8BU^lQwk^vV?AEKYz^S zH^4ouS*98uIy)TH!%jUj(lGFW6A%Q?Ad-eTRz#?Gki7WFTT0nzLDXOzr?Z0<(HLwL z^P9k$$qwO_Q%`&9jNDZ9#nw~j^+dO zD9Tl(;E02HKPVA(GAoaVOAO5~W^?jpst$$$T5~bHO)?CSlM&m`Fu;Lm^U6H`!Z5&- z=m2#bcA;940fsmPaElDEq0`hQq37B)kpV&}%)EmUIxiGP>9b^Ou0@%zOkre)u8B8> z?50>-E+Rl*g67JjU#E`sUEnG~4VQ=j3o%W@V4U7a>y?$>A%$aV&5H;S&@|iw)mhZ4 z0sESI=OQN2U%KI(4C{7-8_WMcI>kH#w1X*n=w~gZ<}_%rm@;L`lr;JS9nnljg}Zh9 P00000NkvXXu0mjfGgke@ diff --git a/app/src/main/res/drawable-xxhdpi/ic_star_black_24dp.png b/app/src/main/res/drawable-xxhdpi/ic_star_black_24dp.png deleted file mode 100644 index abc65dfe8c247ab9a5f29137da513e4016c3b01d..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 844 zcmV-S1GD^zP)9w-mv7Dp&A#LFp44RURyc$pdxnv|4F6bX$o5A&eG!+0YKrQxJ8 zq4D5NLP!}#io_TUGX7uZ+d0^0pM5!JueJ92{`GsA&g`|;Z>GK0`qny*BauiX5{aZd zS;R<+C+vLm&A&2+{rrRW_HKZV-#TGf^KwktwA3>E3f_6lZF$6tKvz*aj zeGEA+YrrT|YB-ZX24q1!XaYxge{}`i1J5JAb4t<2&+Z17K^wQ-#C^$f->8qnDj{Gw zXaom%*0}(>z$5UUr`|zBpuWE2zIX9hT6t`ZJl4=z0D29Q5S3mYYotsC4^k|L#x|uK z>y}&!<=o)0l_ev<*%ZlXb1HNwu+MNY^s?Sl>FIs5lRw}yO%5GMZc1tmw3MfMQ{>PT zza;5};tXD>=`QCfs8zL^uHlueu5#{zY901i7d4b~UZ*`971f(Hl5>nJ2ik?|H9r-K z`2iYq-{sQ@#AgL^K7kdc)PClJHwnsl?c~q+jmn(_1$CMxXC$v&lM>X=`$c22Siw8U zsN1o-6$mowlEYO6f-aeKw4-7p`_>devlT8BYfTW;pis~@69ly@6m-S}L2+tCUzw=C z|5$f9lVc2yX1-}moLR71XF*ZU-szrVoyW84oM3kt|7Eq#f?7fr(GPLK&94}DIOHKg zv(AF<2OLC4$SIjVdp+Q@yLFXQ6`)x560D8U27SS$r$ieACH^awCF|4a@8BpHQ>H(} zaeij8_Lk`==wOk~-UKr%v|{fp(x#SQ$jfkx}9N1Q?rO z`*cg=WWhV|gQMBk7Z!5I==Rneh5g7BlzKBd3EBv@XjE?58gsUkNF)-8L?V$${PP=) WT`Ll6gAF7A0000H@P(!i!!-OuvH%y^;yyvh<0S;0;-VzUfH7URsuphtqm~>d>nxA zAL3+@lUBcg?YI}OE;*Go?I?SYHDB8$t z#I~{)jA!ll@~YHOOV(}rQI$sCb#RETbHKcjcR}Lt&-&R=3l~v1g(qA1ytx>dd&{yU zEWi>LAofUDfIux@tdp<+SAr6L3|`>KR)7|4qi9dM#AiXXf>3}Gi3_kb2nDESa!;&l zO{C;~q4(Iy)s~40v?7vqF2Du_3b0P+0-RK!09ro?R)v;yy{_RWF?Hqx5_K%VO2HxV zbx1j==ru{pbu56WwWNGG;C|Ne;e2uU{;h(xu}{YW+!YYaHE^=YHc|yO`n0>Fvaice zC%@4;&*DW=1irSx#rF8)4YYdJ&_Wl78$Np$?_it#!9&dX>h1YD6<{ZGHaRZh*D=!Y zkYacH+jT0yWg9!rpAnJI#Lmz1_gW8rv@woLx`f}2nLlng^ht+DzyThPh5ypVQHzJA zW)`NqUPLp^!p`0TXZSd#nc!^;<4V<`0L9FF`CmbpK52ZLh0MG?UZ_I>&X_d421_tL zz6!4LA7ebNLjgLs3GRWjB^>7*@P4PUzEM5=F(Es{AHKSY$^BzH(Rj#g4jK1Il?#xI zJHhXmNl<9q{IN8raO|s9{{l`|c>Mfon0^p~AP9mW2!bF8f*=Tj5W*jNP%vNGd;WI- O0000 + - - Thank you for making an edit %1$s mentioned you on %2$s. Toggle view - Rate Us + Rate Us From 6277272206a44c8cc95e44a452f38e97553268d9 Mon Sep 17 00:00:00 2001 From: Ujjwal Agrawal Date: Wed, 28 Feb 2018 00:47:10 +0530 Subject: [PATCH 3/3] Fix merge conflicts --- app/src/main/res/layout/activity_about.xml | 35 +++------------------- 1 file changed, 4 insertions(+), 31 deletions(-) diff --git a/app/src/main/res/layout/activity_about.xml b/app/src/main/res/layout/activity_about.xml index 892da2fa6..00c7fa5b8 100644 --- a/app/src/main/res/layout/activity_about.xml +++ b/app/src/main/res/layout/activity_about.xml @@ -104,35 +104,6 @@ - - - - - - - - - -